Re: [Xen-devel] [PATCH v2 09/45] ARM: GIC: Allow tweaking the active and pending state of an IRQ

2018-03-19 Thread Julien Grall
Hi Andre, On 03/19/2018 05:54 PM, Andre Przywara wrote: Which helpers? The set_{pending,active}_state() functions? I already put some kind of warning before the (wrapper) prototypes: /* * Set the active state of an IRQ. This should be used with care, as * this directly forces the active bit,

Re: [Xen-devel] [PATCH v2 09/45] ARM: GIC: Allow tweaking the active and pending state of an IRQ

2018-03-19 Thread Andre Przywara
Hi, On 19/03/18 09:30, Julien Grall wrote: > > > On 03/16/2018 04:05 PM, Andre Przywara wrote: >> Hi, > > Hi Andre, > >> On 15/03/18 20:30, Andre Przywara wrote: >>> +    } >>> +} >>> + >>> +static void gicv2_set_pending_state(struct irq_desc *irqd, bool >>> pending) >>> +{ >>> +    ASSERT(spi

Re: [Xen-devel] [PATCH v2 09/45] ARM: GIC: Allow tweaking the active and pending state of an IRQ

2018-03-18 Thread Julien Grall
On 03/16/2018 04:05 PM, Andre Przywara wrote: Hi, Hi Andre, On 15/03/18 20:30, Andre Przywara wrote: +} +} + +static void gicv2_set_pending_state(struct irq_desc *irqd, bool pending) +{ +ASSERT(spin_is_locked(&irqd->lock)); + +if ( pending ) +{ +/* The INPROGRESS bi

Re: [Xen-devel] [PATCH v2 09/45] ARM: GIC: Allow tweaking the active and pending state of an IRQ

2018-03-16 Thread Andre Przywara
Hi, On 15/03/18 20:30, Andre Przywara wrote: > When playing around with hardware mapped, level triggered virtual IRQs, > there is the need to explicitly set the active or pending state of an > interrupt at some point. > To prepare the GIC for that, we introduce a set_active_state() and a > set_pen

[Xen-devel] [PATCH v2 09/45] ARM: GIC: Allow tweaking the active and pending state of an IRQ

2018-03-15 Thread Andre Przywara
When playing around with hardware mapped, level triggered virtual IRQs, there is the need to explicitly set the active or pending state of an interrupt at some point. To prepare the GIC for that, we introduce a set_active_state() and a set_pending_state() function to let the VGIC manipulate the sta