Re: [Xen-devel] [PATCH v2 1/4] x86/ioapic: only use dest32 with x2apic and interrupt remapping enabled

2019-12-04 Thread Roger Pau Monné
On Tue, Dec 03, 2019 at 04:11:07PM +0100, Jan Beulich wrote: > On 29.11.2019 12:28, Roger Pau Monne wrote: > > --- a/xen/arch/x86/io_apic.c > > +++ b/xen/arch/x86/io_apic.c > > @@ -562,7 +562,7 @@ set_ioapic_affinity_irq(struct irq_desc *desc, const > > cpumask_t *mask) > > > > dest =

Re: [Xen-devel] [PATCH v2 1/4] x86/ioapic: only use dest32 with x2apic and interrupt remapping enabled

2019-12-03 Thread Jan Beulich
On 29.11.2019 12:28, Roger Pau Monne wrote: > --- a/xen/arch/x86/io_apic.c > +++ b/xen/arch/x86/io_apic.c > @@ -562,7 +562,7 @@ set_ioapic_affinity_irq(struct irq_desc *desc, const > cpumask_t *mask) > > dest = set_desc_affinity(desc, mask); > if (dest != BAD_APICID) { > -if (

[Xen-devel] [PATCH v2 1/4] x86/ioapic: only use dest32 with x2apic and interrupt remapping enabled

2019-11-29 Thread Roger Pau Monne
The IO-APIC code assumes that x2apic being enabled also implies interrupt remapping being enabled, and hence will use the 32bit destination field in the IO-APIC entry. This is safe now, but there's no reason to not enable x2APIC even without interrupt remapping, and hence the IO-APIC code needs