Re: [Xen-devel] [PATCH v2 2/2] block/xen-blkback: allow module to be cleanly unloaded

2019-11-29 Thread Jürgen Groß
On 29.11.19 16:07, Roger Pau Monné wrote: On Fri, Nov 29, 2019 at 03:02:37PM +, Durrant, Paul wrote: -Original Message- From: Roger Pau Monné Sent: 29 November 2019 15:00 To: Durrant, Paul Cc: linux-bl...@vger.kernel.org; linux-ker...@vger.kernel.org; xen-

Re: [Xen-devel] [PATCH v2 2/2] block/xen-blkback: allow module to be cleanly unloaded

2019-11-29 Thread Roger Pau Monné
On Fri, Nov 29, 2019 at 03:02:37PM +, Durrant, Paul wrote: > > -Original Message- > > From: Roger Pau Monné > > Sent: 29 November 2019 15:00 > > To: Durrant, Paul > > Cc: linux-bl...@vger.kernel.org; linux-ker...@vger.kernel.org; xen- > > de...@lists.xenproject.org; Konrad Rzeszutek

Re: [Xen-devel] [PATCH v2 2/2] block/xen-blkback: allow module to be cleanly unloaded

2019-11-29 Thread Durrant, Paul
> -Original Message- > From: Roger Pau Monné > Sent: 29 November 2019 15:00 > To: Durrant, Paul > Cc: linux-bl...@vger.kernel.org; linux-ker...@vger.kernel.org; xen- > de...@lists.xenproject.org; Konrad Rzeszutek Wilk > ; Jens Axboe > Subject: Re: [PATCH v2 2/2] block/xen-blkback: allow

Re: [Xen-devel] [PATCH v2 2/2] block/xen-blkback: allow module to be cleanly unloaded

2019-11-29 Thread Roger Pau Monné
On Fri, Nov 29, 2019 at 01:43:06PM +, Paul Durrant wrote: > Add a module_exit() to perform the necessary clean-up. > > Signed-off-by: Paul Durrant LGTM: Reviewed-by: Roger Pau Monné AFAICT we should make sure this is not committed before patch 1, or else you could unload a blkback module

[Xen-devel] [PATCH v2 2/2] block/xen-blkback: allow module to be cleanly unloaded

2019-11-29 Thread Paul Durrant
Add a module_exit() to perform the necessary clean-up. Signed-off-by: Paul Durrant --- Cc: Konrad Rzeszutek Wilk Cc: "Roger Pau Monné" Cc: Jens Axboe v2: - Drop the addition of ad-hoc reference counting as this is now done centrally in xenbus --- drivers/block/xen-blkback/blkback.c | 8