Re: [Xen-devel] [PATCH v2 2/2] x86/xpti: don't map stack guard pages

2018-03-05 Thread Jan Beulich
>>> On 02.03.18 at 18:33, wrote: > On 02/03/18 14:35, Jan Beulich wrote: >> Other than for the main mappings, don't even do this in release builds, >> as there are no huge page shattering concerns here. >> >> Signed-off-by: Jan Beulich > > Acked-by: Andrew Cooper , although I think > somewhere (

Re: [Xen-devel] [PATCH v2 2/2] x86/xpti: don't map stack guard pages

2018-03-02 Thread Andrew Cooper
On 02/03/18 14:35, Jan Beulich wrote: > Other than for the main mappings, don't even do this in release builds, > as there are no huge page shattering concerns here. > > Signed-off-by: Jan Beulich Acked-by: Andrew Cooper , although I think somewhere (even if its only the commit message) might wan

Re: [Xen-devel] [PATCH v2 2/2] x86/xpti: don't map stack guard pages

2018-03-02 Thread Jan Beulich
>>> On 02.03.18 at 17:41, wrote: > On 02/03/18 17:10, Jan Beulich wrote: > On 02.03.18 at 16:43, wrote: >>> On 02/03/18 15:35, Jan Beulich wrote: --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -5576,6 +5576,14 @@ void memguard_unguard_stack(void *p)

Re: [Xen-devel] [PATCH v2 2/2] x86/xpti: don't map stack guard pages

2018-03-02 Thread Juergen Gross
On 02/03/18 17:10, Jan Beulich wrote: On 02.03.18 at 16:43, wrote: >> On 02/03/18 15:35, Jan Beulich wrote: >>> --- a/xen/arch/x86/mm.c >>> +++ b/xen/arch/x86/mm.c >>> @@ -5576,6 +5576,14 @@ void memguard_unguard_stack(void *p) >>> STACK_SIZE - PRIMARY_STACK_SIZE -

Re: [Xen-devel] [PATCH v2 2/2] x86/xpti: don't map stack guard pages

2018-03-02 Thread Jan Beulich
>>> On 02.03.18 at 16:43, wrote: > On 02/03/18 15:35, Jan Beulich wrote: >> --- a/xen/arch/x86/mm.c >> +++ b/xen/arch/x86/mm.c >> @@ -5576,6 +5576,14 @@ void memguard_unguard_stack(void *p) >> STACK_SIZE - PRIMARY_STACK_SIZE - IST_MAX * >> PAGE_SIZE); >> } >> >> +bo

Re: [Xen-devel] [PATCH v2 2/2] x86/xpti: don't map stack guard pages

2018-03-02 Thread Juergen Gross
On 02/03/18 15:35, Jan Beulich wrote: > Other than for the main mappings, don't even do this in release builds, > as there are no huge page shattering concerns here. > > Signed-off-by: Jan Beulich > --- > v2: New. > > --- a/xen/arch/x86/smpboot.c > +++ b/xen/arch/x86/smpboot.c > @@ -799,7 +799,8

[Xen-devel] [PATCH v2 2/2] x86/xpti: don't map stack guard pages

2018-03-02 Thread Jan Beulich
Other than for the main mappings, don't even do this in release builds, as there are no huge page shattering concerns here. Signed-off-by: Jan Beulich --- v2: New. --- a/xen/arch/x86/smpboot.c +++ b/xen/arch/x86/smpboot.c @@ -799,7 +799,8 @@ static int setup_cpu_root_pgt(unsigned i /* Ins