Re: [Xen-devel] [PATCH v2 2/2] xen/x86: hap: Clean-up and harden hap_enable()

2020-03-04 Thread Julien Grall
On 03/03/2020 13:25, Jan Beulich wrote: On 04.02.2020 14:06, Julien Grall wrote: From: Julien Grall Unlike shadow_enable(), hap_enable() can only be called once during domain creation and with the mode equal to mode equal to PG_external | PG_translate | PG_refcounts. If it were called

Re: [Xen-devel] [PATCH v2 2/2] xen/x86: hap: Clean-up and harden hap_enable()

2020-03-03 Thread Julien Grall
On 03/03/2020 13:27, Jan Beulich wrote: On 03.03.2020 13:21, Julien Grall wrote: Ping again. To be honest, with the recent maintainer change it would probably have been helpful if you had simply re-sent the patch. Well, I don't think you can expect a contributor to resend a patch because

Re: [Xen-devel] [PATCH v2 2/2] xen/x86: hap: Clean-up and harden hap_enable()

2020-03-03 Thread Jan Beulich
On 03.03.2020 13:21, Julien Grall wrote: > Ping again. To be honest, with the recent maintainer change it would probably have been helpful if you had simply re-sent the patch. I did see it back then, but had no comments to make and didn't have the authority to ack it, so simply dropped it from my

Re: [Xen-devel] [PATCH v2 2/2] xen/x86: hap: Clean-up and harden hap_enable()

2020-03-03 Thread Jan Beulich
On 04.02.2020 14:06, Julien Grall wrote: > From: Julien Grall > > Unlike shadow_enable(), hap_enable() can only be called once during > domain creation and with the mode equal to mode equal to > PG_external | PG_translate | PG_refcounts. > > If it were called twice, then we might have something

Re: [Xen-devel] [PATCH v2 2/2] xen/x86: hap: Clean-up and harden hap_enable()

2020-03-03 Thread Julien Grall
Ping again. On 13/02/2020 12:44, Julien Grall wrote: Hi, Gentle ping. Cheers, On 04/02/2020 14:06, Julien Grall wrote: From: Julien Grall Unlike shadow_enable(), hap_enable() can only be called once during domain creation and with the mode equal to mode equal to PG_external | PG_translate

Re: [Xen-devel] [PATCH v2 2/2] xen/x86: hap: Clean-up and harden hap_enable()

2020-02-13 Thread Julien Grall
Hi, Gentle ping. Cheers, On 04/02/2020 14:06, Julien Grall wrote: From: Julien Grall Unlike shadow_enable(), hap_enable() can only be called once during domain creation and with the mode equal to mode equal to PG_external | PG_translate | PG_refcounts. If it were called twice, then we

Re: [Xen-devel] [PATCH v2 2/2] xen/x86: hap: Clean-up and harden hap_enable()

2020-02-04 Thread Julien Grall
: [Xen-devel] [PATCH v2 2/2] xen/x86: hap: Clean-up and harden hap_enable() From: Julien Grall Unlike shadow_enable(), hap_enable() can only be called once during domain creation and with the mode equal to mode equal to PG_external | PG_translate | PG_refcounts. If it were called twice, then we

Re: [Xen-devel] [PATCH v2 2/2] xen/x86: hap: Clean-up and harden hap_enable()

2020-02-04 Thread Durrant, Paul
ect: [Xen-devel] [PATCH v2 2/2] xen/x86: hap: Clean-up and harden > hap_enable() > > From: Julien Grall > > Unlike shadow_enable(), hap_enable() can only be called once during > domain creation and with the mode equal to mode equal to > PG_external | PG_translate | PG_refcount

[Xen-devel] [PATCH v2 2/2] xen/x86: hap: Clean-up and harden hap_enable()

2020-02-04 Thread Julien Grall
From: Julien Grall Unlike shadow_enable(), hap_enable() can only be called once during domain creation and with the mode equal to mode equal to PG_external | PG_translate | PG_refcounts. If it were called twice, then we might have something interesting problem as the p2m tables would be