Re: [Xen-devel] [PATCH v3] tools/hotpug: only attempt to call 'ip route' if there is valid command

2019-11-12 Thread Wei Liu
On Tue, Nov 12, 2019 at 11:01:26AM +0100, Jürgen Groß wrote: > On 08.11.19 11:31, Wei Liu wrote: > > On Fri, Nov 08, 2019 at 09:42:33AM +, p...@xen.org wrote: > > > From: Paul Durrant > > > > > > The vif-route script should only call 'ip route' when 'ipcmd' has been > > > set, otherwise it

Re: [Xen-devel] [PATCH v3] tools/hotpug: only attempt to call 'ip route' if there is valid command

2019-11-12 Thread Jürgen Groß
On 08.11.19 11:31, Wei Liu wrote: On Fri, Nov 08, 2019 at 09:42:33AM +, p...@xen.org wrote: From: Paul Durrant The vif-route script should only call 'ip route' when 'ipcmd' has been set, otherwise it will fail due to an incorrect command string. This patch also adds routes for 'tap'

Re: [Xen-devel] [PATCH v3] tools/hotpug: only attempt to call 'ip route' if there is valid command

2019-11-08 Thread Wei Liu
On Fri, Nov 08, 2019 at 09:42:33AM +, p...@xen.org wrote: > From: Paul Durrant > > The vif-route script should only call 'ip route' when 'ipcmd' has been > set, otherwise it will fail due to an incorrect command string. > > This patch also adds routes for 'tap' (i.e. emulated) devices as

[Xen-devel] [PATCH v3] tools/hotpug: only attempt to call 'ip route' if there is valid command

2019-11-08 Thread paul
From: Paul Durrant The vif-route script should only call 'ip route' when 'ipcmd' has been set, otherwise it will fail due to an incorrect command string. This patch also adds routes for 'tap' (i.e. emulated) devices as well as 'vif' (i.e. PV) devices. Empirically offline/online commands relate