Re: [Xen-devel] [PATCH v3 09/15] argo: implement the sendv op; evtchn: expose send_guest_global_virq

2019-01-10 Thread Christopher Clark
On Thu, Jan 10, 2019 at 1:41 PM Eric Chanudet wrote: > > On 06/01/19 at 11:42pm, Christopher Clark wrote: > >+memcpy_to_guest_ring(struct argo_ring_info *ring_info, uint32_t offset, > >+ const void *src, XEN_GUEST_HANDLE(uint8_t) src_hnd, > >+ uint32_t len)

Re: [Xen-devel] [PATCH v3 09/15] argo: implement the sendv op; evtchn: expose send_guest_global_virq

2019-01-10 Thread Christopher Clark
On Thu, Jan 10, 2019 at 4:53 AM Jan Beulich wrote: > > >>> On 10.01.19 at 13:40, wrote: > > On Thu, Jan 10, 2019 at 1:13 PM Jan Beulich wrote: > >> > >> >>> On 10.01.19 at 13:01, wrote: > >> > On Thu, Jan 10, 2019 at 4:10 AM Christopher Clark > > wrote: > >> >> > >> >> The second reason is

Re: [Xen-devel] [PATCH v3 09/15] argo: implement the sendv op; evtchn: expose send_guest_global_virq

2019-01-10 Thread Eric Chanudet
On 06/01/19 at 11:42pm, Christopher Clark wrote: +memcpy_to_guest_ring(struct argo_ring_info *ring_info, uint32_t offset, + const void *src, XEN_GUEST_HANDLE(uint8_t) src_hnd, + uint32_t len) +{ +unsigned int mfns_index = offset >> PAGE_SHIFT; +

Re: [Xen-devel] [PATCH v3 09/15] argo: implement the sendv op; evtchn: expose send_guest_global_virq

2019-01-10 Thread Jan Beulich
>>> On 10.01.19 at 13:40, wrote: > On Thu, Jan 10, 2019 at 1:13 PM Jan Beulich wrote: >> >> >>> On 10.01.19 at 13:01, wrote: >> > On Thu, Jan 10, 2019 at 4:10 AM Christopher Clark > wrote: >> >> >> >> The second reason is about avoiding exposing the Xen virtual memory >> >> allocator directly

Re: [Xen-devel] [PATCH v3 09/15] argo: implement the sendv op; evtchn: expose send_guest_global_virq

2019-01-10 Thread Roger Pau Monné
On Thu, Jan 10, 2019 at 1:13 PM Jan Beulich wrote: > > >>> On 10.01.19 at 13:01, wrote: > > On Thu, Jan 10, 2019 at 4:10 AM Christopher Clark > > wrote: > >> > >> The second reason is about avoiding exposing the Xen virtual memory > >> allocator directly to frequent guest-supplied size

Re: [Xen-devel] [PATCH v3 09/15] argo: implement the sendv op; evtchn: expose send_guest_global_virq

2019-01-10 Thread Jan Beulich
>>> On 10.01.19 at 13:01, wrote: > On Thu, Jan 10, 2019 at 4:10 AM Christopher Clark > wrote: >> >> The second reason is about avoiding exposing the Xen virtual memory >> allocator directly to frequent guest-supplied size requests for >> contiguous regions (of up to 16GB). > > As said in

Re: [Xen-devel] [PATCH v3 09/15] argo: implement the sendv op; evtchn: expose send_guest_global_virq

2019-01-10 Thread Roger Pau Monné
On Thu, Jan 10, 2019 at 4:10 AM Christopher Clark wrote: > > Thanks for the review, Roger. Replies inline below. > > On Wed, Jan 9, 2019 at 10:57 AM Roger Pau Monné wrote: > > > > to.On Mon, Jan 7, 2019 at 8:44 AM Christopher Clark > > wrote: > > > > > > sendv operation is invoked to perform a

Re: [Xen-devel] [PATCH v3 09/15] argo: implement the sendv op; evtchn: expose send_guest_global_virq

2019-01-09 Thread Christopher Clark
Thanks for the review, Roger. Replies inline below. On Wed, Jan 9, 2019 at 10:57 AM Roger Pau Monné wrote: > > to.On Mon, Jan 7, 2019 at 8:44 AM Christopher Clark > wrote: > > > > sendv operation is invoked to perform a synchronous send of buffers > > contained in iovs to a remote domain's

Re: [Xen-devel] [PATCH v3 09/15] argo: implement the sendv op; evtchn: expose send_guest_global_virq

2019-01-09 Thread Christopher Clark
On Wed, Jan 9, 2019 at 10:05 AM Jason Andryuk wrote: > > On Mon, Jan 7, 2019 at 2:43 AM Christopher Clark > wrote: > > > > > @@ -342,6 +357,413 @@ update_tx_ptr(struct argo_ring_info *ring_info, > > uint32_t tx_ptr) > > smp_wmb(); > > } > > > > +static int > >

Re: [Xen-devel] [PATCH v3 09/15] argo: implement the sendv op; evtchn: expose send_guest_global_virq

2019-01-09 Thread Roger Pau Monné
to.On Mon, Jan 7, 2019 at 8:44 AM Christopher Clark wrote: > > sendv operation is invoked to perform a synchronous send of buffers > contained in iovs to a remote domain's registered ring. > > It takes: > * A destination address (domid, port) for the ring to send to. >It performs a

Re: [Xen-devel] [PATCH v3 09/15] argo: implement the sendv op; evtchn: expose send_guest_global_virq

2019-01-09 Thread Jason Andryuk
On Mon, Jan 7, 2019 at 2:43 AM Christopher Clark wrote: > @@ -342,6 +357,413 @@ update_tx_ptr(struct argo_ring_info *ring_info, > uint32_t tx_ptr) > smp_wmb(); > } > > +static int > +memcpy_to_guest_ring(struct argo_ring_info *ring_info, uint32_t offset, > + const

[Xen-devel] [PATCH v3 09/15] argo: implement the sendv op; evtchn: expose send_guest_global_virq

2019-01-06 Thread Christopher Clark
sendv operation is invoked to perform a synchronous send of buffers contained in iovs to a remote domain's registered ring. It takes: * A destination address (domid, port) for the ring to send to. It performs a most-specific match lookup, to allow for wildcard. * A source address, used to