Re: [Xen-devel] [PATCH v3 11/14] AMD/IOMMU: adjust setup of internal interrupt for x2APIC mode

2019-07-22 Thread Jan Beulich
On 22.07.2019 15:45, Andrew Cooper wrote: > On 22/07/2019 09:43, Jan Beulich wrote: >> On 19.07.2019 19:31, Andrew Cooper wrote: >>> On 16/07/2019 17:39, Jan Beulich wrote: --- a/xen/include/asm-x86/hvm/svm/amd-iommu-defs.h +++ b/xen/include/asm-x86/hvm/svm/amd-iommu-defs.h @@

Re: [Xen-devel] [PATCH v3 11/14] AMD/IOMMU: adjust setup of internal interrupt for x2APIC mode

2019-07-22 Thread Andrew Cooper
On 22/07/2019 09:43, Jan Beulich wrote: > On 19.07.2019 19:31, Andrew Cooper wrote: >> On 16/07/2019 17:39, Jan Beulich wrote: >>> --- a/xen/include/asm-x86/hvm/svm/amd-iommu-defs.h >>> +++ b/xen/include/asm-x86/hvm/svm/amd-iommu-defs.h >>> @@ -416,6 +416,25 @@ union amd_iommu_ext_features { >>>

Re: [Xen-devel] [PATCH v3 11/14] AMD/IOMMU: adjust setup of internal interrupt for x2APIC mode

2019-07-22 Thread Jan Beulich
On 19.07.2019 19:31, Andrew Cooper wrote: > On 16/07/2019 17:39, Jan Beulich wrote: >> --- a/xen/include/asm-x86/hvm/svm/amd-iommu-defs.h >> +++ b/xen/include/asm-x86/hvm/svm/amd-iommu-defs.h >> @@ -416,6 +416,25 @@ union amd_iommu_ext_features { >>} flds; >>}; >> >> +/* x2APIC

Re: [Xen-devel] [PATCH v3 11/14] AMD/IOMMU: adjust setup of internal interrupt for x2APIC mode

2019-07-19 Thread Woods, Brian
On Tue, Jul 16, 2019 at 04:39:58PM +, Jan Beulich wrote: > In order to be able to express all possible destinations we need to make > use of this non-MSI-capability based mechanism. The new IRQ controller > structure can re-use certain MSI functions, though. > > For now general and PPR

Re: [Xen-devel] [PATCH v3 11/14] AMD/IOMMU: adjust setup of internal interrupt for x2APIC mode

2019-07-19 Thread Andrew Cooper
On 16/07/2019 17:39, Jan Beulich wrote: > --- a/xen/include/asm-x86/hvm/svm/amd-iommu-defs.h > +++ b/xen/include/asm-x86/hvm/svm/amd-iommu-defs.h > @@ -416,6 +416,25 @@ union amd_iommu_ext_features { > } flds; > }; > > +/* x2APIC Control Registers */ > +#define

[Xen-devel] [PATCH v3 11/14] AMD/IOMMU: adjust setup of internal interrupt for x2APIC mode

2019-07-16 Thread Jan Beulich
In order to be able to express all possible destinations we need to make use of this non-MSI-capability based mechanism. The new IRQ controller structure can re-use certain MSI functions, though. For now general and PPR interrupts still share a single vector, IRQ, and hence handler.