Re: [Xen-devel] [PATCH v3 21/22] golang/xenlight: revise use of Context type

2019-12-17 Thread George Dunlap
On 12/10/19 3:47 PM, Nick Rosbrook wrote: > From: Nick Rosbrook > > Remove the exported global context variable, 'Ctx.' Generally, it is > better to not export global variables for use through a Go package. > However, there are some exceptions that can be found in the standard > library. > > Add

[Xen-devel] [PATCH v3 21/22] golang/xenlight: revise use of Context type

2019-12-10 Thread Nick Rosbrook
From: Nick Rosbrook Remove the exported global context variable, 'Ctx.' Generally, it is better to not export global variables for use through a Go package. However, there are some exceptions that can be found in the standard library. Add a NewContext function instead, and remove the Open, IsOpe