Re: [Xen-devel] [PATCH v3 3/9] xen/balloon: Share common memory reservation routines

2018-06-13 Thread Oleksandr Andrushchenko
On 06/13/2018 03:03 PM, Oleksandr Andrushchenko wrote: On 06/13/2018 03:02 PM, Boris Ostrovsky wrote: On 06/13/2018 02:26 AM, Oleksandr Andrushchenko wrote: On 06/13/2018 03:47 AM, Boris Ostrovsky wrote: On 06/12/2018 09:41 AM, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko

Re: [Xen-devel] [PATCH v3 3/9] xen/balloon: Share common memory reservation routines

2018-06-13 Thread Oleksandr Andrushchenko
On 06/13/2018 03:02 PM, Boris Ostrovsky wrote: On 06/13/2018 02:26 AM, Oleksandr Andrushchenko wrote: On 06/13/2018 03:47 AM, Boris Ostrovsky wrote: On 06/12/2018 09:41 AM, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko diff --git a/include/xen/mem-reservation.h

Re: [Xen-devel] [PATCH v3 3/9] xen/balloon: Share common memory reservation routines

2018-06-13 Thread Boris Ostrovsky
On 06/13/2018 02:26 AM, Oleksandr Andrushchenko wrote: On 06/13/2018 03:47 AM, Boris Ostrovsky wrote: On 06/12/2018 09:41 AM, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko diff --git a/include/xen/mem-reservation.h b/include/xen/mem-reservation.h new file mode 100644

Re: [Xen-devel] [PATCH v3 3/9] xen/balloon: Share common memory reservation routines

2018-06-13 Thread Oleksandr Andrushchenko
On 06/13/2018 04:07 AM, Boris Ostrovsky wrote: On 06/12/2018 09:41 AM, Oleksandr Andrushchenko wrote: One more thing: please add a comment here saying that frames array is array of PFNs (in Xen granularity), which is what XENMEM_populate_physmap requires. And remove (or update to name the

Re: [Xen-devel] [PATCH v3 3/9] xen/balloon: Share common memory reservation routines

2018-06-13 Thread Oleksandr Andrushchenko
On 06/13/2018 03:47 AM, Boris Ostrovsky wrote: On 06/12/2018 09:41 AM, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko diff --git a/include/xen/mem-reservation.h b/include/xen/mem-reservation.h new file mode 100644 index ..e0939387278d --- /dev/null +++

Re: [Xen-devel] [PATCH v3 3/9] xen/balloon: Share common memory reservation routines

2018-06-12 Thread Boris Ostrovsky
On 06/12/2018 09:41 AM, Oleksandr Andrushchenko wrote: One more thing: please add a comment here saying that frames array is array of PFNs (in Xen granularity), which is what XENMEM_populate_physmap requires. And remove (or update to name the actual call you are making) the corresponding

Re: [Xen-devel] [PATCH v3 3/9] xen/balloon: Share common memory reservation routines

2018-06-12 Thread Boris Ostrovsky
On 06/12/2018 09:41 AM, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko diff --git a/include/xen/mem-reservation.h b/include/xen/mem-reservation.h new file mode 100644 index ..e0939387278d --- /dev/null +++ b/include/xen/mem-reservation.h @@ -0,0 +1,64 @@ +/*

[Xen-devel] [PATCH v3 3/9] xen/balloon: Share common memory reservation routines

2018-06-12 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko Memory {increase|decrease}_reservation and VA mappings update/reset code used in balloon driver can be made common, so other drivers can also re-use the same functionality without open-coding. Create a dedicated file for the shared code and export corresponding