Re: [Xen-devel] [PATCH v3 4/5] x86/boot: Copy 16-bit boot variables back up to Xen image

2019-09-02 Thread Jan Beulich
On 02.09.2019 15:52, David Woodhouse wrote: > On Mon, 2019-09-02 at 15:47 +0200, Jan Beulich wrote: >> On 02.09.2019 14:51, David Woodhouse wrote: >>> On Mon, 2019-09-02 at 09:44 +0200, Jan Beulich wrote: Right, just one pair should survive. And seeing how things work before this series

Re: [Xen-devel] [PATCH v3 4/5] x86/boot: Copy 16-bit boot variables back up to Xen image

2019-09-02 Thread David Woodhouse
On Mon, 2019-09-02 at 15:47 +0200, Jan Beulich wrote: > On 02.09.2019 14:51, David Woodhouse wrote: > > On Mon, 2019-09-02 at 09:44 +0200, Jan Beulich wrote: > > > Right, just one pair should survive. And seeing how things work before > > > this series I think it indeed should be linker script

Re: [Xen-devel] [PATCH v3 4/5] x86/boot: Copy 16-bit boot variables back up to Xen image

2019-09-02 Thread Jan Beulich
On 02.09.2019 14:51, David Woodhouse wrote: > On Mon, 2019-09-02 at 09:44 +0200, Jan Beulich wrote: >> Right, just one pair should survive. And seeing how things work before >> this series I think it indeed should be linker script symbols only. >> And then the ALIGN() ahead of the "start" ones

Re: [Xen-devel] [PATCH v3 4/5] x86/boot: Copy 16-bit boot variables back up to Xen image

2019-09-02 Thread David Woodhouse
On Mon, 2019-09-02 at 09:44 +0200, Jan Beulich wrote: > Right, just one pair should survive. And seeing how things work before > this series I think it indeed should be linker script symbols only. > And then the ALIGN() ahead of the "start" ones should stay, but there's > no need for one on the

Re: [Xen-devel] [PATCH v3 4/5] x86/boot: Copy 16-bit boot variables back up to Xen image

2019-09-02 Thread Jan Beulich
On 30.08.2019 18:25, David Woodhouse wrote: > On Fri, 2019-08-30 at 17:43 +0200, Jan Beulich wrote: >> On 21.08.2019 18:35, David Woodhouse wrote: >>> @@ -762,6 +773,11 @@ trampoline_setup: >>> mov $((boot_trampoline_end - boot_trampoline_start) / 4),%ecx >>> rep movsl

Re: [Xen-devel] [PATCH v3 4/5] x86/boot: Copy 16-bit boot variables back up to Xen image

2019-08-30 Thread David Woodhouse
On Fri, 2019-08-30 at 17:43 +0200, Jan Beulich wrote: > On 21.08.2019 18:35, David Woodhouse wrote: > > From: David Woodhouse > > > > Ditch the bootsym() access from C code for the variables populated by > > 16-bit boot code. As well as being cleaner this also paves the way for > > not having

Re: [Xen-devel] [PATCH v3 4/5] x86/boot: Copy 16-bit boot variables back up to Xen image

2019-08-30 Thread Jan Beulich
On 21.08.2019 18:35, David Woodhouse wrote: > From: David Woodhouse > > Ditch the bootsym() access from C code for the variables populated by > 16-bit boot code. As well as being cleaner this also paves the way for > not having the 16-bit boot code in low memory for no-real-mode or EFI > loader

[Xen-devel] [PATCH v3 4/5] x86/boot: Copy 16-bit boot variables back up to Xen image

2019-08-21 Thread David Woodhouse
From: David Woodhouse Ditch the bootsym() access from C code for the variables populated by 16-bit boot code. As well as being cleaner this also paves the way for not having the 16-bit boot code in low memory for no-real-mode or EFI loader boots at all. These variables are put into a separate