Re: [Xen-devel] [PATCH v4 0/2] Refactor super page shattering

2019-12-13 Thread Andrew Cooper
On 12/12/2019 13:16, Jan Beulich wrote: > On 12.12.2019 13:46, Hongyan Xia wrote: >> map_pages_to_xen and modify_xen_mappings use almost exactly the same >> page shattering logic, and the code is mingled with other PTE >> manipulations so it is less obvious that the intention is page >>

Re: [Xen-devel] [PATCH v4 0/2] Refactor super page shattering

2019-12-12 Thread Jan Beulich
On 12.12.2019 13:46, Hongyan Xia wrote: > map_pages_to_xen and modify_xen_mappings use almost exactly the same > page shattering logic, and the code is mingled with other PTE > manipulations so it is less obvious that the intention is page > shattering. Factor out the functions to make them

[Xen-devel] [PATCH v4 0/2] Refactor super page shattering

2019-12-12 Thread Hongyan Xia
map_pages_to_xen and modify_xen_mappings use almost exactly the same page shattering logic, and the code is mingled with other PTE manipulations so it is less obvious that the intention is page shattering. Factor out the functions to make them reusable and to make the intention more obvious. Of