Re: [Xen-devel] [PATCH v4 04/15] x86/cpu/vpmu: Add Hygon Dhyana and AMD Zen support for vPMU

2019-04-02 Thread Pu Wen
On 2019/4/2 23:50, Jan Beulich wrote: On 02.04.19 at 14:11, wrote: >> By the way, how about the patch 01/15 of this series? >> If it's fine, could you please offer Acked-by tag for it? > > I've yet to look at v4 of it. Andrew said the change of patch 01/15 should rebase over http://xenbits.

Re: [Xen-devel] [PATCH v4 04/15] x86/cpu/vpmu: Add Hygon Dhyana and AMD Zen support for vPMU

2019-04-02 Thread Jan Beulich
>>> On 02.04.19 at 14:11, wrote: > By the way, how about the patch 01/15 of this series? > If it's fine, could you please offer Acked-by tag for it? I've yet to look at v4 of it. Jan ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://

Re: [Xen-devel] [PATCH v4 04/15] x86/cpu/vpmu: Add Hygon Dhyana and AMD Zen support for vPMU

2019-04-02 Thread Pu Wen
On 2019/4/2 18:21, Jan Beulich wrote: > On 02.04.19 at 08:46, wrote: >> On 2019/4/1 16:36, Jan Beulich wrote: >>> On 30.03.19 at 11:42, wrote: --- a/xen/arch/x86/cpu/vpmu_amd.c +++ b/xen/arch/x86/cpu/vpmu_amd.c @@ -538,28 +538,12 @@ int svm_vpmu_initialise(struct vcpu *v)

Re: [Xen-devel] [PATCH v4 04/15] x86/cpu/vpmu: Add Hygon Dhyana and AMD Zen support for vPMU

2019-04-02 Thread Jan Beulich
>>> On 02.04.19 at 08:46, wrote: > On 2019/4/1 16:36, Jan Beulich wrote: >> On 30.03.19 at 11:42, wrote: >>> --- a/xen/arch/x86/cpu/vpmu_amd.c >>> +++ b/xen/arch/x86/cpu/vpmu_amd.c >>> @@ -538,28 +538,12 @@ int svm_vpmu_initialise(struct vcpu *v) >>> return 0; >>> } >>> >>> -int __init

Re: [Xen-devel] [PATCH v4 04/15] x86/cpu/vpmu: Add Hygon Dhyana and AMD Zen support for vPMU

2019-04-01 Thread Pu Wen
On 2019/4/1 16:36, Jan Beulich wrote: On 30.03.19 at 11:42, wrote: @@ -876,6 +877,10 @@ static int __init vpmu_init(void) if ( amd_vpmu_init() ) vpmu_mode = XENPMU_MODE_OFF; break; +case X86_VENDOR_HYGON: +if ( hygon_vpmu_init() ) + vpmu_mo

Re: [Xen-devel] [PATCH v4 04/15] x86/cpu/vpmu: Add Hygon Dhyana and AMD Zen support for vPMU

2019-04-01 Thread Jan Beulich
>>> On 30.03.19 at 11:42, wrote: > @@ -876,6 +877,10 @@ static int __init vpmu_init(void) > if ( amd_vpmu_init() ) > vpmu_mode = XENPMU_MODE_OFF; > break; > +case X86_VENDOR_HYGON: > +if ( hygon_vpmu_init() ) > + vpmu_mode = XENPMU_MODE_OFF; > +

[Xen-devel] [PATCH v4 04/15] x86/cpu/vpmu: Add Hygon Dhyana and AMD Zen support for vPMU

2019-03-30 Thread Pu Wen
As Hygon Dhyana CPU share similar PMU architecture with AMD family 17h one, so add Hygon Dhyana support in vpmu_arch_initialise() and vpmu_init() by sharing AMD code path. Split the common part in amd_vpmu_init() to a static function _vpmu_init(), making AMD and Hygon to call the shared function t