Re: [Xen-devel] [PATCH v4 14/23] xen/arm: generate a simple device tree for domUs

2018-10-17 Thread Stefano Stabellini
On Mon, 15 Oct 2018, Julien Grall wrote: > Hi Stefano, > > On 05/10/2018 19:47, Stefano Stabellini wrote: > > +static int __init make_gic_domU_node(const struct domain *d, void *fdt) > > +{ > > +switch ( gic_hw_version() ) > > While I understand that today domains will use the same GIC

Re: [Xen-devel] [PATCH v4 14/23] xen/arm: generate a simple device tree for domUs

2018-10-15 Thread Julien Grall
Hi Stefano, On 05/10/2018 19:47, Stefano Stabellini wrote: +static int __init make_gic_domU_node(const struct domain *d, void *fdt) +{ +switch ( gic_hw_version() ) While I understand that today domains will use the same GIC version as the host, it would be best if we don't rely on this

[Xen-devel] [PATCH v4 14/23] xen/arm: generate a simple device tree for domUs

2018-10-05 Thread Stefano Stabellini
Introduce functions to generate a basic domU device tree, similar to the existing functions in tools/libxl/libxl_arm.c. Signed-off-by: Stefano Stabellini --- Changes in v4: - code style - two separate functions for gicv2 and gicv3 - remove useless local variables - fix typos - do not use host