Re: [Xen-devel] [PATCH v4 22/32] libxl_qmp: Handle messages from QEMU

2018-08-21 Thread Ian Jackson
Anthony PERARD writes ("Re: [Xen-devel] [PATCH v4 22/32] libxl_qmp: Handle messages from QEMU"): > I've already tried to have qmp specific error number, I've been asked to > invent libxl error number instead: > https://lists.xenproject.org/archives/html/xen-devel/2018-07/msg

Re: [Xen-devel] [PATCH v4 22/32] libxl_qmp: Handle messages from QEMU

2018-08-21 Thread Anthony PERARD
On Tue, Aug 21, 2018 at 09:58:57AM +0100, Wei Liu wrote: > On Fri, Aug 03, 2018 at 06:25:00PM +0100, Anthony PERARD wrote: > > > > diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl > > > > index 4a385801ba..e104fea941 100644 > > > > --- a/tools/libxl/libxl_types.idl > > > >

Re: [Xen-devel] [PATCH v4 22/32] libxl_qmp: Handle messages from QEMU

2018-08-21 Thread Wei Liu
On Fri, Aug 03, 2018 at 06:25:00PM +0100, Anthony PERARD wrote: > > > diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl > > > index 4a385801ba..e104fea941 100644 > > > --- a/tools/libxl/libxl_types.idl > > > +++ b/tools/libxl/libxl_types.idl > > > @@ -69,6 +69,10 @@

Re: [Xen-devel] [PATCH v4 22/32] libxl_qmp: Handle messages from QEMU

2018-08-06 Thread Roger Pau Monné
On Mon, Aug 06, 2018 at 02:14:51PM +0100, Anthony PERARD wrote: > On Mon, Aug 06, 2018 at 01:25:22PM +0200, Roger Pau Monné wrote: > > On Fri, Aug 03, 2018 at 06:25:00PM +0100, Anthony PERARD wrote: > > > On Thu, Aug 02, 2018 at 01:17:37PM +0200, Roger Pau Monné wrote: > > > > On Fri, Jul 27, 2018

Re: [Xen-devel] [PATCH v4 22/32] libxl_qmp: Handle messages from QEMU

2018-08-06 Thread Anthony PERARD
On Mon, Aug 06, 2018 at 01:25:22PM +0200, Roger Pau Monné wrote: > On Fri, Aug 03, 2018 at 06:25:00PM +0100, Anthony PERARD wrote: > > On Thu, Aug 02, 2018 at 01:17:37PM +0200, Roger Pau Monné wrote: > > > On Fri, Jul 27, 2018 at 03:06:04PM +0100, Anthony PERARD wrote: > > > > diff --git

Re: [Xen-devel] [PATCH v4 22/32] libxl_qmp: Handle messages from QEMU

2018-08-06 Thread Roger Pau Monné
On Fri, Aug 03, 2018 at 06:25:00PM +0100, Anthony PERARD wrote: > On Thu, Aug 02, 2018 at 01:17:37PM +0200, Roger Pau Monné wrote: > > On Fri, Jul 27, 2018 at 03:06:04PM +0100, Anthony PERARD wrote: > > > diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl > > > index

Re: [Xen-devel] [PATCH v4 22/32] libxl_qmp: Handle messages from QEMU

2018-08-02 Thread Roger Pau Monné
On Fri, Jul 27, 2018 at 03:06:04PM +0100, Anthony PERARD wrote: > This will handles messages received, and calls callbacks associated with ^ handle I'm not sure I understand what's 'This' in the context. Would be good if you could spell out what 'This' refers to IMO. > the

[Xen-devel] [PATCH v4 22/32] libxl_qmp: Handle messages from QEMU

2018-07-27 Thread Anthony PERARD
This will handles messages received, and calls callbacks associated with the libxl__ev_qmp when the expected response is received. This also print error messages from QMP on behalf of the callback. Signed-off-by: Anthony PERARD --- Notes: v4: Provide an libxl error code to