Re: [Xen-devel] [PATCH v5 01/15] iommu: turn need_iommu back into a boolean.

2018-08-08 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 08 August 2018 14:39 > To: Paul Durrant > Cc: Julien Grall ; Andrew Cooper > ; Wei Liu ; George > Dunlap ; Ian Jackson ; > Stefano Stabellini ; xen-devel de...@lists.xenproject.org>; Konrad Rzeszutek Wilk > ; Tim

Re: [Xen-devel] [PATCH v5 01/15] iommu: turn need_iommu back into a boolean.

2018-08-08 Thread Jan Beulich
>>> On 03.08.18 at 19:22, wrote: > As noted in [1] the tri-state nature of need_iommu after commit 3e06b989 is > confusing. > > Because arch_iommu_populate_page_table() removes pages from the page list > as it maps them it is actually safe to re-invoke multiple times without > the need for any

[Xen-devel] [PATCH v5 01/15] iommu: turn need_iommu back into a boolean.

2018-08-03 Thread Paul Durrant
As noted in [1] the tri-state nature of need_iommu after commit 3e06b989 is confusing. Because arch_iommu_populate_page_table() removes pages from the page list as it maps them it is actually safe to re-invoke multiple times without the need for any specific indication it has been called before,