Re: [Xen-devel] [PATCH v5 08/12] x86/hyperv: provide Hyper-V hypercall functions

2020-01-31 Thread Wei Liu
On Fri, Jan 31, 2020 at 05:18:14PM +0100, Jan Beulich wrote: > On 31.01.2020 17:15, Wei Liu wrote: > > On Fri, Jan 31, 2020 at 04:35:23PM +0100, Jan Beulich wrote: > >> On 31.01.2020 15:37, Wei Liu wrote: > >>> On Fri, Jan 31, 2020 at 03:24:07PM +0100, Jan Beulich wrote: > On 29.01.2020

Re: [Xen-devel] [PATCH v5 08/12] x86/hyperv: provide Hyper-V hypercall functions

2020-01-31 Thread Jan Beulich
On 31.01.2020 17:15, Wei Liu wrote: > On Fri, Jan 31, 2020 at 04:35:23PM +0100, Jan Beulich wrote: >> On 31.01.2020 15:37, Wei Liu wrote: >>> On Fri, Jan 31, 2020 at 03:24:07PM +0100, Jan Beulich wrote: On 29.01.2020 21:20, Wei Liu wrote: > I tried using the asm(".equ ..") trick but hit a

Re: [Xen-devel] [PATCH v5 08/12] x86/hyperv: provide Hyper-V hypercall functions

2020-01-31 Thread Wei Liu
On Fri, Jan 31, 2020 at 04:35:23PM +0100, Jan Beulich wrote: > On 31.01.2020 15:37, Wei Liu wrote: > > On Fri, Jan 31, 2020 at 03:24:07PM +0100, Jan Beulich wrote: > >> On 29.01.2020 21:20, Wei Liu wrote: > >>> I tried using the asm(".equ ..") trick but hit a problem with %c again. > >>> > >>>

Re: [Xen-devel] [PATCH v5 08/12] x86/hyperv: provide Hyper-V hypercall functions

2020-01-31 Thread Jan Beulich
On 31.01.2020 15:37, Wei Liu wrote: > On Fri, Jan 31, 2020 at 03:24:07PM +0100, Jan Beulich wrote: >> On 29.01.2020 21:20, Wei Liu wrote: >>> I tried using the asm(".equ ..") trick but hit a problem with %c again. >>> >>> mm.c:5736:5: error: invalid 'asm': operand is not a condition code, invalid

Re: [Xen-devel] [PATCH v5 08/12] x86/hyperv: provide Hyper-V hypercall functions

2020-01-31 Thread Wei Liu
On Fri, Jan 31, 2020 at 03:24:07PM +0100, Jan Beulich wrote: > On 29.01.2020 21:20, Wei Liu wrote: > > I tried using the asm(".equ ..") trick but hit a problem with %c again. > > > > mm.c:5736:5: error: invalid 'asm': operand is not a condition code, invalid > > operand code 'c' > >

Re: [Xen-devel] [PATCH v5 08/12] x86/hyperv: provide Hyper-V hypercall functions

2020-01-31 Thread Jan Beulich
On 31.01.2020 15:20, Wei Liu wrote: > On Fri, Jan 31, 2020 at 03:12:50PM +0100, Jan Beulich wrote: >> On 30.01.2020 13:28, Wei Liu wrote: >>> On Thu, Jan 30, 2020 at 01:08:07PM +0100, Roger Pau Monné wrote: > +} > + > /* > * Local variables: > * mode: C > diff

Re: [Xen-devel] [PATCH v5 08/12] x86/hyperv: provide Hyper-V hypercall functions

2020-01-31 Thread Jan Beulich
On 29.01.2020 21:20, Wei Liu wrote: > I tried using the asm(".equ ..") trick but hit a problem with %c again. > > mm.c:5736:5: error: invalid 'asm': operand is not a condition code, invalid > operand code 'c' >asm ( ".equ HV_HCALL_PAGE, %c0; .global HV_HCALL_PAGE" Would you mind

Re: [Xen-devel] [PATCH v5 08/12] x86/hyperv: provide Hyper-V hypercall functions

2020-01-31 Thread Wei Liu
On Fri, Jan 31, 2020 at 03:12:50PM +0100, Jan Beulich wrote: > On 30.01.2020 13:28, Wei Liu wrote: > > On Thu, Jan 30, 2020 at 01:08:07PM +0100, Roger Pau Monné wrote: > >> > >>> +} > >>> + > >>> /* > >>> * Local variables: > >>> * mode: C > >>> diff --git a/xen/arch/x86/xen.lds.S

Re: [Xen-devel] [PATCH v5 08/12] x86/hyperv: provide Hyper-V hypercall functions

2020-01-31 Thread Jan Beulich
On 30.01.2020 13:28, Wei Liu wrote: > On Thu, Jan 30, 2020 at 01:08:07PM +0100, Roger Pau Monné wrote: >> >>> +} >>> + >>> /* >>> * Local variables: >>> * mode: C >>> diff --git a/xen/arch/x86/xen.lds.S b/xen/arch/x86/xen.lds.S >>> index 97f9c07891..8e02b4c648 100644 >>> ---

Re: [Xen-devel] [PATCH v5 08/12] x86/hyperv: provide Hyper-V hypercall functions

2020-01-30 Thread Wei Liu
On Thu, Jan 30, 2020 at 04:25:44PM +0100, Roger Pau Monné wrote: > On Thu, Jan 30, 2020 at 03:03:03PM +, Wei Liu wrote: > > On Thu, Jan 30, 2020 at 03:47:04PM +0100, Roger Pau Monné wrote: > > > On Thu, Jan 30, 2020 at 02:25:26PM +, Wei Liu wrote: > > > > On Thu, Jan 30, 2020 at 03:22:01PM

Re: [Xen-devel] [PATCH v5 08/12] x86/hyperv: provide Hyper-V hypercall functions

2020-01-30 Thread Roger Pau Monné
On Thu, Jan 30, 2020 at 03:03:03PM +, Wei Liu wrote: > On Thu, Jan 30, 2020 at 03:47:04PM +0100, Roger Pau Monné wrote: > > On Thu, Jan 30, 2020 at 02:25:26PM +, Wei Liu wrote: > > > On Thu, Jan 30, 2020 at 03:22:01PM +0100, Roger Pau Monné wrote: > > > > On Thu, Jan 30, 2020 at 12:39:20PM

Re: [Xen-devel] [PATCH v5 08/12] x86/hyperv: provide Hyper-V hypercall functions

2020-01-30 Thread Wei Liu
On Thu, Jan 30, 2020 at 03:47:04PM +0100, Roger Pau Monné wrote: > On Thu, Jan 30, 2020 at 02:25:26PM +, Wei Liu wrote: > > On Thu, Jan 30, 2020 at 03:22:01PM +0100, Roger Pau Monné wrote: > > > On Thu, Jan 30, 2020 at 12:39:20PM +, Wei Liu wrote: > > > > On Thu, Jan 30, 2020 at 01:32:26PM

Re: [Xen-devel] [PATCH v5 08/12] x86/hyperv: provide Hyper-V hypercall functions

2020-01-30 Thread Roger Pau Monné
On Thu, Jan 30, 2020 at 02:25:26PM +, Wei Liu wrote: > On Thu, Jan 30, 2020 at 03:22:01PM +0100, Roger Pau Monné wrote: > > On Thu, Jan 30, 2020 at 12:39:20PM +, Wei Liu wrote: > > > On Thu, Jan 30, 2020 at 01:32:26PM +0100, Roger Pau Monné wrote: > > > > On Thu, Jan 30, 2020 at 12:28:36PM

Re: [Xen-devel] [PATCH v5 08/12] x86/hyperv: provide Hyper-V hypercall functions

2020-01-30 Thread Wei Liu
On Thu, Jan 30, 2020 at 03:22:01PM +0100, Roger Pau Monné wrote: > On Thu, Jan 30, 2020 at 12:39:20PM +, Wei Liu wrote: > > On Thu, Jan 30, 2020 at 01:32:26PM +0100, Roger Pau Monné wrote: > > > On Thu, Jan 30, 2020 at 12:28:36PM +, Wei Liu wrote: > > > > On Thu, Jan 30, 2020 at 01:08:07PM

Re: [Xen-devel] [PATCH v5 08/12] x86/hyperv: provide Hyper-V hypercall functions

2020-01-30 Thread Roger Pau Monné
On Thu, Jan 30, 2020 at 12:39:20PM +, Wei Liu wrote: > On Thu, Jan 30, 2020 at 01:32:26PM +0100, Roger Pau Monné wrote: > > On Thu, Jan 30, 2020 at 12:28:36PM +, Wei Liu wrote: > > > On Thu, Jan 30, 2020 at 01:08:07PM +0100, Roger Pau Monné wrote: > > > > > > > > > +} > > > > > + > > > >

Re: [Xen-devel] [PATCH v5 08/12] x86/hyperv: provide Hyper-V hypercall functions

2020-01-30 Thread Wei Liu
On Thu, Jan 30, 2020 at 01:32:26PM +0100, Roger Pau Monné wrote: > On Thu, Jan 30, 2020 at 12:28:36PM +, Wei Liu wrote: > > On Thu, Jan 30, 2020 at 01:08:07PM +0100, Roger Pau Monné wrote: > > > > > > > +} > > > > + > > > > /* > > > > * Local variables: > > > > * mode: C > > > > diff

Re: [Xen-devel] [PATCH v5 08/12] x86/hyperv: provide Hyper-V hypercall functions

2020-01-30 Thread Roger Pau Monné
On Thu, Jan 30, 2020 at 12:28:36PM +, Wei Liu wrote: > On Thu, Jan 30, 2020 at 01:08:07PM +0100, Roger Pau Monné wrote: > > > > > +} > > > + > > > /* > > > * Local variables: > > > * mode: C > > > diff --git a/xen/arch/x86/xen.lds.S b/xen/arch/x86/xen.lds.S > > > index

Re: [Xen-devel] [PATCH v5 08/12] x86/hyperv: provide Hyper-V hypercall functions

2020-01-30 Thread Wei Liu
On Thu, Jan 30, 2020 at 01:08:07PM +0100, Roger Pau Monné wrote: > > > +} > > + > > /* > > * Local variables: > > * mode: C > > diff --git a/xen/arch/x86/xen.lds.S b/xen/arch/x86/xen.lds.S > > index 97f9c07891..8e02b4c648 100644 > > --- a/xen/arch/x86/xen.lds.S > > +++

Re: [Xen-devel] [PATCH v5 08/12] x86/hyperv: provide Hyper-V hypercall functions

2020-01-30 Thread Roger Pau Monné
On Wed, Jan 29, 2020 at 08:20:30PM +, Wei Liu wrote: > These functions will be used later to make hypercalls to Hyper-V. > > Signed-off-by: Wei Liu > --- > v5: > 1. Switch back to direct call > 2. Fix some issues pointed out by Jan > > I tried using the asm(".equ ..") trick but hit a

Re: [Xen-devel] [PATCH v5 08/12] x86/hyperv: provide Hyper-V hypercall functions

2020-01-30 Thread Durrant, Paul
on ; Michael > Kelley ; Julien Grall ; Roger Pau > Monné > Subject: [Xen-devel] [PATCH v5 08/12] x86/hyperv: provide Hyper-V > hypercall functions > > These functions will be used later to make hypercalls to Hyper-V. > > Signed-off-by: Wei Liu Reviewed-by: Paul Durrant

[Xen-devel] [PATCH v5 08/12] x86/hyperv: provide Hyper-V hypercall functions

2020-01-29 Thread Wei Liu
These functions will be used later to make hypercalls to Hyper-V. Signed-off-by: Wei Liu --- v5: 1. Switch back to direct call 2. Fix some issues pointed out by Jan I tried using the asm(".equ ..") trick but hit a problem with %c again. mm.c:5736:5: error: invalid 'asm': operand is not a