> -Original Message-
> From: Jan Beulich
> Sent: 29 January 2020 15:08
> To: Durrant, Paul
> Cc: xen-devel@lists.xenproject.org; Andrew Cooper
> ; George Dunlap ;
> Ian Jackson ; Julien Grall ;
> Konrad Rzeszutek Wilk ; Stefano Stabellini
> ; Wei Liu
> Subject: Re: [PATCH v6 2/4] mm: mod
On 29.01.2020 15:38, Paul Durrant wrote:
> --- a/xen/common/memory.c
> +++ b/xen/common/memory.c
> @@ -727,8 +727,7 @@ static long
> memory_exchange(XEN_GUEST_HANDLE_PARAM(xen_memory_exchange_t) arg)
> (j * (1UL << exch.out.extent_order)));
>
> spin
Currently the function will pointlessly acquire and release the global
'heap_lock' in this case.
NOTE: No caller yet calls domain_adjust_tot_pages() with a zero 'pages'
argument, but a subsequent patch will make this possible.
Signed-off-by: Paul Durrant
---
Cc: Andrew Cooper
Cc: George D
