Re: [Xen-devel] [PATCH v9 04/15] microcode: introduce a global cache of ucode patch

2019-08-29 Thread Jan Beulich
On 19.08.2019 03:25, Chao Gao wrote: > +static enum microcode_match_result compare_patch( > +const struct microcode_patch *new, const struct microcode_patch *old) > +{ > +return (new->mc_intel->hdr.rev > old->mc_intel->hdr.rev) ? NEW_UCODE : > +

Re: [Xen-devel] [PATCH v9 04/15] microcode: introduce a global cache of ucode patch

2019-08-28 Thread Jan Beulich
On 19.08.2019 03:25, Chao Gao wrote: > +/* Return true if cache gets updated. Otherwise, return false */ > +bool microcode_update_cache(struct microcode_patch *patch) > +{ > + > +ASSERT(spin_is_locked(_mutex)); Stray blank line ahead of this one. > --- a/xen/arch/x86/microcode_intel.c > +++

Re: [Xen-devel] [PATCH v9 04/15] microcode: introduce a global cache of ucode patch

2019-08-22 Thread Roger Pau Monné
On Mon, Aug 19, 2019 at 09:25:17AM +0800, Chao Gao wrote: > to replace the current per-cpu cache 'uci->mc'. > > With the assumption that all CPUs in the system have the same signature > (family, model, stepping and 'pf'), one microcode update matches with > one cpu should match with others.

[Xen-devel] [PATCH v9 04/15] microcode: introduce a global cache of ucode patch

2019-08-18 Thread Chao Gao
to replace the current per-cpu cache 'uci->mc'. With the assumption that all CPUs in the system have the same signature (family, model, stepping and 'pf'), one microcode update matches with one cpu should match with others. Having multiple microcode revisions on different cpus would cause system