Re: [Xen-devel] [Qemu-devel] [PATCH] configure: Don't add Xen's libs to LDFLAGS

2019-02-04 Thread Eric Blake
On 1/24/19 12:29 PM, Peter Maydell wrote: > On Thu, 24 Jan 2019 at 17:40, Eric Blake wrote: >> >> On 1/24/19 2:45 AM, Markus Armbruster wrote: >> Signed-off-by: Michael Tokarev Revieved-by: Michael Tokarev >>> >>> Typo in Reviewed-by. >> >> Should we tighten checkpatch.pl to flag

Re: [Xen-devel] [Qemu-devel] [PATCH] configure: Don't add Xen's libs to LDFLAGS

2019-01-24 Thread Peter Maydell
On Thu, 24 Jan 2019 at 17:40, Eric Blake wrote: > > On 1/24/19 2:45 AM, Markus Armbruster wrote: > > >> Signed-off-by: Michael Tokarev > >> Revieved-by: Michael Tokarev > > > > Typo in Reviewed-by. > > Should we tighten checkpatch.pl to flag suspicious-looking 'xxx-by:' > tags, to catch

Re: [Xen-devel] [Qemu-devel] [PATCH] configure: Don't add Xen's libs to LDFLAGS

2019-01-24 Thread Eric Blake
On 1/24/19 2:45 AM, Markus Armbruster wrote: >> Signed-off-by: Michael Tokarev >> Revieved-by: Michael Tokarev > > Typo in Reviewed-by. Should we tighten checkpatch.pl to flag suspicious-looking 'xxx-by:' tags, to catch instances of typos? -- Eric Blake, Principal Software Engineer Red Hat,

Re: [Xen-devel] [Qemu-devel] [PATCH] configure: Don't add Xen's libs to LDFLAGS

2019-01-24 Thread Markus Armbruster
Michael Tokarev writes: > 21.01.2019 18:17, Peter Maydell wrote: >> On Mon, 21 Jan 2019 at 14:49, Anthony PERARD >> wrote: >>> >>> When Xen is detected via pkg-config, it isn't necessary to modify >>> LDFLAGS as modifying libs_softmmu is enough. >>> >>> Reported-by: Peter Maydell >>>

Re: [Xen-devel] [Qemu-devel] [PATCH] configure: Don't add Xen's libs to LDFLAGS

2019-01-21 Thread Philippe Mathieu-Daudé
On 1/21/19 3:48 PM, Anthony PERARD wrote: > When Xen is detected via pkg-config, it isn't necessary to modify > LDFLAGS as modifying libs_softmmu is enough. > > Reported-by: Peter Maydell > Signed-off-by: Anthony PERARD > --- > configure | 1 - > 1 file changed, 1 deletion(-) > > diff --git