Re: [Xen-devel] [RFC] xen: Don't use memory_region_init_ram_nomigrate() in pci_assign_dev_load_option_rom()

2018-06-15 Thread Stefano Stabellini
On Fri, 15 Jun 2018, Anthony PERARD wrote: > On Fri, Jun 15, 2018 at 11:06:47AM +0100, Peter Maydell wrote: > > On 5 June 2018 at 17:55, Anthony PERARD wrote: > > > On Fri, Jun 01, 2018 at 06:59:10PM +0100, Peter Maydell wrote: > > >> The xen pci_assign_dev_load_option_rom() currently creates a

Re: [Xen-devel] [RFC] xen: Don't use memory_region_init_ram_nomigrate() in pci_assign_dev_load_option_rom()

2018-06-15 Thread Anthony PERARD
On Fri, Jun 15, 2018 at 11:06:47AM +0100, Peter Maydell wrote: > On 5 June 2018 at 17:55, Anthony PERARD wrote: > > On Fri, Jun 01, 2018 at 06:59:10PM +0100, Peter Maydell wrote: > >> The xen pci_assign_dev_load_option_rom() currently creates a RAM > >> memory region with

Re: [Xen-devel] [RFC] xen: Don't use memory_region_init_ram_nomigrate() in pci_assign_dev_load_option_rom()

2018-06-15 Thread Peter Maydell
On 5 June 2018 at 17:55, Anthony PERARD wrote: > On Fri, Jun 01, 2018 at 06:59:10PM +0100, Peter Maydell wrote: >> The xen pci_assign_dev_load_option_rom() currently creates a RAM >> memory region with memory_region_init_ram_nomigrate(), and then >> manually registers it with

Re: [Xen-devel] [RFC] xen: Don't use memory_region_init_ram_nomigrate() in pci_assign_dev_load_option_rom()

2018-06-05 Thread Anthony PERARD
On Fri, Jun 01, 2018 at 06:59:10PM +0100, Peter Maydell wrote: > The xen pci_assign_dev_load_option_rom() currently creates a RAM > memory region with memory_region_init_ram_nomigrate(), and then > manually registers it with vmstate_register_ram(). In fact for > its only callsite, the 'owner'

[Xen-devel] [RFC] xen: Don't use memory_region_init_ram_nomigrate() in pci_assign_dev_load_option_rom()

2018-06-01 Thread Peter Maydell
The xen pci_assign_dev_load_option_rom() currently creates a RAM memory region with memory_region_init_ram_nomigrate(), and then manually registers it with vmstate_register_ram(). In fact for its only callsite, the 'owner' pointer we use for the init call and the '>qdev' pointer we use for the