Re: [Xen-devel] [RFC 4/7] arm/gic: Drop pointless assertions

2019-11-20 Thread Stefano Stabellini
On Wed, 13 Nov 2019, Julien Grall wrote: > On Tue, 12 Nov 2019, 05:52 Stefano Stabellini, wrote: > On Wed, 6 Nov 2019, Andrii Anisov wrote: > > From: Andrii Anisov > > > > Also armclang complains about the condition always true, > > because `sgi` is of type enum

Re: [Xen-devel] [RFC 4/7] arm/gic: Drop pointless assertions

2019-11-12 Thread Julien Grall
On Tue, 12 Nov 2019, 05:52 Stefano Stabellini, wrote: > On Wed, 6 Nov 2019, Andrii Anisov wrote: > > From: Andrii Anisov > > > > Also armclang complains about the condition always true, > > because `sgi` is of type enum with all its values under 16. > > > > Signed-off-by: Andrii Anisov > >

Re: [Xen-devel] [RFC 4/7] arm/gic: Drop pointless assertions

2019-11-11 Thread Stefano Stabellini
On Wed, 6 Nov 2019, Andrii Anisov wrote: > From: Andrii Anisov > > Also armclang complains about the condition always true, > because `sgi` is of type enum with all its values under 16. > > Signed-off-by: Andrii Anisov Although I am not completely opposed to this, given the choice I would

[Xen-devel] [RFC 4/7] arm/gic: Drop pointless assertions

2019-11-06 Thread Andrii Anisov
From: Andrii Anisov Also armclang complains about the condition always true, because `sgi` is of type enum with all its values under 16. Signed-off-by: Andrii Anisov --- xen/arch/arm/gic.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/xen/arch/arm/gic.c b/xen/arch/arm/gic.c index