Re: [Xen-devel] [RFC PATCH 13/30] pc/xen: Xen Q35 support: provide IRQ handling for PCI devices

2018-03-14 Thread Alexey G
On Wed, 14 Mar 2018 11:48:46 +0100 Paolo Bonzini wrote: >On 12/03/2018 19:33, Alexey Gerasimenko wrote: >> xen_pci_slot_get_pirq --> xen_cmn_pci_slot_get_pirq >> xen_piix3_set_irq --> xen_cmn_set_irq > >Don't abbrvt names, xen_hvm_ is a better prefix. Agree, will

Re: [Xen-devel] [RFC PATCH 13/30] pc/xen: Xen Q35 support: provide IRQ handling for PCI devices

2018-03-14 Thread Paolo Bonzini
On 12/03/2018 19:33, Alexey Gerasimenko wrote: > xen_pci_slot_get_pirq --> xen_cmn_pci_slot_get_pirq > xen_piix3_set_irq --> xen_cmn_set_irq Don't abbrvt names, xen_hvm_ is a better prefix. > > +fprintf(stderr, "WARNING: guest domain attempted to use > PIRQ%c " > +

[Xen-devel] [RFC PATCH 13/30] pc/xen: Xen Q35 support: provide IRQ handling for PCI devices

2018-03-12 Thread Alexey Gerasimenko
The primary difference in PCI device IRQ management between Xen HVM and QEMU is that Xen PCI IRQs are "device-centric" while QEMU PCI IRQs are "chipset-centric". Namely, Xen uses PCI device BDF and INTx as coordinates to assert IRQ while QEMU finds out to which chipset PIRQ the IRQ is routed