Re: [Xen-devel] Guest soft lockups with "xen: make xen_qlock_wait() nestable"

2018-11-19 Thread Juergen Gross
On 19/11/2018 10:39, David Woodhouse wrote: > On Mon, 2018-11-19 at 08:05 +0100, Juergen Gross wrote: >> On 15/11/2018 00:22, David Woodhouse wrote: >>> On Thu, 2018-11-08 at 11:18 +0100, Juergen Gross wrote: Oh, sorry. Of course it does. Dereferencing a percpu variable directly can't

Re: [Xen-devel] Guest soft lockups with "xen: make xen_qlock_wait() nestable"

2018-11-19 Thread David Woodhouse
On Mon, 2018-11-19 at 08:05 +0100, Juergen Gross wrote: > On 15/11/2018 00:22, David Woodhouse wrote: > > On Thu, 2018-11-08 at 11:18 +0100, Juergen Gross wrote: > > > Oh, sorry. Of course it does. Dereferencing a percpu variable > > > directly can't work. How silly of me. > > > > > > The

Re: [Xen-devel] Guest soft lockups with "xen: make xen_qlock_wait() nestable"

2018-11-18 Thread Juergen Gross
On 15/11/2018 00:22, David Woodhouse wrote: > On Thu, 2018-11-08 at 11:18 +0100, Juergen Gross wrote: >> Oh, sorry. Of course it does. Dereferencing a percpu variable >> directly can't work. How silly of me. >> >> The attached variant should repair that. Tested to not break booting. > > Strictly

Re: [Xen-devel] Guest soft lockups with "xen: make xen_qlock_wait() nestable"

2018-11-14 Thread David Woodhouse
On Thu, 2018-11-08 at 11:18 +0100, Juergen Gross wrote: > Oh, sorry. Of course it does. Dereferencing a percpu variable > directly can't work. How silly of me. > > The attached variant should repair that. Tested to not break booting. Strictly speaking, shouldn't you have an atomic_init() in

Re: [Xen-devel] Guest soft lockups with "xen: make xen_qlock_wait() nestable"

2018-11-08 Thread Sander Eikelenboom
On 08/11/18 11:18, Juergen Gross wrote: > On 08/11/2018 10:57, Sander Eikelenboom wrote: >> On 08/11/18 09:18, Juergen Gross wrote: >>> On 08/11/2018 09:14, Sander Eikelenboom wrote: On 08/11/18 08:08, Juergen Gross wrote: > On 07/11/2018 10:30, Sander Eikelenboom wrote: >> Hi Juergen

Re: [Xen-devel] Guest soft lockups with "xen: make xen_qlock_wait() nestable"

2018-11-08 Thread Juergen Gross
On 08/11/2018 10:57, Sander Eikelenboom wrote: > On 08/11/18 09:18, Juergen Gross wrote: >> On 08/11/2018 09:14, Sander Eikelenboom wrote: >>> On 08/11/18 08:08, Juergen Gross wrote: On 07/11/2018 10:30, Sander Eikelenboom wrote: > Hi Juergen / Boris, > > Last week i tested Linux

Re: [Xen-devel] Guest soft lockups with "xen: make xen_qlock_wait() nestable"

2018-11-08 Thread Sander Eikelenboom
On 08/11/18 09:18, Juergen Gross wrote: > On 08/11/2018 09:14, Sander Eikelenboom wrote: >> On 08/11/18 08:08, Juergen Gross wrote: >>> On 07/11/2018 10:30, Sander Eikelenboom wrote: Hi Juergen / Boris, Last week i tested Linux kernel 4.19.0 stable with the Xen

Re: [Xen-devel] Guest soft lockups with "xen: make xen_qlock_wait() nestable"

2018-11-08 Thread Juergen Gross
On 08/11/2018 09:14, Sander Eikelenboom wrote: > On 08/11/18 08:08, Juergen Gross wrote: >> On 07/11/2018 10:30, Sander Eikelenboom wrote: >>> Hi Juergen / Boris, >>> >>> Last week i tested Linux kernel 4.19.0 stable with the Xen "for-linus-4.20" >>> branch pulled on top. >>> Unfortunately i was

Re: [Xen-devel] Guest soft lockups with "xen: make xen_qlock_wait() nestable"

2018-11-08 Thread Sander Eikelenboom
On 08/11/18 08:08, Juergen Gross wrote: > On 07/11/2018 10:30, Sander Eikelenboom wrote: >> Hi Juergen / Boris, >> >> Last week i tested Linux kernel 4.19.0 stable with the Xen "for-linus-4.20" >> branch pulled on top. >> Unfortunately i was seeing guests lockup after some time, see below for the

Re: [Xen-devel] Guest soft lockups with "xen: make xen_qlock_wait() nestable"

2018-11-07 Thread Juergen Gross
On 07/11/2018 10:30, Sander Eikelenboom wrote: > Hi Juergen / Boris, > > Last week i tested Linux kernel 4.19.0 stable with the Xen "for-linus-4.20" > branch pulled on top. > Unfortunately i was seeing guests lockup after some time, see below for the > logging from one of the guest > which i

Re: [Xen-devel] Guest soft lockups with "xen: make xen_qlock_wait() nestable"

2018-11-07 Thread Boris Ostrovsky
On 11/7/18 5:45 PM, Sander Eikelenboom wrote: > On 07/11/18 23:34, Boris Ostrovsky wrote: >> On 11/7/18 4:30 AM, Sander Eikelenboom wrote: >>> Hi Juergen / Boris, >>> >>> Last week i tested Linux kernel 4.19.0 stable with the Xen "for-linus-4.20" >>> branch pulled on top. >>> Unfortunately i was

Re: [Xen-devel] Guest soft lockups with "xen: make xen_qlock_wait() nestable"

2018-11-07 Thread Sander Eikelenboom
On 07/11/18 23:34, Boris Ostrovsky wrote: > On 11/7/18 4:30 AM, Sander Eikelenboom wrote: >> Hi Juergen / Boris, >> >> Last week i tested Linux kernel 4.19.0 stable with the Xen "for-linus-4.20" >> branch pulled on top. >> Unfortunately i was seeing guests lockup after some time, see below for

Re: [Xen-devel] Guest soft lockups with "xen: make xen_qlock_wait() nestable"

2018-11-07 Thread Boris Ostrovsky
On 11/7/18 4:30 AM, Sander Eikelenboom wrote: > Hi Juergen / Boris, > > Last week i tested Linux kernel 4.19.0 stable with the Xen "for-linus-4.20" > branch pulled on top. > Unfortunately i was seeing guests lockup after some time, see below for the > logging from one of the guest > which i was

[Xen-devel] Guest soft lockups with "xen: make xen_qlock_wait() nestable"

2018-11-07 Thread Sander Eikelenboom
Hi Juergen / Boris, Last week i tested Linux kernel 4.19.0 stable with the Xen "for-linus-4.20" branch pulled on top. Unfortunately i was seeing guests lockup after some time, see below for the logging from one of the guest which i was able to capture. Reverting "xen: make xen_qlock_wait()