Re: [Xen-devel] Weird altp2m behaviour when switching early to a new view

2018-10-04 Thread Razvan Cojocaru
On 10/3/18 1:56 PM, Сергей wrote: >> No yet, we're working on it. > Could You point me to the branch with Your patches please? I Could not find > it in https://xenbits.xen.org/gitweb/?p=xen.git I've attached the current version of the patch, which needs George's comments addressed (so we already

Re: [Xen-devel] Weird altp2m behaviour when switching early to a new view

2018-10-03 Thread Razvan Cojocaru
On 10/3/18 1:56 PM, Сергей wrote: >> No yet, we're working on it. > Could You point me to the branch with Your patches please? I Could not find > it in https://xenbits.xen.org/gitweb/?p=xen.git There's no public branch with my patches, I'm working locally. The original patch has now split into

Re: [Xen-devel] Weird altp2m behaviour when switching early to a new view

2018-10-03 Thread Сергей
> No yet, we're working on it. Could You point me to the branch with Your patches please? I Could not find it in https://xenbits.xen.org/gitweb/?p=xen.git With best regards Sergey Kovalev. ___ Xen-devel mailing list Xen-devel@lists.xenproject.org

[Xen-devel] Weird altp2m behaviour when switching early to a new view

2018-10-02 Thread Razvan Cojocaru
On 10/2/18 7:29 PM, Сергей wrote: > Hello Razvan. > > Have Your patch been accepted in Xen hypervisor? > > Searching through git I have found commit > "61bdddb82151fbf51c58f6ebc1b4a687942c45a8" on "Thu Jun 28 10:54:01 2018 > +0300". Is that commit deals with the error? No yet, we're working

Re: [Xen-devel] Weird altp2m behaviour when switching early to a new view

2018-10-02 Thread Сергей
Hello Razvan. Have Your patch been accepted in Xen hypervisor? Searching through git I have found commit "61bdddb82151fbf51c58f6ebc1b4a687942c45a8" on "Thu Jun 28 10:54:01 2018 +0300". Is that commit deals with the error? With best regards Sergey Kovalev.

Re: [Xen-devel] Weird altp2m behaviour when switching early to a new view

2018-04-18 Thread Razvan Cojocaru
On 04/18/2018 01:45 PM, George Dunlap wrote: > On 04/18/2018 09:20 AM, Razvan Cojocaru wrote: >> On 04/17/2018 04:53 PM, George Dunlap wrote: >>> On 04/17/2018 11:50 AM, Razvan Cojocaru wrote: void p2m_init_altp2m_ept(struct domain *d, unsigned int i) { struct p2m_domain *p2m

Re: [Xen-devel] Weird altp2m behaviour when switching early to a new view

2018-04-18 Thread George Dunlap
On 04/18/2018 09:20 AM, Razvan Cojocaru wrote: > On 04/17/2018 04:53 PM, George Dunlap wrote: >> On 04/17/2018 11:50 AM, Razvan Cojocaru wrote: >>> void p2m_init_altp2m_ept(struct domain *d, unsigned int i) >>> { >>> struct p2m_domain *p2m = d->arch.altp2m_p2m[i]; >>> +struct p2m_domain

Re: [Xen-devel] Weird altp2m behaviour when switching early to a new view

2018-04-18 Thread Razvan Cojocaru
On 04/17/2018 04:53 PM, George Dunlap wrote: > On 04/17/2018 11:50 AM, Razvan Cojocaru wrote: >> void p2m_init_altp2m_ept(struct domain *d, unsigned int i) >> { >> struct p2m_domain *p2m = d->arch.altp2m_p2m[i]; >> +struct p2m_domain *hostp2m = p2m_get_hostp2m(d); >> struct

Re: [Xen-devel] Weird altp2m behaviour when switching early to a new view

2018-04-17 Thread Tamas K Lengyel
On Tue, Apr 17, 2018 at 9:13 AM, Razvan Cojocaru wrote: > On 04/17/2018 05:58 PM, George Dunlap wrote: It might be nice to have a more structured way of keeping all these changes in sync, rather than relying on this open-coding everywhere. >>> >>> Very true.

Re: [Xen-devel] Weird altp2m behaviour when switching early to a new view

2018-04-17 Thread Razvan Cojocaru
On 04/17/2018 05:58 PM, George Dunlap wrote: >>> It might be nice to have a more structured way of keeping all these >>> changes in sync, rather than relying on this open-coding everywhere. >> >> Very true. It has also occured to me that some of these issues would be >> at least partially

Re: [Xen-devel] Weird altp2m behaviour when switching early to a new view

2018-04-17 Thread George Dunlap
On 04/17/2018 03:21 PM, Razvan Cojocaru wrote: > On 04/17/2018 04:53 PM, George Dunlap wrote: >> On 04/17/2018 11:50 AM, Razvan Cojocaru wrote: >>> void p2m_init_altp2m_ept(struct domain *d, unsigned int i) >>> { >>> struct p2m_domain *p2m = d->arch.altp2m_p2m[i]; >>> +struct p2m_domain

Re: [Xen-devel] Weird altp2m behaviour when switching early to a new view

2018-04-17 Thread Razvan Cojocaru
On 04/17/2018 04:53 PM, George Dunlap wrote: > On 04/17/2018 11:50 AM, Razvan Cojocaru wrote: >> void p2m_init_altp2m_ept(struct domain *d, unsigned int i) >> { >> struct p2m_domain *p2m = d->arch.altp2m_p2m[i]; >> +struct p2m_domain *hostp2m = p2m_get_hostp2m(d); >> struct

Re: [Xen-devel] Weird altp2m behaviour when switching early to a new view

2018-04-17 Thread George Dunlap
On 04/17/2018 11:50 AM, Razvan Cojocaru wrote: > void p2m_init_altp2m_ept(struct domain *d, unsigned int i) > { > struct p2m_domain *p2m = d->arch.altp2m_p2m[i]; > +struct p2m_domain *hostp2m = p2m_get_hostp2m(d); > struct ept_data *ept; > > +p2m->max_mapped_pfn =

Re: [Xen-devel] Weird altp2m behaviour when switching early to a new view

2018-04-17 Thread Razvan Cojocaru
On 04/17/2018 01:49 PM, Razvan Cojocaru wrote: > On 04/17/2018 11:24 AM, Razvan Cojocaru wrote: >> On 04/16/2018 11:21 PM, George Dunlap wrote: >>> On Mon, Apr 16, 2018 at 7:46 PM, Razvan Cojocaru >>> wrote: On 04/16/2018 08:47 PM, George Dunlap wrote: > On

Re: [Xen-devel] Weird altp2m behaviour when switching early to a new view

2018-04-17 Thread Razvan Cojocaru
On 04/17/2018 11:24 AM, Razvan Cojocaru wrote: > On 04/16/2018 11:21 PM, George Dunlap wrote: >> On Mon, Apr 16, 2018 at 7:46 PM, Razvan Cojocaru >> wrote: >>> On 04/16/2018 08:47 PM, George Dunlap wrote: On 04/13/2018 03:44 PM, Razvan Cojocaru wrote: > On

Re: [Xen-devel] Weird altp2m behaviour when switching early to a new view

2018-04-17 Thread Razvan Cojocaru
On 04/16/2018 11:21 PM, George Dunlap wrote: > On Mon, Apr 16, 2018 at 7:46 PM, Razvan Cojocaru > wrote: >> On 04/16/2018 08:47 PM, George Dunlap wrote: >>> On 04/13/2018 03:44 PM, Razvan Cojocaru wrote: On 04/11/2018 11:04 AM, Razvan Cojocaru wrote: >

Re: [Xen-devel] Weird altp2m behaviour when switching early to a new view

2018-04-17 Thread Razvan Cojocaru
On 04/16/2018 11:21 PM, George Dunlap wrote: > On Mon, Apr 16, 2018 at 7:46 PM, Razvan Cojocaru > wrote: >> On 04/16/2018 08:47 PM, George Dunlap wrote: >>> On 04/13/2018 03:44 PM, Razvan Cojocaru wrote: On 04/11/2018 11:04 AM, Razvan Cojocaru wrote: >

Re: [Xen-devel] Weird altp2m behaviour when switching early to a new view

2018-04-16 Thread George Dunlap
On Mon, Apr 16, 2018 at 7:46 PM, Razvan Cojocaru wrote: > On 04/16/2018 08:47 PM, George Dunlap wrote: >> On 04/13/2018 03:44 PM, Razvan Cojocaru wrote: >>> On 04/11/2018 11:04 AM, Razvan Cojocaru wrote: Debugging continues. >>> >>> Finally, the attached patch

Re: [Xen-devel] Weird altp2m behaviour when switching early to a new view

2018-04-16 Thread Razvan Cojocaru
On 04/16/2018 08:47 PM, George Dunlap wrote: > On 04/13/2018 03:44 PM, Razvan Cojocaru wrote: >> On 04/11/2018 11:04 AM, Razvan Cojocaru wrote: >>> Debugging continues. >> >> Finally, the attached patch seems to get the display unstuck in my >> scenario, although for one guest I get: >> >> (XEN)

Re: [Xen-devel] Weird altp2m behaviour when switching early to a new view

2018-04-13 Thread Razvan Cojocaru
On 04/13/2018 07:38 PM, Tamas K Lengyel wrote: > On Fri, Apr 13, 2018 at 8:44 AM, Razvan Cojocaru > wrote: >> On 04/11/2018 11:04 AM, Razvan Cojocaru wrote: >>> Debugging continues. >> >> Finally, the attached patch seems to get the display unstuck in my >> scenario,

Re: [Xen-devel] Weird altp2m behaviour when switching early to a new view

2018-04-13 Thread Tamas K Lengyel
On Fri, Apr 13, 2018 at 8:44 AM, Razvan Cojocaru wrote: > On 04/11/2018 11:04 AM, Razvan Cojocaru wrote: >> Debugging continues. > > Finally, the attached patch seems to get the display unstuck in my > scenario, although for one guest I get: > > (XEN) d2v0 Unexpected

Re: [Xen-devel] Weird altp2m behaviour when switching early to a new view

2018-04-13 Thread Razvan Cojocaru
On 04/11/2018 11:04 AM, Razvan Cojocaru wrote: > Debugging continues. Finally, the attached patch seems to get the display unstuck in my scenario, although for one guest I get: (XEN) d2v0 Unexpected vmexit: reason 49 (XEN) domain_crash called from vmx.c:4120 (XEN) Domain 2 (vcpu#0) crashed on

Re: [Xen-devel] Weird altp2m behaviour when switching early to a new view

2018-04-12 Thread Razvan Cojocaru
On 04/11/2018 11:04 AM, Razvan Cojocaru wrote: >> After much debugging, it turns out that the >> "p2m_is_ram(p2mt)" test in hvm_hap_nested_page_fault() fails if I switch >> to the new altp2m view fast enough, and that in turn disables the >> logdirty processing gated on it > > Actually as it

Re: [Xen-devel] Weird altp2m behaviour when switching early to a new view

2018-04-12 Thread Razvan Cojocaru
On 04/11/2018 11:17 PM, Tamas K Lengyel wrote: > On Wed, Apr 11, 2018 at 12:39 AM, Razvan Cojocaru > wrote: >> Also related to this part of the altp2m design, I've also noticed that >> creating a new EPT view with libxc involves this function: >> >> int

Re: [Xen-devel] Weird altp2m behaviour when switching early to a new view

2018-04-11 Thread Tamas K Lengyel
On Wed, Apr 11, 2018 at 12:39 AM, Razvan Cojocaru wrote: > On 04/09/2018 05:12 PM, George Dunlap wrote: >> The obvious place to look is the logdirtyvram functionality, which is >> used to make it easier for QEMU to figure out which bits of the display >> buffer have

Re: [Xen-devel] Weird altp2m behaviour when switching early to a new view

2018-04-11 Thread Razvan Cojocaru
> After much debugging, it turns out that the > "p2m_is_ram(p2mt)" test in hvm_hap_nested_page_fault() fails if I switch > to the new altp2m view fast enough, and that in turn disables the > logdirty processing gated on it Actually as it turns out the exit doesn't happen at all anymore so

Re: [Xen-devel] Weird altp2m behaviour when switching early to a new view

2018-04-11 Thread Razvan Cojocaru
On 04/09/2018 05:12 PM, George Dunlap wrote: > The obvious place to look is the logdirtyvram functionality, which is > used to make it easier for QEMU to figure out which bits of the display > buffer have been modified. One of the big reasons the altp2m > functionality is still considered

Re: [Xen-devel] Weird altp2m behaviour when switching early to a new view

2018-04-09 Thread Alexey G
On Sun, 8 Apr 2018 23:38:31 +0300 Razvan Cojocaru wrote: >I've noticed altp2m behaviour I can't explain yet - I'm not all that >familiar with all the ways the new views corellate with the previous >EPT-based "view 0". > >In short, if we create a new view and simply

Re: [Xen-devel] Weird altp2m behaviour when switching early to a new view

2018-04-09 Thread George Dunlap
On 04/08/2018 09:38 PM, Razvan Cojocaru wrote: > Hello, > > I've noticed altp2m behaviour I can't explain yet - I'm not all that > familiar with all the ways the new views corellate with the previous > EPT-based "view 0". > > In short, if we create a new view and simply switch to it early in the

[Xen-devel] Weird altp2m behaviour when switching early to a new view

2018-04-08 Thread Razvan Cojocaru
Hello, I've noticed altp2m behaviour I can't explain yet - I'm not all that familiar with all the ways the new views corellate with the previous EPT-based "view 0". In short, if we create a new view and simply switch to it early in the boot process of the guest, something goes wrong and the