Re: [Xen-devel] possible I/O emulation state machine issue

2018-04-12 Thread Jan Beulich
>>> On 28.03.18 at 18:35, wrote: > Its one of the many items on the TODO list, along with maintaining a > proper virtual TLB to avoid rewalks during a single emulation. Having thought about this some more I agree that for correctness a virtual TLB would be sufficient.

Re: [Xen-devel] possible I/O emulation state machine issue

2018-03-29 Thread Jan Beulich
>>> On 29.03.18 at 10:42, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 29 March 2018 07:27 >> >> Suppressing the stdvga port intercepts has, btw, not helped the >> situation. >> > > That surprises me. The whole string emulation should go out to QEMU

Re: [Xen-devel] possible I/O emulation state machine issue

2018-03-29 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 29 March 2018 07:27 > To: Paul Durrant > Cc: Andrew Cooper ; xen-devel de...@lists.xenproject.org> > Subject: RE: possible I/O emulation state machine issue >

Re: [Xen-devel] possible I/O emulation state machine issue

2018-03-29 Thread Jan Beulich
>>> On 28.03.18 at 18:35, wrote: > On 28/03/18 17:22, Paul Durrant wrote: >>> From: Jan Beulich [mailto:jbeul...@suse.com] >>> Sent: 28 March 2018 16:59 >>> >>> I thought we cache the translation result, thus avoiding the need >>> for a translation during the retry

Re: [Xen-devel] possible I/O emulation state machine issue

2018-03-29 Thread Jan Beulich
>>> On 28.03.18 at 18:22, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 28 March 2018 16:59 >> >> Simply timing, perhaps. In any event, newest logs suggest we have >> an issue with Windows paging out the page the data for the >> REP OUTSW is coming from

Re: [Xen-devel] possible I/O emulation state machine issue

2018-03-28 Thread Andrew Cooper
On 28/03/18 17:22, Paul Durrant wrote: >> -Original Message- >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 28 March 2018 16:59 >> To: Paul Durrant >> Cc: Andrew Cooper ; xen-devel > de...@lists.xenproject.org> >> Subject: RE:

Re: [Xen-devel] possible I/O emulation state machine issue

2018-03-28 Thread Jan Beulich
>>> On 28.03.18 at 15:48, wrote: >> -Original Message- >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 26 March 2018 09:43 >> To: Paul Durrant >> Cc: Andrew Cooper ; xen-devel >

Re: [Xen-devel] possible I/O emulation state machine issue

2018-03-28 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 28 March 2018 15:08 > To: Paul Durrant > Cc: Andrew Cooper ; xen-devel de...@lists.xenproject.org> > Subject: RE: possible I/O emulation state machine issue >

Re: [Xen-devel] possible I/O emulation state machine issue

2018-03-28 Thread Jan Beulich
>>> On 28.03.18 at 15:48, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 26 March 2018 09:43 >> >> After having added I/O emulation state checks at the beginning of >> vmx_vmexit_handler() as well as very early and very late in >> vmx_vmenter_helper(),

Re: [Xen-devel] possible I/O emulation state machine issue

2018-03-28 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 26 March 2018 09:43 > To: Paul Durrant > Cc: Andrew Cooper ; xen-devel de...@lists.xenproject.org> > Subject: Re: possible I/O emulation state machine issue >

Re: [Xen-devel] possible I/O emulation state machine issue

2018-03-26 Thread Jan Beulich
>>> On 23.03.18 at 14:41, wrote: > So somehow it appears the vcpu got back into guest and executed the next > instruction whilst there was pending I/O. Two new pieces of information, in case either rings a bell: The issue appears to never occur in hap=0 mode. After

Re: [Xen-devel] possible I/O emulation state machine issue

2018-03-23 Thread Jan Beulich
>>> On 23.03.18 at 14:41, wrote: > Ah that's true. We will do the check based on the response state even if the > next IO is going to be dealt with internally. So, yes, the real question is > why the previous I/O was completed without apparently waiting for QEMU to >

Re: [Xen-devel] possible I/O emulation state machine issue

2018-03-23 Thread Paul Durrant
.xenproject.org> > Subject: Re: [Xen-devel] possible I/O emulation state machine issue > > >>> On 23.03.18 at 11:43, <paul.durr...@citrix.com> wrote: > >> From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On > Behalf > >> Of Jan Beulich &

Re: [Xen-devel] possible I/O emulation state machine issue

2018-03-23 Thread Jan Beulich
>>> On 23.03.18 at 11:43, wrote: >> From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf >> Of Jan Beulich >> Sent: 23 March 2018 07:30 >> >> >>> On 22.03.18 at 16:29, wrote: >> > On 22/03/18 15:12, Jan Beulich wrote: >>

Re: [Xen-devel] possible I/O emulation state machine issue

2018-03-23 Thread Jan Beulich
>>> On 23.03.18 at 11:43, wrote: >> From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf >> Of Jan Beulich >> Sent: 23 March 2018 07:30 >> >> >>> On 22.03.18 at 16:29, wrote: >> > On 22/03/18 15:12, Jan Beulich wrote: >>

Re: [Xen-devel] possible I/O emulation state machine issue

2018-03-23 Thread Paul Durrant
t;paul.durr...@citrix.com> > Subject: Re: [Xen-devel] possible I/O emulation state machine issue > > >>> On 22.03.18 at 16:29, <andrew.coop...@citrix.com> wrote: > > On 22/03/18 15:12, Jan Beulich wrote: > >> Paul, > >> > >> our PV

Re: [Xen-devel] possible I/O emulation state machine issue

2018-03-23 Thread Jan Beulich
>>> On 22.03.18 at 16:29, wrote: > On 22/03/18 15:12, Jan Beulich wrote: >> Paul, >> >> our PV driver person has found a reproducible crash with ws2k8, >> triggered by one of the WHQL tests. The guest get crashed because >> the re-issue check of an ioreq close to the

Re: [Xen-devel] possible I/O emulation state machine issue

2018-03-22 Thread Andrew Cooper
On 22/03/18 15:12, Jan Beulich wrote: > Paul, > > our PV driver person has found a reproducible crash with ws2k8, > triggered by one of the WHQL tests. The guest get crashed because > the re-issue check of an ioreq close to the top of hvmemul_do_io() > fails. I've handed him a first debugging

[Xen-devel] possible I/O emulation state machine issue

2018-03-22 Thread Jan Beulich
Paul, our PV driver person has found a reproducible crash with ws2k8, triggered by one of the WHQL tests. The guest get crashed because the re-issue check of an ioreq close to the top of hvmemul_do_io() fails. I've handed him a first debugging patch, output of which suggests that we're dealing