Re: API/ABIs: Re: [RFC PATCH v2 0/2] Add a new acquire resource to query vcpu statistics

2023-03-14 Thread Jan Beulich
On 14.03.2023 11:28, Matias Ezequiel Vara Larsen wrote: > On Fri, Mar 10, 2023 at 12:34:33PM +0100, Jan Beulich wrote: >> On 10.03.2023 11:58, Matias Ezequiel Vara Larsen wrote: >>> Oh, I see, thanks for the clarification. To summarise, these are the current >>> options: >>> 1. Use a "uint64_t"

Re: API/ABIs: Re: [RFC PATCH v2 0/2] Add a new acquire resource to query vcpu statistics

2023-03-14 Thread Matias Ezequiel Vara Larsen
On Fri, Mar 10, 2023 at 12:34:33PM +0100, Jan Beulich wrote: > On 10.03.2023 11:58, Matias Ezequiel Vara Larsen wrote: > > Oh, I see, thanks for the clarification. To summarise, these are the current > > options: > > 1. Use a "uint64_t" field thus limiting the number of counters to 64. The > >

Re: API/ABIs: Re: [RFC PATCH v2 0/2] Add a new acquire resource to query vcpu statistics

2023-03-10 Thread Jan Beulich
On 10.03.2023 11:58, Matias Ezequiel Vara Larsen wrote: > Oh, I see, thanks for the clarification. To summarise, these are the current > options: > 1. Use a "uint64_t" field thus limiting the number of counters to 64. The > current vcpu_runstate_info structure is limited to 4 counters though, one

Re: API/ABIs: Re: [RFC PATCH v2 0/2] Add a new acquire resource to query vcpu statistics

2023-03-10 Thread Matias Ezequiel Vara Larsen
On Thu, Mar 09, 2023 at 12:50:18PM +0100, Jan Beulich wrote: > On 09.03.2023 11:38, Matias Ezequiel Vara Larsen wrote: > > On Wed, Mar 08, 2023 at 03:16:05PM +0100, Jan Beulich wrote: > >> On 08.03.2023 12:54, Matias Ezequiel Vara Larsen wrote: > >>> On Tue, Mar 07, 2023 at 11:12:00AM +0100, Jan

Re: API/ABIs: Re: [RFC PATCH v2 0/2] Add a new acquire resource to query vcpu statistics

2023-03-09 Thread Jan Beulich
On 09.03.2023 11:38, Matias Ezequiel Vara Larsen wrote: > On Wed, Mar 08, 2023 at 03:16:05PM +0100, Jan Beulich wrote: >> On 08.03.2023 12:54, Matias Ezequiel Vara Larsen wrote: >>> On Tue, Mar 07, 2023 at 11:12:00AM +0100, Jan Beulich wrote: On 06.03.2023 15:23, Matias Ezequiel Vara Larsen

Re: API/ABIs: Re: [RFC PATCH v2 0/2] Add a new acquire resource to query vcpu statistics

2023-03-09 Thread Matias Ezequiel Vara Larsen
On Wed, Mar 08, 2023 at 03:16:05PM +0100, Jan Beulich wrote: > On 08.03.2023 12:54, Matias Ezequiel Vara Larsen wrote: > > On Tue, Mar 07, 2023 at 11:12:00AM +0100, Jan Beulich wrote: > >> On 06.03.2023 15:23, Matias Ezequiel Vara Larsen wrote: > >>> - Xen shall use the "stats_active" field to

Re: API/ABIs: Re: [RFC PATCH v2 0/2] Add a new acquire resource to query vcpu statistics

2023-03-08 Thread Jan Beulich
On 08.03.2023 12:54, Matias Ezequiel Vara Larsen wrote: > On Tue, Mar 07, 2023 at 11:12:00AM +0100, Jan Beulich wrote: >> On 06.03.2023 15:23, Matias Ezequiel Vara Larsen wrote: >>> - Xen shall use the "stats_active" field to indicate what it is producing. >>> In >>> this field, reserved bits

Re: API/ABIs: Re: [RFC PATCH v2 0/2] Add a new acquire resource to query vcpu statistics

2023-03-08 Thread Matias Ezequiel Vara Larsen
On Tue, Mar 07, 2023 at 11:12:00AM +0100, Jan Beulich wrote: > On 06.03.2023 15:23, Matias Ezequiel Vara Larsen wrote: > > Regarding your email, I have the following comments: > > > > - I still do not know how to choose the value of cacheline_size. I > > understand > > this value shall be

Re: API/ABIs: Re: [RFC PATCH v2 0/2] Add a new acquire resource to query vcpu statistics

2023-03-07 Thread Jan Beulich
On 06.03.2023 15:23, Matias Ezequiel Vara Larsen wrote: > Regarding your email, I have the following comments: > > - I still do not know how to choose the value of cacheline_size. I understand > this value shall be between the actual cacheline_size and PAGE_SIZE. A value > that could match most

Re: API/ABIs: Re: [RFC PATCH v2 0/2] Add a new acquire resource to query vcpu statistics

2023-03-06 Thread Matias Ezequiel Vara Larsen
Hello Andrew and thanks for the comments, please find my comments below. On Thu, Feb 23, 2023 at 07:56:28PM +, Andrew Cooper wrote: > A discussion about forward extensible APIs and ABIs here. > > First, its important to say that this should be "domain stats" and not > just "vcpu stats". 

API/ABIs: Re: [RFC PATCH v2 0/2] Add a new acquire resource to query vcpu statistics

2023-02-23 Thread Andrew Cooper
A discussion about forward extensible APIs and ABIs here. First, its important to say that this should be "domain stats" and not just "vcpu stats".  This is easy to account for now, but hard to retrofit later. For the shared memory, we have a minimum granularity of PAGE_SIZE (4k for now, but