RE: [PATCH v5 01/23] xl / libxl: s/pcidev/pci and remove DEFINE_DEVICE_TYPE_STRUCT_X

2020-12-07 Thread Durrant, Paul
> -Original Message- > From: Paul Durrant > Sent: 07 December 2020 16:18 > To: p...@xen.org; 'Wei Liu' > Cc: xen-devel@lists.xenproject.org; Durrant, Paul ; > 'Oleksandr Andrushchenko' > ; 'Ian Jackson' ; > 'Anthony PERARD' > > Subject: RE: [EXTERNAL] [PATCH v5 01/23] xl / libxl: s/pci

RE: [PATCH v5 01/23] xl / libxl: s/pcidev/pci and remove DEFINE_DEVICE_TYPE_STRUCT_X

2020-12-07 Thread Paul Durrant
> -Original Message- [snip] > > > > > > > > This is going to break libxl callers because the name "pcidev" is > > > > visible from the public header. > > > > > > > > I agree this is confusing and inconsistent, but we didn't go extra > > > > length to maintain the inconsistency for no reason

RE: [PATCH v5 01/23] xl / libxl: s/pcidev/pci and remove DEFINE_DEVICE_TYPE_STRUCT_X

2020-12-04 Thread Paul Durrant
ecember 2020 11:13 > > > To: Paul Durrant > > > Cc: xen-devel@lists.xenproject.org; Paul Durrant ; > > > Oleksandr Andrushchenko > > > ; Ian Jackson ; > > > Wei Liu ; > Anthony > > > PERARD > > > Subject: Re: [PATCH v5 01/23] xl / libxl

Re: [PATCH v5 01/23] xl / libxl: s/pcidev/pci and remove DEFINE_DEVICE_TYPE_STRUCT_X

2020-12-04 Thread Wei Liu
gt; ; Ian Jackson ; Wei > > Liu ; Anthony > > PERARD > > Subject: Re: [PATCH v5 01/23] xl / libxl: s/pcidev/pci and remove > > DEFINE_DEVICE_TYPE_STRUCT_X > > > > On Thu, Dec 03, 2020 at 02:25:12PM +, Paul Durrant wrote: > > > From: Pau

RE: [PATCH v5 01/23] xl / libxl: s/pcidev/pci and remove DEFINE_DEVICE_TYPE_STRUCT_X

2020-12-04 Thread Paul Durrant
> -Original Message- > From: Wei Liu > Sent: 04 December 2020 11:13 > To: Paul Durrant > Cc: xen-devel@lists.xenproject.org; Paul Durrant ; > Oleksandr Andrushchenko > ; Ian Jackson ; Wei > Liu ; Anthony > PERARD > Subject: Re: [PATCH v5 01/23] xl /

Re: [PATCH v5 01/23] xl / libxl: s/pcidev/pci and remove DEFINE_DEVICE_TYPE_STRUCT_X

2020-12-04 Thread Wei Liu
On Fri, Dec 04, 2020 at 11:13:26AM +, Wei Liu wrote: > On Thu, Dec 03, 2020 at 02:25:12PM +, Paul Durrant wrote: > > From: Paul Durrant > > > > The seemingly arbitrary use of 'pci' and 'pcidev' in the code in libxl_pci.c > > is confusing and also compromises use of some macros used for ot

Re: [PATCH v5 01/23] xl / libxl: s/pcidev/pci and remove DEFINE_DEVICE_TYPE_STRUCT_X

2020-12-04 Thread Wei Liu
On Thu, Dec 03, 2020 at 02:25:12PM +, Paul Durrant wrote: > From: Paul Durrant > > The seemingly arbitrary use of 'pci' and 'pcidev' in the code in libxl_pci.c > is confusing and also compromises use of some macros used for other device > types. Indeed it seems that DEFINE_DEVICE_TYPE_STRUCT_