> -Original Message-
> From: Paul Durrant
> Sent: 07 December 2020 16:18
> To: p...@xen.org; 'Wei Liu'
> Cc: xen-devel@lists.xenproject.org; Durrant, Paul ;
> 'Oleksandr Andrushchenko'
> ; 'Ian Jackson' ;
> 'Anthony PERARD'
>
> Subject: RE: [EXTERNAL] [PATCH v5 01/23] xl / libxl: s/pci
> -Original Message-
[snip]
> > > >
> > > > This is going to break libxl callers because the name "pcidev" is
> > > > visible from the public header.
> > > >
> > > > I agree this is confusing and inconsistent, but we didn't go extra
> > > > length to maintain the inconsistency for no reason
ecember 2020 11:13
> > > To: Paul Durrant
> > > Cc: xen-devel@lists.xenproject.org; Paul Durrant ;
> > > Oleksandr Andrushchenko
> > > ; Ian Jackson ;
> > > Wei Liu ;
> Anthony
> > > PERARD
> > > Subject: Re: [PATCH v5 01/23] xl / libxl
gt; ; Ian Jackson ; Wei
> > Liu ; Anthony
> > PERARD
> > Subject: Re: [PATCH v5 01/23] xl / libxl: s/pcidev/pci and remove
> > DEFINE_DEVICE_TYPE_STRUCT_X
> >
> > On Thu, Dec 03, 2020 at 02:25:12PM +, Paul Durrant wrote:
> > > From: Pau
> -Original Message-
> From: Wei Liu
> Sent: 04 December 2020 11:13
> To: Paul Durrant
> Cc: xen-devel@lists.xenproject.org; Paul Durrant ;
> Oleksandr Andrushchenko
> ; Ian Jackson ; Wei
> Liu ; Anthony
> PERARD
> Subject: Re: [PATCH v5 01/23] xl /
On Fri, Dec 04, 2020 at 11:13:26AM +, Wei Liu wrote:
> On Thu, Dec 03, 2020 at 02:25:12PM +, Paul Durrant wrote:
> > From: Paul Durrant
> >
> > The seemingly arbitrary use of 'pci' and 'pcidev' in the code in libxl_pci.c
> > is confusing and also compromises use of some macros used for ot
On Thu, Dec 03, 2020 at 02:25:12PM +, Paul Durrant wrote:
> From: Paul Durrant
>
> The seemingly arbitrary use of 'pci' and 'pcidev' in the code in libxl_pci.c
> is confusing and also compromises use of some macros used for other device
> types. Indeed it seems that DEFINE_DEVICE_TYPE_STRUCT_