Re: Memory ordering question in the shutdown deferral code

2020-09-24 Thread Julien Grall
Hi, On 23/09/2020 23:57, Stefano Stabellini wrote: On Mon, 21 Sep 2020, Julien Grall wrote: On 21/09/2020 13:55, Durrant, Paul wrote: (+ Xen-devel) Sorry I forgot to CC xen-devel. On 21/09/2020 12:38, Julien Grall wrote: Hi all, I have started to look at the deferral code (see

Re: Memory ordering question in the shutdown deferral code

2020-09-23 Thread Stefano Stabellini
On Mon, 21 Sep 2020, Julien Grall wrote: > On 21/09/2020 13:55, Durrant, Paul wrote: > > > (+ Xen-devel) > > > > > > Sorry I forgot to CC xen-devel. > > > > > > On 21/09/2020 12:38, Julien Grall wrote: > > > > Hi all, > > > > > > > > I have started to look at the deferral code (see > > > >

Re: Memory ordering question in the shutdown deferral code

2020-09-21 Thread Julien Grall
Hi Jan, On 21/09/2020 14:11, Jan Beulich wrote: On 21.09.2020 13:40, Julien Grall wrote: (+ Xen-devel) Sorry I forgot to CC xen-devel. On 21/09/2020 12:38, Julien Grall wrote: Hi all, I have started to look at the deferral code (see vcpu_start_shutdown_deferral()) because we need it for

Re: Memory ordering question in the shutdown deferral code

2020-09-21 Thread Jan Beulich
On 21.09.2020 15:35, Durrant, Paul wrote: >> From: Jan Beulich >> Sent: 21 September 2020 14:32 >> >> On 21.09.2020 15:27, Julien Grall wrote: >>> I think this part is racy at least on non-x86 platform as x86 seems to >>> implement smp_mb() with a strong memory barrier (mfence). >> >> The

RE: Memory ordering question in the shutdown deferral code

2020-09-21 Thread Durrant, Paul
> -Original Message- > From: Jan Beulich > Sent: 21 September 2020 14:32 > To: Julien Grall > Cc: Durrant, Paul ; Stefano Stabellini > ; > andrew.coop...@citrix.com; George Dunlap ; Xia, > Hongyan > ; xen-devel@lists.xenproject.org > Subject: RE: [EXTE

Re: Memory ordering question in the shutdown deferral code

2020-09-21 Thread Jan Beulich
On 21.09.2020 15:27, Julien Grall wrote: > I think this part is racy at least on non-x86 platform as x86 seems to > implement smp_mb() with a strong memory barrier (mfence). The "strength" of the memory barrier doesn't matter here imo. It's the fully coherent memory model (for WB type memory)

Re: Memory ordering question in the shutdown deferral code

2020-09-21 Thread Xia, Hongyan
ge Dunlap > > ; Durrant, Paul > > > > Cc: Xia, Hongyan ; > > xen-devel@lists.xenproject.org > > Subject: RE: [EXTERNAL] Memory ordering question in the shutdown > > deferral code > > > > CAUTION: This email originated from outside of the organization.

Re: Memory ordering question in the shutdown deferral code

2020-09-21 Thread Julien Grall
] Memory ordering question in the shutdown deferral code CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. (+ Xen-devel) Sorry I forgot to CC xen-devel. On 21/09/2020 12:38

Re: Memory ordering question in the shutdown deferral code

2020-09-21 Thread Jan Beulich
On 21.09.2020 13:40, Julien Grall wrote: > (+ Xen-devel) > > Sorry I forgot to CC xen-devel. > > On 21/09/2020 12:38, Julien Grall wrote: >> Hi all, >> >> I have started to look at the deferral code (see >> vcpu_start_shutdown_deferral()) because we need it for LiveUpdate and >> Arm will soon

RE: Memory ordering question in the shutdown deferral code

2020-09-21 Thread Durrant, Paul
> -Original Message- > From: Julien Grall > Sent: 21 September 2020 12:41 > To: Jan Beulich ; Stefano Stabellini > ; > andrew.coop...@citrix.com; George Dunlap ; Durrant, > Paul > > Cc: Xia, Hongyan ; xen-devel@lists.xenproject.org > Subject: RE: [EXTE

Re: Memory ordering question in the shutdown deferral code

2020-09-21 Thread Julien Grall
(+ Xen-devel) Sorry I forgot to CC xen-devel. On 21/09/2020 12:38, Julien Grall wrote: Hi all, I have started to look at the deferral code (see vcpu_start_shutdown_deferral()) because we need it for LiveUpdate and Arm will soon use it. The current implementation is using an smp_mb() to