Re: [Eclair false positive] Re: [PATCH] x86/msr: Rework wrmsr_safe() using asm goto()

2025-05-26 Thread Nicola Vetrini
On 2025-05-25 15:36, Nicola Vetrini wrote: On 2025-05-25 12:52, Andrew Cooper wrote: On 25/05/2025 8:34 am, Nicola Vetrini wrote: On 2025-05-22 15:49, Andrew Cooper wrote: On 22/05/2025 1:45 pm, Nicola Vetrini wrote: On 2025-05-21 20:00, Andrew Cooper wrote: On 21/05/2025 3:36 pm, Andrew Coo

Re: [Eclair false positive] Re: [PATCH] x86/msr: Rework wrmsr_safe() using asm goto()

2025-05-25 Thread Nicola Vetrini
On 2025-05-25 12:52, Andrew Cooper wrote: On 25/05/2025 8:34 am, Nicola Vetrini wrote: On 2025-05-22 15:49, Andrew Cooper wrote: On 22/05/2025 1:45 pm, Nicola Vetrini wrote: On 2025-05-21 20:00, Andrew Cooper wrote: On 21/05/2025 3:36 pm, Andrew Cooper wrote: diff --git a/xen/arch/x86/includ

Re: [Eclair false positive] Re: [PATCH] x86/msr: Rework wrmsr_safe() using asm goto()

2025-05-25 Thread Andrew Cooper
On 25/05/2025 8:34 am, Nicola Vetrini wrote: > On 2025-05-22 15:49, Andrew Cooper wrote: >> On 22/05/2025 1:45 pm, Nicola Vetrini wrote: >>> On 2025-05-21 20:00, Andrew Cooper wrote: On 21/05/2025 3:36 pm, Andrew Cooper wrote: > diff --git a/xen/arch/x86/include/asm/msr.h > b/xen/arch/

Re: [Eclair false positive] Re: [PATCH] x86/msr: Rework wrmsr_safe() using asm goto()

2025-05-25 Thread Nicola Vetrini
On 2025-05-22 15:49, Andrew Cooper wrote: On 22/05/2025 1:45 pm, Nicola Vetrini wrote: On 2025-05-21 20:00, Andrew Cooper wrote: On 21/05/2025 3:36 pm, Andrew Cooper wrote: diff --git a/xen/arch/x86/include/asm/msr.h b/xen/arch/x86/include/asm/msr.h index 0d3b1d637488..4c4f18b3a54d 100644 ---

Re: [Eclair false positive] Re: [PATCH] x86/msr: Rework wrmsr_safe() using asm goto()

2025-05-22 Thread Andrew Cooper
On 22/05/2025 1:45 pm, Nicola Vetrini wrote: > On 2025-05-21 20:00, Andrew Cooper wrote: >> On 21/05/2025 3:36 pm, Andrew Cooper wrote: >>> diff --git a/xen/arch/x86/include/asm/msr.h >>> b/xen/arch/x86/include/asm/msr.h >>> index 0d3b1d637488..4c4f18b3a54d 100644 >>> --- a/xen/arch/x86/include/asm

Re: [Eclair false positive] Re: [PATCH] x86/msr: Rework wrmsr_safe() using asm goto()

2025-05-22 Thread Nicola Vetrini
On 2025-05-21 20:00, Andrew Cooper wrote: On 21/05/2025 3:36 pm, Andrew Cooper wrote: diff --git a/xen/arch/x86/include/asm/msr.h b/xen/arch/x86/include/asm/msr.h index 0d3b1d637488..4c4f18b3a54d 100644 --- a/xen/arch/x86/include/asm/msr.h +++ b/xen/arch/x86/include/asm/msr.h @@ -69,20 +69,20 @

Re: [Eclair false positive] Re: [PATCH] x86/msr: Rework wrmsr_safe() using asm goto()

2025-05-21 Thread Nicola Vetrini
On 2025-05-21 21:43, Andrew Cooper wrote: On 21/05/2025 8:21 pm, Nicola Vetrini wrote: On 2025-05-21 20:00, Andrew Cooper wrote: On 21/05/2025 3:36 pm, Andrew Cooper wrote: diff --git a/xen/arch/x86/include/asm/msr.h b/xen/arch/x86/include/asm/msr.h index 0d3b1d637488..4c4f18b3a54d 100644 ---

Re: [Eclair false positive] Re: [PATCH] x86/msr: Rework wrmsr_safe() using asm goto()

2025-05-21 Thread Andrew Cooper
On 21/05/2025 8:48 pm, Nicola Vetrini wrote: > On 2025-05-21 21:43, Andrew Cooper wrote: >> On 21/05/2025 8:21 pm, Nicola Vetrini wrote: >>> On 2025-05-21 20:00, Andrew Cooper wrote: On 21/05/2025 3:36 pm, Andrew Cooper wrote: > diff --git a/xen/arch/x86/include/asm/msr.h > b/xen/arch/

Re: [Eclair false positive] Re: [PATCH] x86/msr: Rework wrmsr_safe() using asm goto()

2025-05-21 Thread Andrew Cooper
On 21/05/2025 8:21 pm, Nicola Vetrini wrote: > On 2025-05-21 20:00, Andrew Cooper wrote: >> On 21/05/2025 3:36 pm, Andrew Cooper wrote: >>> diff --git a/xen/arch/x86/include/asm/msr.h >>> b/xen/arch/x86/include/asm/msr.h >>> index 0d3b1d637488..4c4f18b3a54d 100644 >>> --- a/xen/arch/x86/include/asm

Re: [Eclair false positive] Re: [PATCH] x86/msr: Rework wrmsr_safe() using asm goto()

2025-05-21 Thread Nicola Vetrini
On 2025-05-21 20:00, Andrew Cooper wrote: On 21/05/2025 3:36 pm, Andrew Cooper wrote: diff --git a/xen/arch/x86/include/asm/msr.h b/xen/arch/x86/include/asm/msr.h index 0d3b1d637488..4c4f18b3a54d 100644 --- a/xen/arch/x86/include/asm/msr.h +++ b/xen/arch/x86/include/asm/msr.h @@ -69,20 +69,20 @

[Eclair false positive] Re: [PATCH] x86/msr: Rework wrmsr_safe() using asm goto()

2025-05-21 Thread Andrew Cooper
On 21/05/2025 3:36 pm, Andrew Cooper wrote: > diff --git a/xen/arch/x86/include/asm/msr.h b/xen/arch/x86/include/asm/msr.h > index 0d3b1d637488..4c4f18b3a54d 100644 > --- a/xen/arch/x86/include/asm/msr.h > +++ b/xen/arch/x86/include/asm/msr.h > @@ -69,20 +69,20 @@ static inline void wrmsr_ns(uint32

Re: [PATCH] x86/msr: Rework wrmsr_safe() using asm goto()

2025-05-21 Thread Jan Beulich
On 21.05.2025 16:36, Andrew Cooper wrote: > This avoids needing to hold rc in a register across the WRMSR, and in most > cases removes direct testing and branching based on rc, as the fault label can > be rearranged to directly land on the out-of-line block. > > No functional change. > > Resolves