Re: [PATCH v2 3/7] x86/mce: bring hypercall subop compat checking in sync again

2020-07-15 Thread Jan Beulich
On 14.07.2020 16:31, Roger Pau Monné wrote: > On Tue, Jul 14, 2020 at 01:47:11PM +0200, Jan Beulich wrote: >> On 14.07.2020 13:19, Roger Pau Monné wrote: >>> On Wed, Jul 01, 2020 at 12:26:54PM +0200, Jan Beulich wrote: Use a typedef in struct xen_mc also for the two subops "manually"

Re: [PATCH v2 3/7] x86/mce: bring hypercall subop compat checking in sync again

2020-07-14 Thread Roger Pau Monné
On Wed, Jul 01, 2020 at 12:26:54PM +0200, Jan Beulich wrote: > Use a typedef in struct xen_mc also for the two subops "manually" > translated in the handler, just for consistency. No functional > change. > > Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné Thanks.

Re: [PATCH v2 3/7] x86/mce: bring hypercall subop compat checking in sync again

2020-07-14 Thread Roger Pau Monné
On Tue, Jul 14, 2020 at 01:47:11PM +0200, Jan Beulich wrote: > On 14.07.2020 13:19, Roger Pau Monné wrote: > > On Wed, Jul 01, 2020 at 12:26:54PM +0200, Jan Beulich wrote: > >> Use a typedef in struct xen_mc also for the two subops "manually" > >> translated in the handler, just for consistency.

Re: [PATCH v2 3/7] x86/mce: bring hypercall subop compat checking in sync again

2020-07-14 Thread Jan Beulich
On 14.07.2020 13:19, Roger Pau Monné wrote: > On Wed, Jul 01, 2020 at 12:26:54PM +0200, Jan Beulich wrote: >> Use a typedef in struct xen_mc also for the two subops "manually" >> translated in the handler, just for consistency. No functional >> change. > > I'm slightly puzzled by the fact that

Re: [PATCH v2 3/7] x86/mce: bring hypercall subop compat checking in sync again

2020-07-14 Thread Roger Pau Monné
On Wed, Jul 01, 2020 at 12:26:54PM +0200, Jan Beulich wrote: > Use a typedef in struct xen_mc also for the two subops "manually" > translated in the handler, just for consistency. No functional > change. I'm slightly puzzled by the fact that mc_fetch is marked as needs checking while