Re: [PATCH v3 13/15] unzstd: replace INIT{,DATA} and STATIC

2021-04-15 Thread Julien Grall
Hi Jan, On 15/04/2021 15:34, Jan Beulich wrote: On 15.04.2021 16:30, Julien Grall wrote: On 15/04/2021 15:25, Jan Beulich wrote: On 15.04.2021 16:22, Julien Grall wrote: On 15/04/2021 15:21, Jan Beulich wrote: On 15.04.2021 13:59, Julien Grall wrote: On 26/01/2021 09:52, Jan Beulich wrote:

Re: [PATCH v3 13/15] unzstd: replace INIT{,DATA} and STATIC

2021-04-15 Thread Jan Beulich
On 15.04.2021 16:30, Julien Grall wrote: > On 15/04/2021 15:25, Jan Beulich wrote: >> On 15.04.2021 16:22, Julien Grall wrote: >>> On 15/04/2021 15:21, Jan Beulich wrote: On 15.04.2021 13:59, Julien Grall wrote: > On 26/01/2021 09:52, Jan Beulich wrote: >> With xen/common/decompress.h

Re: [PATCH v3 13/15] unzstd: replace INIT{,DATA} and STATIC

2021-04-15 Thread Julien Grall
On 15/04/2021 15:25, Jan Beulich wrote: On 15.04.2021 16:22, Julien Grall wrote: On 15/04/2021 15:21, Jan Beulich wrote: On 15.04.2021 13:59, Julien Grall wrote: On 26/01/2021 09:52, Jan Beulich wrote: With xen/common/decompress.h now agreeing in both build modes about what STATIC expands

Re: [PATCH v3 13/15] unzstd: replace INIT{,DATA} and STATIC

2021-04-15 Thread Jan Beulich
On 15.04.2021 16:22, Julien Grall wrote: > On 15/04/2021 15:21, Jan Beulich wrote: >> On 15.04.2021 13:59, Julien Grall wrote: >>> On 26/01/2021 09:52, Jan Beulich wrote: With xen/common/decompress.h now agreeing in both build modes about what STATIC expands to, there's no need for this

Re: [PATCH v3 13/15] unzstd: replace INIT{,DATA} and STATIC

2021-04-15 Thread Julien Grall
On 15/04/2021 15:21, Jan Beulich wrote: On 15.04.2021 13:59, Julien Grall wrote: On 26/01/2021 09:52, Jan Beulich wrote: With xen/common/decompress.h now agreeing in both build modes about what STATIC expands to, there's no need for this abstraction anymore. Shouldn't you also mention

Re: [PATCH v3 13/15] unzstd: replace INIT{,DATA} and STATIC

2021-04-15 Thread Jan Beulich
On 15.04.2021 13:59, Julien Grall wrote: > On 26/01/2021 09:52, Jan Beulich wrote: >> With xen/common/decompress.h now agreeing in both build modes about >> what STATIC expands to, there's no need for this abstraction anymore. > > Shouldn't you also mention "INIT" and "INITDATA" here? Two parts:

Re: [PATCH v3 13/15] unzstd: replace INIT{,DATA} and STATIC

2021-04-15 Thread Julien Grall
Hi Jan, On 26/01/2021 09:52, Jan Beulich wrote: With xen/common/decompress.h now agreeing in both build modes about what STATIC expands to, there's no need for this abstraction anymore. Shouldn't you also mention "INIT" and "INITDATA" here? Cheers, Requested-by: Andrew Cooper