Re: [PATCH v4] VMX: use a single, global APIC access page

2021-04-22 Thread Tim Deegan
At 11:38 +0200 on 22 Apr (1619091522), Jan Beulich wrote: > On 22.04.2021 09:42, Tim Deegan wrote: > > At 13:25 +0200 on 19 Apr (1618838726), Jan Beulich wrote: > >> On 17.04.2021 21:24, Tim Deegan wrote: > >>> At 12:40 +0200 on 12 Apr (1618231248), Jan Beulich wrote: > ---

Re: [PATCH v4] VMX: use a single, global APIC access page

2021-04-22 Thread Jan Beulich
On 22.04.2021 09:42, Tim Deegan wrote: > At 13:25 +0200 on 19 Apr (1618838726), Jan Beulich wrote: >> On 17.04.2021 21:24, Tim Deegan wrote: >>> At 12:40 +0200 on 12 Apr (1618231248), Jan Beulich wrote: --- a/xen/arch/x86/mm/shadow/set.c +++ b/xen/arch/x86/mm/shadow/set.c @@ -94,6

Re: [PATCH v4] VMX: use a single, global APIC access page

2021-04-22 Thread Tim Deegan
At 13:25 +0200 on 19 Apr (1618838726), Jan Beulich wrote: > On 17.04.2021 21:24, Tim Deegan wrote: > > At 12:40 +0200 on 12 Apr (1618231248), Jan Beulich wrote: > >> By making this page global, we also eliminate the need to refcount it, > >> or to assign it to any domain in the first place. > > >

Re: [PATCH v4] VMX: use a single, global APIC access page

2021-04-19 Thread Jan Beulich
On 17.04.2021 21:24, Tim Deegan wrote: > At 12:40 +0200 on 12 Apr (1618231248), Jan Beulich wrote: >> The address of this page is used by the CPU only to recognize when to >> access the virtual APIC page instead. No accesses would ever go to this >> page. It only needs to be present in the (CPU)

Re: [PATCH v4] VMX: use a single, global APIC access page

2021-04-17 Thread Tim Deegan
Hi, Apologies for not sending comments before, and thanks for the ping. At 12:40 +0200 on 12 Apr (1618231248), Jan Beulich wrote: > The address of this page is used by the CPU only to recognize when to > access the virtual APIC page instead. No accesses would ever go to this > page. It only

Re: [PATCH v4] VMX: use a single, global APIC access page

2021-04-13 Thread Roger Pau Monné
On Tue, Apr 13, 2021 at 02:03:52PM +0200, Jan Beulich wrote: > On 13.04.2021 12:18, Roger Pau Monné wrote: > > On Tue, Apr 13, 2021 at 11:24:09AM +0200, Jan Beulich wrote: > >> On 12.04.2021 17:31, Roger Pau Monné wrote: > >>> On Mon, Apr 12, 2021 at 12:40:48PM +0200, Jan Beulich wrote: > +

Re: [PATCH v4] VMX: use a single, global APIC access page

2021-04-13 Thread Jan Beulich
On 13.04.2021 12:18, Roger Pau Monné wrote: > On Tue, Apr 13, 2021 at 11:24:09AM +0200, Jan Beulich wrote: >> On 12.04.2021 17:31, Roger Pau Monné wrote: >>> On Mon, Apr 12, 2021 at 12:40:48PM +0200, Jan Beulich wrote: +{ +const struct page_info *pg = mfn_to_page(mfn); +

Re: [PATCH v4] VMX: use a single, global APIC access page

2021-04-13 Thread Roger Pau Monné
On Tue, Apr 13, 2021 at 11:24:09AM +0200, Jan Beulich wrote: > On 12.04.2021 17:31, Roger Pau Monné wrote: > > On Mon, Apr 12, 2021 at 12:40:48PM +0200, Jan Beulich wrote: > >> The address of this page is used by the CPU only to recognize when to > >> access the virtual APIC page instead. No

Re: [PATCH v4] VMX: use a single, global APIC access page

2021-04-13 Thread Jan Beulich
On 12.04.2021 17:31, Roger Pau Monné wrote: > On Mon, Apr 12, 2021 at 12:40:48PM +0200, Jan Beulich wrote: >> The address of this page is used by the CPU only to recognize when to >> access the virtual APIC page instead. No accesses would ever go to this >> page. It only needs to be present in the

Re: [PATCH v4] VMX: use a single, global APIC access page

2021-04-12 Thread Roger Pau Monné
On Mon, Apr 12, 2021 at 12:40:48PM +0200, Jan Beulich wrote: > The address of this page is used by the CPU only to recognize when to > access the virtual APIC page instead. No accesses would ever go to this > page. It only needs to be present in the (CPU) page tables so that > address translation