Re: [PATCH v4 0/8] Allow dynamic allocation of software IO TLB bounce buffers

2023-07-20 Thread Christoph Hellwig
On Thu, Jul 20, 2023 at 10:13:20AM +0200, Petr Tesařík wrote: > Fine with me. I removed it after all my testing showed no performance > impact as long as the size of the initial SWIOTLB is kept at the > default value (and sufficient for the workload), but it's OK for me if > dynamic SWIOTLB

Re: [PATCH v4 0/8] Allow dynamic allocation of software IO TLB bounce buffers

2023-07-20 Thread Petr Tesařík
On Thu, 20 Jul 2023 08:52:16 +0200 Christoph Hellwig wrote: > Just to add a highlevel comment here after I feel like I need a little > more time to review the guts. > > I'm still pretty concerned about the extra list that needs to be > consulted in is_swiotlb_buffer, but I can't really think of

Re: [PATCH v4 0/8] Allow dynamic allocation of software IO TLB bounce buffers

2023-07-20 Thread Christoph Hellwig
Just to add a highlevel comment here after I feel like I need a little more time to review the guts. I'm still pretty concerned about the extra list that needs to be consulted in is_swiotlb_buffer, but I can't really think of anything better. Maybe an xarray has better cache characteristics, but