Re: [PATCH v4 1/3] VMX: use a single, global APIC access page

2021-04-26 Thread Tim Deegan
At 16:42 +0200 on 23 Apr (1619196141), Jan Beulich wrote: > On 23.04.2021 16:17, Roger Pau Monné wrote: > > On Fri, Apr 23, 2021 at 12:52:57PM +0200, Jan Beulich wrote: > >> +if ( mfn_valid(mfn = shadow_l1e_get_mfn(sl1e)) && > > > > Nit: I would prefer if assigned mfn outside of the

Re: [PATCH v4 1/3] VMX: use a single, global APIC access page

2021-04-26 Thread Tim Deegan
At 12:52 +0200 on 23 Apr (1619182377), Jan Beulich wrote: > The address of this page is used by the CPU only to recognize when to > access the virtual APIC page instead. No accesses would ever go to this > page. It only needs to be present in the (CPU) page tables so that > address translation

RE: [PATCH v4 1/3] VMX: use a single, global APIC access page

2021-04-24 Thread Tian, Kevin
> From: Jan Beulich > Sent: Friday, April 23, 2021 6:53 PM > > The address of this page is used by the CPU only to recognize when to > access the virtual APIC page instead. No accesses would ever go to this > page. It only needs to be present in the (CPU) page tables so that > address

Re: [PATCH v4 1/3] VMX: use a single, global APIC access page

2021-04-23 Thread Jan Beulich
On 23.04.2021 16:17, Roger Pau Monné wrote: > On Fri, Apr 23, 2021 at 12:52:57PM +0200, Jan Beulich wrote: >> --- a/xen/arch/x86/mm/shadow/set.c >> +++ b/xen/arch/x86/mm/shadow/set.c >> @@ -94,6 +94,15 @@ shadow_get_page_from_l1e(shadow_l1e_t sl >> ASSERT(!sh_l1e_is_magic(sl1e)); >>

Re: [PATCH v4 1/3] VMX: use a single, global APIC access page

2021-04-23 Thread Roger Pau Monné
On Fri, Apr 23, 2021 at 12:52:57PM +0200, Jan Beulich wrote: > --- a/xen/arch/x86/mm/shadow/set.c > +++ b/xen/arch/x86/mm/shadow/set.c > @@ -94,6 +94,15 @@ shadow_get_page_from_l1e(shadow_l1e_t sl > ASSERT(!sh_l1e_is_magic(sl1e)); > ASSERT(shadow_mode_refcounts(d)); > > +/* > +