Re: [Xen-devel] [PATCH] Xen/pciback: Implement PCI slot or bus reset with 'do_flr' SysFS attribute

2017-11-30 Thread Govinda Tatti
On 11/30/2017 2:29 AM, Jan Beulich wrote: On 29.11.17 at 20:44, wrote: So, we will use the following sequence to reset the requested device/function. - FLR (as first option) - BUS/SLOT reset (as fall-back option) if FLR is not supported or any issue with FLR It

Re: [Xen-devel] [PATCH] Xen/pciback: Implement PCI slot or bus reset with 'do_flr' SysFS attribute

2017-11-30 Thread Jan Beulich
>>> On 29.11.17 at 20:44, wrote: > So, we will use the following sequence to reset the requested > device/function. > > - FLR (as first option) > - BUS/SLOT reset (as fall-back option) if FLR is not supported or any > issue with FLR It looks to me as if the slot

Re: [Xen-devel] [PATCH] Xen/pciback: Implement PCI slot or bus reset with 'do_flr' SysFS attribute

2017-11-29 Thread Govinda Tatti
On 11/29/2017 12:05 PM, Pasi Kärkkäinen wrote: On Wed, Nov 29, 2017 at 11:25:09AM -0600, Govinda Tatti wrote: Furthermore, contrary to what you claim in your reply to Pasi, I can't see where you try an actual FLR first - you go straight to pci_probe_reset_{slot,bus}(). If you actually tried

Re: [Xen-devel] [PATCH] Xen/pciback: Implement PCI slot or bus reset with 'do_flr' SysFS attribute

2017-11-29 Thread Govinda Tatti
Thanks Konrad for your response. Please see below for my comments. Well, that's more a question to Konrad as the maintainer. Personally I'd prefer just "reset", as "pci" is redundant and "bus" Can't do 'reset'. Why? B/c I forgot that this attribute is not per device, but on the module

Re: [Xen-devel] [PATCH] Xen/pciback: Implement PCI slot or bus reset with 'do_flr' SysFS attribute

2017-11-29 Thread Konrad Rzeszutek Wilk
On Wed, Nov 29, 2017 at 09:40:20AM -0700, Jan Beulich wrote: > >>> On 29.11.17 at 17:29, wrote: > > On Wed, Nov 29, 2017 at 08:35:33AM -0700, Jan Beulich wrote: > >> >>> On 29.11.17 at 16:08, wrote: > >> > On 11/9/2017 2:28 AM, Jan Beulich wrote:

Re: [Xen-devel] [PATCH] Xen/pciback: Implement PCI slot or bus reset with 'do_flr' SysFS attribute

2017-11-29 Thread Pasi Kärkkäinen
On Wed, Nov 29, 2017 at 11:25:09AM -0600, Govinda Tatti wrote: > > >>>Furthermore, contrary to what you claim in > >>>your reply to Pasi, I can't see where you try an actual FLR first - > >>>you go straight to pci_probe_reset_{slot,bus}(). If you actually > >>>tried FLR first, only falling back

Re: [Xen-devel] [PATCH] Xen/pciback: Implement PCI slot or bus reset with 'do_flr' SysFS attribute

2017-11-29 Thread Govinda Tatti
Furthermore, contrary to what you claim in your reply to Pasi, I can't see where you try an actual FLR first - you go straight to pci_probe_reset_{slot,bus}(). If you actually tried FLR first, only falling back to the other methods as "emulation", I could certainly agree with the file name

Re: [Xen-devel] [PATCH] Xen/pciback: Implement PCI slot or bus reset with 'do_flr' SysFS attribute

2017-11-29 Thread Jan Beulich
>>> On 29.11.17 at 16:08, wrote: > On 11/9/2017 2:28 AM, Jan Beulich wrote: > On 08.11.17 at 16:44, wrote: >>> On 11/7/2017 8:40 AM, Jan Beulich wrote: >>> On 06.11.17 at 18:48, wrote: > ---

Re: [Xen-devel] [PATCH] Xen/pciback: Implement PCI slot or bus reset with 'do_flr' SysFS attribute

2017-11-29 Thread Govinda Tatti
Jan, Sorry for the late response. Please see below for my comments. On 11/9/2017 2:28 AM, Jan Beulich wrote: On 08.11.17 at 16:44, wrote: On 11/7/2017 8:40 AM, Jan Beulich wrote: On 06.11.17 at 18:48, wrote: ---