Re: [Xen-devel] [PATCH] libxc: elf_kernel loader: Remove check for shstrtab

2019-05-16 Thread Andrew Cooper
On 16/05/2019 14:23, Wei Liu wrote: > On Wed, May 15, 2019 at 01:55:30PM +0100, Anthony PERARD wrote: >> On Wed, May 15, 2019 at 01:07:03PM +0100, Andrew Cooper wrote: >>> On 15/05/2019 12:40, Anthony PERARD wrote: This was probably useful to load ELF Note, but now ELF notes "should live

Re: [Xen-devel] [PATCH] libxc: elf_kernel loader: Remove check for shstrtab

2019-05-16 Thread Wei Liu
On Wed, May 15, 2019 at 01:55:30PM +0100, Anthony PERARD wrote: > On Wed, May 15, 2019 at 01:07:03PM +0100, Andrew Cooper wrote: > > On 15/05/2019 12:40, Anthony PERARD wrote: > > > This was probably useful to load ELF Note, but now ELF notes > > > "should live in a PT_NOTE segment" (elfnote.h). >

Re: [Xen-devel] [PATCH] libxc: elf_kernel loader: Remove check for shstrtab

2019-05-15 Thread Anthony PERARD
On Wed, May 15, 2019 at 01:07:03PM +0100, Andrew Cooper wrote: > On 15/05/2019 12:40, Anthony PERARD wrote: > > This was probably useful to load ELF Note, but now ELF notes > > "should live in a PT_NOTE segment" (elfnote.h). > > > > With notes living in segment, there are no need for sections, so

Re: [Xen-devel] [PATCH] libxc: elf_kernel loader: Remove check for shstrtab

2019-05-15 Thread Wei Liu
On Wed, May 15, 2019 at 01:07:03PM +0100, Andrew Cooper wrote: > On 15/05/2019 12:40, Anthony PERARD wrote: > > This was probably useful to load ELF Note, but now ELF notes > > "should live in a PT_NOTE segment" (elfnote.h). > > > > With notes living in segment, there are no need for sections, so

Re: [Xen-devel] [PATCH] libxc: elf_kernel loader: Remove check for shstrtab

2019-05-15 Thread Andrew Cooper
On 15/05/2019 12:40, Anthony PERARD wrote: > This was probably useful to load ELF Note, but now ELF notes > "should live in a PT_NOTE segment" (elfnote.h). > > With notes living in segment, there are no need for sections, so there > is nothing to be stored in the shstrtab. > > This patch would

Re: [Xen-devel] [PATCH] libxc: elf_kernel loader: Remove check for shstrtab

2019-05-15 Thread Wei Liu
On Wed, May 15, 2019 at 12:40:15PM +0100, Anthony PERARD wrote: > This was probably useful to load ELF Note, but now ELF notes > "should live in a PT_NOTE segment" (elfnote.h). > > With notes living in segment, there are no need for sections, so there > is nothing to be stored in the shstrtab. >