Re: [Xen-devel] [PATCH] x86/p2m: drop p2m_access_t parameter from set_mmio_p2m_entry()

2020-02-21 Thread Andrew Cooper
On 06/02/2020 15:20, Jan Beulich wrote: > Both callers request the host P2M's default access, which can as well be > done inside the function. While touching this anyway, make the "gfn" > parameter type-safe as well. > > Signed-off-by: Jan Beulich Acked-by: Andrew Cooper

Re: [Xen-devel] [PATCH] x86/p2m: drop p2m_access_t parameter from set_mmio_p2m_entry()

2020-02-17 Thread Tian, Kevin
> From: Jan Beulich > Sent: Thursday, February 6, 2020 11:20 PM > > Both callers request the host P2M's default access, which can as well be > done inside the function. While touching this anyway, make the "gfn" > parameter type-safe as well. > > Signed-off-by: Jan Beulich Reviewed-by: Kevin

Re: [Xen-devel] [PATCH] x86/p2m: drop p2m_access_t parameter from set_mmio_p2m_entry()

2020-02-10 Thread Jan Beulich
On 07.02.2020 18:21, Tamas K Lengyel wrote: > On Fri, Feb 7, 2020 at 10:16 AM Tamas K Lengyel wrote: >> >> On Fri, Feb 7, 2020 at 9:54 AM Jan Beulich wrote: >>> >>> On 07.02.2020 10:52, Roger Pau Monné wrote: On Fri, Feb 07, 2020 at 09:08:15AM +0100, Jan Beulich wrote: > On 06.02.2020

Re: [Xen-devel] [PATCH] x86/p2m: drop p2m_access_t parameter from set_mmio_p2m_entry()

2020-02-07 Thread Tamas K Lengyel
On Fri, Feb 7, 2020 at 10:16 AM Tamas K Lengyel wrote: > > On Fri, Feb 7, 2020 at 9:54 AM Jan Beulich wrote: > > > > On 07.02.2020 10:52, Roger Pau Monné wrote: > > > On Fri, Feb 07, 2020 at 09:08:15AM +0100, Jan Beulich wrote: > > >> On 06.02.2020 16:20, Jan Beulich wrote: > > >>> ---

Re: [Xen-devel] [PATCH] x86/p2m: drop p2m_access_t parameter from set_mmio_p2m_entry()

2020-02-07 Thread Tamas K Lengyel
On Fri, Feb 7, 2020 at 9:54 AM Jan Beulich wrote: > > On 07.02.2020 10:52, Roger Pau Monné wrote: > > On Fri, Feb 07, 2020 at 09:08:15AM +0100, Jan Beulich wrote: > >> On 06.02.2020 16:20, Jan Beulich wrote: > >>> --- a/xen/arch/x86/hvm/vmx/vmx.c > >>> +++ b/xen/arch/x86/hvm/vmx/vmx.c > >>> @@

Re: [Xen-devel] [PATCH] x86/p2m: drop p2m_access_t parameter from set_mmio_p2m_entry()

2020-02-07 Thread Jan Beulich
On 07.02.2020 10:52, Roger Pau Monné wrote: > On Fri, Feb 07, 2020 at 09:08:15AM +0100, Jan Beulich wrote: >> On 06.02.2020 16:20, Jan Beulich wrote: >>> --- a/xen/arch/x86/hvm/vmx/vmx.c >>> +++ b/xen/arch/x86/hvm/vmx/vmx.c >>> @@ -3037,9 +3037,8 @@ static int vmx_alloc_vlapic_mapping(stru >>>

Re: [Xen-devel] [PATCH] x86/p2m: drop p2m_access_t parameter from set_mmio_p2m_entry()

2020-02-07 Thread Roger Pau Monné
On Fri, Feb 07, 2020 at 09:08:15AM +0100, Jan Beulich wrote: > On 06.02.2020 16:20, Jan Beulich wrote: > > --- a/xen/arch/x86/hvm/vmx/vmx.c > > +++ b/xen/arch/x86/hvm/vmx/vmx.c > > @@ -3037,9 +3037,8 @@ static int vmx_alloc_vlapic_mapping(stru > > share_xen_page_with_guest(pg, d, SHARE_rw); >

Re: [Xen-devel] [PATCH] x86/p2m: drop p2m_access_t parameter from set_mmio_p2m_entry()

2020-02-07 Thread Jan Beulich
On 06.02.2020 16:20, Jan Beulich wrote: > --- a/xen/arch/x86/hvm/vmx/vmx.c > +++ b/xen/arch/x86/hvm/vmx/vmx.c > @@ -3037,9 +3037,8 @@ static int vmx_alloc_vlapic_mapping(stru > share_xen_page_with_guest(pg, d, SHARE_rw); > d->arch.hvm.vmx.apic_access_mfn = mfn; > > -return

Re: [Xen-devel] [PATCH] x86/p2m: drop p2m_access_t parameter from set_mmio_p2m_entry()

2020-02-06 Thread Roger Pau Monné
On Thu, Feb 06, 2020 at 04:20:02PM +0100, Jan Beulich wrote: > Both callers request the host P2M's default access, which can as well be > done inside the function. While touching this anyway, make the "gfn" > parameter type-safe as well. > > Signed-off-by: Jan Beulich Reviewed-by: Roger Pau