Re: [Xen-devel] [PATCH] xen/arm: add warning if memory modules overlap

2019-10-17 Thread Julien Grall
Hi, On 17/10/2019 20:48, Brian Woods wrote: > On Thu, Oct 17, 2019 at 10:20:11AM +0100, Julien Grall wrote: >> Hi, >> >> Sorry for the late answer. >> >> On 11/10/2019 20:07, Brian Woods wrote: >>> Which is why I wanted to put it where it was in the patch. Where the >>> user would see the

Re: [Xen-devel] [PATCH] xen/arm: add warning if memory modules overlap

2019-10-17 Thread Brian Woods
On Thu, Oct 17, 2019 at 10:20:11AM +0100, Julien Grall wrote: > Hi, > > Sorry for the late answer. > > On 11/10/2019 20:07, Brian Woods wrote: > >Which is why I wanted to put it where it was in the patch. Where the > >user would see the warning after the information about the memory > >modules

Re: [Xen-devel] [PATCH] xen/arm: add warning if memory modules overlap

2019-10-17 Thread Julien Grall
Hi, Sorry for the late answer. On 11/10/2019 20:07, Brian Woods wrote: On Fri, Oct 11, 2019 at 07:17:29PM +0100, Julien Grall wrote: This code is also only called at boot where there are bigger time consuming part (such as domheap initialization). So I would be surprised if you see any

Re: [Xen-devel] [PATCH] xen/arm: add warning if memory modules overlap

2019-10-11 Thread Brian Woods
On Fri, Oct 11, 2019 at 07:17:29PM +0100, Julien Grall wrote: > Hi, > > On 10/11/19 7:06 PM, Brian Woods wrote: > >On Fri, Oct 11, 2019 at 05:58:35PM +0100, Julien Grall wrote: > >For that, you'd need to either check the start and end of the added > >module or the start of both. So something

Re: [Xen-devel] [PATCH] xen/arm: add warning if memory modules overlap

2019-10-11 Thread Julien Grall
Hi, On 10/11/19 7:06 PM, Brian Woods wrote: On Fri, Oct 11, 2019 at 05:58:35PM +0100, Julien Grall wrote: For that, you'd need to either check the start and end of the added module or the start of both. So something like: if ( ((mod->start >= start) && (mod->start < (start + size))) ||

Re: [Xen-devel] [PATCH] xen/arm: add warning if memory modules overlap

2019-10-11 Thread Brian Woods
On Fri, Oct 11, 2019 at 05:58:35PM +0100, Julien Grall wrote: > Hi, > > Please at least remove the signature in the e-mail you reply to. The best > would be to trim the e-mail and answer right below the specific paragraph. > > > > >To make sure the module is going to get added, you'd need to do

Re: [Xen-devel] [PATCH] xen/arm: add warning if memory modules overlap

2019-10-11 Thread Julien Grall
Hi, On 10/11/19 5:43 PM, Brian Woods wrote: On Thu, Oct 10, 2019 at 04:39:07PM +0100, Julien Grall wrote: Hi Brian, Thank you for the patch. On 10/9/19 8:47 PM, Brian Woods wrote: It's possible for a misconfigured device tree to cause Xen to crash when there are overlapping addresses in the

Re: [Xen-devel] [PATCH] xen/arm: add warning if memory modules overlap

2019-10-11 Thread Brian Woods
On Thu, Oct 10, 2019 at 04:39:07PM +0100, Julien Grall wrote: > Hi Brian, > > Thank you for the patch. > > On 10/9/19 8:47 PM, Brian Woods wrote: > >It's possible for a misconfigured device tree to cause Xen to crash when > >there are overlapping addresses in the memory modules. Add a warning >

Re: [Xen-devel] [PATCH] xen/arm: add warning if memory modules overlap

2019-10-10 Thread Julien Grall
Hi Brian, Thank you for the patch. On 10/9/19 8:47 PM, Brian Woods wrote: It's possible for a misconfigured device tree to cause Xen to crash when there are overlapping addresses in the memory modules. Add a warning when printing the addresses to let the user know there's a possible issue