Re: [Xen-devel] [PATCH] xen/arm: io: add function swap_mmio_handler()

2019-06-27 Thread chenbaodong
On 6/25/19 16:46, Julien Grall wrote: HiStefano, On 25/06/2019 00:59, Stefano Stabellini wrote: On Mon, 24 Jun 2019, Julien Grall wrote: Hi, On 6/24/19 9:17 PM, Stefano Stabellini wrote: On Mon, 24 Jun 2019, Julien Grall wrote: Hi Stefano, On 24/06/2019 19:27, Stefano Stabellini wrote:

Re: [Xen-devel] [PATCH] xen/arm: io: add function swap_mmio_handler()

2019-06-25 Thread Julien Grall
HiStefano, On 25/06/2019 00:59, Stefano Stabellini wrote: On Mon, 24 Jun 2019, Julien Grall wrote: Hi, On 6/24/19 9:17 PM, Stefano Stabellini wrote: On Mon, 24 Jun 2019, Julien Grall wrote: Hi Stefano, On 24/06/2019 19:27, Stefano Stabellini wrote: On Mon, 24 Jun 2019, Stefano Stabellini

Re: [Xen-devel] [PATCH] xen/arm: io: add function swap_mmio_handler()

2019-06-24 Thread Stefano Stabellini
On Mon, 24 Jun 2019, Julien Grall wrote: > Hi, > > On 6/24/19 9:17 PM, Stefano Stabellini wrote: > > On Mon, 24 Jun 2019, Julien Grall wrote: > > > Hi Stefano, > > > > > > On 24/06/2019 19:27, Stefano Stabellini wrote: > > > > On Mon, 24 Jun 2019, Stefano Stabellini wrote: > > > > > On Thu, 13

Re: [Xen-devel] [PATCH] xen/arm: io: add function swap_mmio_handler()

2019-06-24 Thread Julien Grall
Hi, On 6/24/19 9:17 PM, Stefano Stabellini wrote: On Mon, 24 Jun 2019, Julien Grall wrote: Hi Stefano, On 24/06/2019 19:27, Stefano Stabellini wrote: On Mon, 24 Jun 2019, Stefano Stabellini wrote: On Thu, 13 Jun 2019, chenbaodong wrote: Let me add that if you prefer to document one of the

Re: [Xen-devel] [PATCH] xen/arm: io: add function swap_mmio_handler()

2019-06-24 Thread Stefano Stabellini
On Mon, 24 Jun 2019, Julien Grall wrote: > Hi Stefano, > > On 24/06/2019 19:27, Stefano Stabellini wrote: > > On Mon, 24 Jun 2019, Stefano Stabellini wrote: > >> On Thu, 13 Jun 2019, chenbaodong wrote: > > Let me add that if you prefer to document one of the other interfaces > > listed above in

Re: [Xen-devel] [PATCH] xen/arm: io: add function swap_mmio_handler()

2019-06-24 Thread Julien Grall
Hi Stefano, On 24/06/2019 19:27, Stefano Stabellini wrote: > On Mon, 24 Jun 2019, Stefano Stabellini wrote: >> On Thu, 13 Jun 2019, chenbaodong wrote: > Let me add that if you prefer to document one of the other interfaces > listed above in my email, you are welcome to pick another one. For >

Re: [Xen-devel] [PATCH] xen/arm: io: add function swap_mmio_handler()

2019-06-24 Thread Stefano Stabellini
On Mon, 24 Jun 2019, Stefano Stabellini wrote: > On Thu, 13 Jun 2019, chenbaodong wrote: > > > > But currently i don't understand xen well, only a few weeks experience. > > > > > > We do have small task for newcomers that would improve Xen code base and > > > also allow your to understand more

Re: [Xen-devel] [PATCH] xen/arm: io: add function swap_mmio_handler()

2019-06-24 Thread Stefano Stabellini
On Thu, 13 Jun 2019, chenbaodong wrote: > > > But currently i don't understand xen well, only a few weeks experience. > > > > We do have small task for newcomers that would improve Xen code base and > > also allow your to understand more some part of the code. > > > > If you have a specific area

Re: [Xen-devel] [PATCH] xen/arm: io: add function swap_mmio_handler()

2019-06-12 Thread chenbaodong
On 6/12/19 20:21, Julien Grall wrote: Hi, On 12/06/2019 11:08, chenbaodong wrote: On 6/12/19 17:08, Julien Grall wrote: Hi, On 6/12/19 6:42 AM, Baodong Chen wrote: Swap function can be used when calling sort(). or else, the default swap function generic_swap() is used, which is a little

Re: [Xen-devel] [PATCH] xen/arm: io: add function swap_mmio_handler()

2019-06-12 Thread Julien Grall
Hi, On 12/06/2019 11:08, chenbaodong wrote: On 6/12/19 17:08, Julien Grall wrote: Hi, On 6/12/19 6:42 AM, Baodong Chen wrote: Swap function can be used when calling sort(). or else, the default swap function generic_swap() is used, which is a little inefficient. I am not entirely convince

Re: [Xen-devel] [PATCH] xen/arm: io: add function swap_mmio_handler()

2019-06-12 Thread chenbaodong
On 6/12/19 17:08, Julien Grall wrote: Hi, On 6/12/19 6:42 AM, Baodong Chen wrote: Swap function can be used when calling sort(). or else, the default swap function generic_swap() is used, which is a little inefficient. I am not entirely convince this will be more efficient. mmio_handler

Re: [Xen-devel] [PATCH] xen/arm: io: add function swap_mmio_handler()

2019-06-12 Thread Julien Grall
Hi, On 6/12/19 6:42 AM, Baodong Chen wrote: Swap function can be used when calling sort(). or else, the default swap function generic_swap() is used, which is a little inefficient. I am not entirely convince this will be more efficient. mmio_handler does not fit in 64 bit, so the compiler