Re: [Xen-devel] [PATCH] xen/sched: rework credit2 run-queue allocation

2020-02-20 Thread Dario Faggioli
On Thu, 2020-02-20 at 07:56 +0100, Jürgen Groß wrote: > On 19.02.20 19:37, Dario Faggioli wrote: > > On Wed, 2020-02-19 at 17:52 +0100, Jan Beulich wrote: > > > > > Nevertheless, I'd add a quick comment about that, to make it even > > more > > obvious. :-) > > Do we really need that? > > Calling

Re: [Xen-devel] [PATCH] xen/sched: rework credit2 run-queue allocation

2020-02-19 Thread Jürgen Groß
On 19.02.20 19:37, Dario Faggioli wrote: On Wed, 2020-02-19 at 17:52 +0100, Jan Beulich wrote: On 19.02.2020 17:47, Dario Faggioli wrote: On Thu, 2020-01-23 at 09:55 +0100, Juergen Gross wrote: --- a/xen/common/sched/credit2.c +++ b/xen/common/sched/credit2.c @@ -849,51 +822,71 @@ static inlin

Re: [Xen-devel] [PATCH] xen/sched: rework credit2 run-queue allocation

2020-02-19 Thread Jürgen Groß
On 19.02.20 17:47, Dario Faggioli wrote: On Thu, 2020-01-23 at 09:55 +0100, Juergen Gross wrote: Currently the memory for each run-queue of the credit2 scheduler is allocated at the scheduler's init function: for each cpu in the system a struct csched2_runqueue_data is being allocated, even if t

Re: [Xen-devel] [PATCH] xen/sched: rework credit2 run-queue allocation

2020-02-19 Thread Dario Faggioli
On Wed, 2020-02-19 at 17:52 +0100, Jan Beulich wrote: > On 19.02.2020 17:47, Dario Faggioli wrote: > > On Thu, 2020-01-23 at 09:55 +0100, Juergen Gross wrote: > > > --- a/xen/common/sched/credit2.c > > > +++ b/xen/common/sched/credit2.c > > > @@ -849,51 +822,71 @@ static inline bool same_core(unsig

Re: [Xen-devel] [PATCH] xen/sched: rework credit2 run-queue allocation

2020-02-19 Thread Jan Beulich
On 19.02.2020 17:47, Dario Faggioli wrote: > On Thu, 2020-01-23 at 09:55 +0100, Juergen Gross wrote: >> --- a/xen/common/sched/credit2.c >> +++ b/xen/common/sched/credit2.c >> @@ -849,51 +822,71 @@ static inline bool same_core(unsigned int cpua, >> unsigned int cpub) >> cpu_to_core(cpua

Re: [Xen-devel] [PATCH] xen/sched: rework credit2 run-queue allocation

2020-02-19 Thread Dario Faggioli
On Thu, 2020-01-23 at 09:55 +0100, Juergen Gross wrote: > Currently the memory for each run-queue of the credit2 scheduler is > allocated at the scheduler's init function: for each cpu in the > system > a struct csched2_runqueue_data is being allocated, even if the > current scheduler only handles

Re: [Xen-devel] [PATCH] xen/sched: rework credit2 run-queue allocation

2020-02-06 Thread Jürgen Groß
On 23.01.20 09:55, Juergen Gross wrote: Currently the memory for each run-queue of the credit2 scheduler is allocated at the scheduler's init function: for each cpu in the system a struct csched2_runqueue_data is being allocated, even if the current scheduler only handles one physical cpu or is c