Re: [Xen-devel] [PATCH 02/18] xen/arm: Implement PSCI system suspend call (virtual interface)

2018-11-16 Thread Dario Faggioli
On Thu, 2018-11-15 at 11:38 +, Julien Grall wrote: > On 11/15/18 11:10 AM, Mirela Simonovic wrote: > I don't think we are discussing the same thing. The discussion was > around other vCPUs, not the vCPU calling SYSTEM_SUSPEND. > > Most likely in the future, we would want to allow the

Re: [Xen-devel] [PATCH 02/18] xen/arm: Implement PSCI system suspend call (virtual interface)

2018-11-15 Thread Julien Grall
Hi Mirela, On 11/15/18 11:42 AM, Mirela Simonovic wrote: Hi Julien, On Thu, Nov 15, 2018 at 12:38 PM Julien Grall wrote: Hi, On 11/15/18 11:10 AM, Mirela Simonovic wrote: Hi Julien, On Thu, Nov 15, 2018 at 11:59 AM Julien Grall wrote: Hi Mirela, On 11/15/18 10:33 AM, Mirela Simonovic

Re: [Xen-devel] [PATCH 02/18] xen/arm: Implement PSCI system suspend call (virtual interface)

2018-11-15 Thread Stefano Stabellini
On Thu, 15 Nov 2018, Mirela Simonovic wrote: > Hi Julien, > > On Thu, Nov 15, 2018 at 12:38 PM Julien Grall wrote: > > > > Hi, > > > > On 11/15/18 11:10 AM, Mirela Simonovic wrote: > > > Hi Julien, > > > > > > On Thu, Nov 15, 2018 at 11:59 AM Julien Grall > > > wrote: > > >> > > >> Hi Mirela,

Re: [Xen-devel] [PATCH 02/18] xen/arm: Implement PSCI system suspend call (virtual interface)

2018-11-15 Thread Mirela Simonovic
Hi Julien, On Thu, Nov 15, 2018 at 12:38 PM Julien Grall wrote: > > Hi, > > On 11/15/18 11:10 AM, Mirela Simonovic wrote: > > Hi Julien, > > > > On Thu, Nov 15, 2018 at 11:59 AM Julien Grall wrote: > >> > >> Hi Mirela, > >> > >> On 11/15/18 10:33 AM, Mirela Simonovic wrote: > >>> On Thu, Nov

Re: [Xen-devel] [PATCH 02/18] xen/arm: Implement PSCI system suspend call (virtual interface)

2018-11-15 Thread Julien Grall
Hi, On 11/15/18 11:10 AM, Mirela Simonovic wrote: Hi Julien, On Thu, Nov 15, 2018 at 11:59 AM Julien Grall wrote: Hi Mirela, On 11/15/18 10:33 AM, Mirela Simonovic wrote: On Thu, Nov 15, 2018 at 11:26 AM Andrew Cooper wrote: On 15/11/2018 10:13, Julien Grall wrote: (+ Andre) On

Re: [Xen-devel] [PATCH 02/18] xen/arm: Implement PSCI system suspend call (virtual interface)

2018-11-15 Thread Mirela Simonovic
Hi Julien, On Thu, Nov 15, 2018 at 11:59 AM Julien Grall wrote: > > Hi Mirela, > > On 11/15/18 10:33 AM, Mirela Simonovic wrote: > > On Thu, Nov 15, 2018 at 11:26 AM Andrew Cooper > > wrote: > >> > >> On 15/11/2018 10:13, Julien Grall wrote: > >>> (+ Andre) > >>> > >>> On 11/15/18 12:47 AM,

Re: [Xen-devel] [PATCH 02/18] xen/arm: Implement PSCI system suspend call (virtual interface)

2018-11-15 Thread Julien Grall
Hi Mirela, On 11/15/18 10:33 AM, Mirela Simonovic wrote: On Thu, Nov 15, 2018 at 11:26 AM Andrew Cooper wrote: On 15/11/2018 10:13, Julien Grall wrote: (+ Andre) On 11/15/18 12:47 AM, Andrew Cooper wrote: On 14/11/2018 12:49, Julien Grall wrote: Hi Mirela, On 14/11/2018 12:08, Mirela

Re: [Xen-devel] [PATCH 02/18] xen/arm: Implement PSCI system suspend call (virtual interface)

2018-11-15 Thread Andrew Cooper
On 15/11/2018 10:36, Julien Grall wrote: > Hi Andrew, > > On 11/15/18 10:26 AM, Andrew Cooper wrote: >> On 15/11/2018 10:13, Julien Grall wrote: >>> (+ Andre) >>> >>> On 11/15/18 12:47 AM, Andrew Cooper wrote: On 14/11/2018 12:49, Julien Grall wrote: > Hi Mirela, > > On 14/11/2018

Re: [Xen-devel] [PATCH 02/18] xen/arm: Implement PSCI system suspend call (virtual interface)

2018-11-15 Thread Julien Grall
Hi Andrew, On 11/15/18 10:26 AM, Andrew Cooper wrote: On 15/11/2018 10:13, Julien Grall wrote: (+ Andre) On 11/15/18 12:47 AM, Andrew Cooper wrote: On 14/11/2018 12:49, Julien Grall wrote: Hi Mirela, On 14/11/2018 12:08, Mirela Simonovic wrote: On 11/13/2018 09:32 AM, Andrew Cooper

Re: [Xen-devel] [PATCH 02/18] xen/arm: Implement PSCI system suspend call (virtual interface)

2018-11-15 Thread Julien Grall
Hi Andrew, On 11/15/18 10:26 AM, Andrew Cooper wrote: On 15/11/2018 10:13, Julien Grall wrote: (+ Andre) On 11/15/18 12:47 AM, Andrew Cooper wrote: On 14/11/2018 12:49, Julien Grall wrote: Hi Mirela, On 14/11/2018 12:08, Mirela Simonovic wrote: On 11/13/2018 09:32 AM, Andrew Cooper

Re: [Xen-devel] [PATCH 02/18] xen/arm: Implement PSCI system suspend call (virtual interface)

2018-11-15 Thread Mirela Simonovic
On Thu, Nov 15, 2018 at 11:26 AM Andrew Cooper wrote: > > On 15/11/2018 10:13, Julien Grall wrote: > > (+ Andre) > > > > On 11/15/18 12:47 AM, Andrew Cooper wrote: > >> On 14/11/2018 12:49, Julien Grall wrote: > >>> Hi Mirela, > >>> > >>> On 14/11/2018 12:08, Mirela Simonovic wrote: > >

Re: [Xen-devel] [PATCH 02/18] xen/arm: Implement PSCI system suspend call (virtual interface)

2018-11-15 Thread Andrew Cooper
On 15/11/2018 10:13, Julien Grall wrote: > (+ Andre) > > On 11/15/18 12:47 AM, Andrew Cooper wrote: >> On 14/11/2018 12:49, Julien Grall wrote: >>> Hi Mirela, >>> >>> On 14/11/2018 12:08, Mirela Simonovic wrote: On 11/13/2018 09:32 AM, Andrew Cooper wrote: > On 12/11/2018 19:56,

Re: [Xen-devel] [PATCH 02/18] xen/arm: Implement PSCI system suspend call (virtual interface)

2018-11-15 Thread Julien Grall
(+ Andre) On 11/15/18 12:47 AM, Andrew Cooper wrote: On 14/11/2018 12:49, Julien Grall wrote: Hi Mirela, On 14/11/2018 12:08, Mirela Simonovic wrote: On 11/13/2018 09:32 AM, Andrew Cooper wrote: On 12/11/2018 19:56, Julien Grall wrote: Hi Andrew, On 11/12/18 4:41 PM, Andrew Cooper

Re: [Xen-devel] [PATCH 02/18] xen/arm: Implement PSCI system suspend call (virtual interface)

2018-11-14 Thread Andrew Cooper
On 14/11/2018 12:49, Julien Grall wrote: > Hi Mirela, > > On 14/11/2018 12:08, Mirela Simonovic wrote: >> >> >> On 11/13/2018 09:32 AM, Andrew Cooper wrote: >>> On 12/11/2018 19:56, Julien Grall wrote: Hi Andrew, On 11/12/18 4:41 PM, Andrew Cooper wrote: > On 12/11/18 16:35,

Re: [Xen-devel] [PATCH 02/18] xen/arm: Implement PSCI system suspend call (virtual interface)

2018-11-14 Thread Stefano Stabellini
On Wed, 14 Nov 2018, Julien Grall wrote: > On 13/11/2018 20:39, Stefano Stabellini wrote: > > On Tue, 13 Nov 2018, Julien Grall wrote: > > > > If we mark the domU simply as "paused" it will be difficult to implement > > correctly "xl restore" / "xl trigger s3resume". We should be able to > >

Re: [Xen-devel] [PATCH 02/18] xen/arm: Implement PSCI system suspend call (virtual interface)

2018-11-14 Thread Julien Grall
Hi Mirela, On 14/11/2018 15:36, Mirela Simonovic wrote: On Wed, Nov 14, 2018 at 3:49 PM Julien Grall wrote: On 14/11/2018 13:05, Julien Grall wrote: On 14/11/2018 12:35, Mirela Simonovic wrote: On 11/14/2018 11:45 AM, Julien Grall wrote: Hi, On 13/11/2018 20:39, Stefano Stabellini wrote:

Re: [Xen-devel] [PATCH 02/18] xen/arm: Implement PSCI system suspend call (virtual interface)

2018-11-14 Thread Mirela Simonovic
On Wed, Nov 14, 2018 at 4:36 PM Mirela Simonovic wrote: > > Hi Julien, > > On Wed, Nov 14, 2018 at 3:49 PM Julien Grall wrote: > > > > > > > > On 14/11/2018 13:05, Julien Grall wrote: > > > > > > > > > On 14/11/2018 12:35, Mirela Simonovic wrote: > > >> Hi Julien, > > > > > > Hi, > > > > > >> >

Re: [Xen-devel] [PATCH 02/18] xen/arm: Implement PSCI system suspend call (virtual interface)

2018-11-14 Thread Mirela Simonovic
Hi Julien, On Wed, Nov 14, 2018 at 3:49 PM Julien Grall wrote: > > > > On 14/11/2018 13:05, Julien Grall wrote: > > > > > > On 14/11/2018 12:35, Mirela Simonovic wrote: > >> Hi Julien, > > > > Hi, > > > >> > >> On 11/14/2018 11:45 AM, Julien Grall wrote: > >>> Hi, > >>> > >>> On 13/11/2018

Re: [Xen-devel] [PATCH 02/18] xen/arm: Implement PSCI system suspend call (virtual interface)

2018-11-14 Thread Julien Grall
On 14/11/2018 13:05, Julien Grall wrote: On 14/11/2018 12:35, Mirela Simonovic wrote: Hi Julien, Hi, On 11/14/2018 11:45 AM, Julien Grall wrote: Hi, On 13/11/2018 20:39, Stefano Stabellini wrote: On Mon, 12 Nov 2018, Julien Grall wrote: However, what is the issue with saving all

Re: [Xen-devel] [PATCH 02/18] xen/arm: Implement PSCI system suspend call (virtual interface)

2018-11-14 Thread Julien Grall
On 13/11/2018 20:39, Stefano Stabellini wrote: On Tue, 13 Nov 2018, Julien Grall wrote: If we mark the domU simply as "paused" it will be difficult to implement correctly "xl restore" / "xl trigger s3resume". We should be able to distinguish a domain which is simply not running or paused (as

Re: [Xen-devel] [PATCH 02/18] xen/arm: Implement PSCI system suspend call (virtual interface)

2018-11-14 Thread Julien Grall
On 14/11/2018 12:35, Mirela Simonovic wrote: Hi Julien, Hi, On 11/14/2018 11:45 AM, Julien Grall wrote: Hi, On 13/11/2018 20:39, Stefano Stabellini wrote: On Mon, 12 Nov 2018, Julien Grall wrote: However, what is the issue with saving all the registers here? We need to save

Re: [Xen-devel] [PATCH 02/18] xen/arm: Implement PSCI system suspend call (virtual interface)

2018-11-14 Thread Julien Grall
Hi Mirela, On 14/11/2018 12:08, Mirela Simonovic wrote: On 11/13/2018 09:32 AM, Andrew Cooper wrote: On 12/11/2018 19:56, Julien Grall wrote: Hi Andrew, On 11/12/18 4:41 PM, Andrew Cooper wrote: On 12/11/18 16:35, Mirela Simonovic wrote: diff --git a/xen/arch/arm/domain.c

Re: [Xen-devel] [PATCH 02/18] xen/arm: Implement PSCI system suspend call (virtual interface)

2018-11-14 Thread Mirela Simonovic
On 11/13/2018 04:09 PM, Julien Grall wrote: On 13/11/2018 10:23, Julien Grall wrote: Hi, On 12/11/2018 11:30, Mirela Simonovic wrote: +/* + * This function sets the context of current VCPU to the state which is expected + * by the guest on resume. The expected VCPU state is: + * 1) pc

Re: [Xen-devel] [PATCH 02/18] xen/arm: Implement PSCI system suspend call (virtual interface)

2018-11-14 Thread Mirela Simonovic
Hi Julien, On 11/14/2018 11:45 AM, Julien Grall wrote: Hi, On 13/11/2018 20:39, Stefano Stabellini wrote: On Mon, 12 Nov 2018, Julien Grall wrote: However, what is the issue with saving all the registers here? We need to save arguments that are provided by a guest with system suspend

Re: [Xen-devel] [PATCH 02/18] xen/arm: Implement PSCI system suspend call (virtual interface)

2018-11-14 Thread Mirela Simonovic
On 11/13/2018 09:32 AM, Andrew Cooper wrote: On 12/11/2018 19:56, Julien Grall wrote: Hi Andrew, On 11/12/18 4:41 PM, Andrew Cooper wrote: On 12/11/18 16:35, Mirela Simonovic wrote: diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c index e594b48d81..7f8105465c 100644 ---

Re: [Xen-devel] [PATCH 02/18] xen/arm: Implement PSCI system suspend call (virtual interface)

2018-11-14 Thread Julien Grall
Hi, On 13/11/2018 20:39, Stefano Stabellini wrote: On Mon, 12 Nov 2018, Julien Grall wrote: However, what is the issue with saving all the registers here? We need to save arguments that are provided by a guest with system suspend PSCI call. These arguments are the entry point that needs to

Re: [Xen-devel] [PATCH 02/18] xen/arm: Implement PSCI system suspend call (virtual interface)

2018-11-13 Thread Stefano Stabellini
On Tue, 13 Nov 2018, Julien Grall wrote: > > > > > > diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c > > > > > > index e594b48d81..7f8105465c 100644 > > > > > > --- a/xen/arch/arm/domain.c > > > > > > +++ b/xen/arch/arm/domain.c > > > > > > @@ -97,6 +97,11 @@ static void

Re: [Xen-devel] [PATCH 02/18] xen/arm: Implement PSCI system suspend call (virtual interface)

2018-11-13 Thread Stefano Stabellini
On Mon, 12 Nov 2018, Julien Grall wrote: > > > However, what is the issue with saving all the registers here? > > > > > > > We need to save arguments that are provided by a guest with system > > suspend PSCI call. These arguments are the entry point that needs to > > be saved in program counter

Re: [Xen-devel] [PATCH 02/18] xen/arm: Implement PSCI system suspend call (virtual interface)

2018-11-13 Thread Julien Grall
On 13/11/2018 10:23, Julien Grall wrote: Hi, On 12/11/2018 11:30, Mirela Simonovic wrote: +/* + * This function sets the context of current VCPU to the state which is expected + * by the guest on resume. The expected VCPU state is: + * 1) pc to contain resume entry point (1st argument of

Re: [Xen-devel] [PATCH 02/18] xen/arm: Implement PSCI system suspend call (virtual interface)

2018-11-13 Thread Julien Grall
Hi, On 12/11/2018 11:30, Mirela Simonovic wrote: +/* + * This function sets the context of current VCPU to the state which is expected + * by the guest on resume. The expected VCPU state is: + * 1) pc to contain resume entry point (1st argument of PSCI SYSTEM_SUSPEND) + * 2) r0/x0 to contain

Re: [Xen-devel] [PATCH 02/18] xen/arm: Implement PSCI system suspend call (virtual interface)

2018-11-13 Thread Julien Grall
Hi Stefano, On 13/11/2018 01:53, Stefano Stabellini wrote: On Mon, 12 Nov 2018, Andrew Cooper wrote: On 12/11/18 16:35, Mirela Simonovic wrote: Hi Julien, Thanks for your feedback, I'll need to answer in iterations. On Mon, Nov 12, 2018 at 4:27 PM Julien Grall wrote: Hi Mirela, On

Re: [Xen-devel] [PATCH 02/18] xen/arm: Implement PSCI system suspend call (virtual interface)

2018-11-13 Thread Andrew Cooper
On 12/11/2018 19:56, Julien Grall wrote: > Hi Andrew, > > On 11/12/18 4:41 PM, Andrew Cooper wrote: >> On 12/11/18 16:35, Mirela Simonovic wrote: > diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c > index e594b48d81..7f8105465c 100644 > --- a/xen/arch/arm/domain.c > +++

Re: [Xen-devel] [PATCH 02/18] xen/arm: Implement PSCI system suspend call (virtual interface)

2018-11-12 Thread Stefano Stabellini
On Mon, 12 Nov 2018, Andrew Cooper wrote: > On 12/11/18 16:35, Mirela Simonovic wrote: > > Hi Julien, > > > > Thanks for your feedback, I'll need to answer in iterations. > > > > On Mon, Nov 12, 2018 at 4:27 PM Julien Grall wrote: > >> Hi Mirela, > >> > >> On 11/12/18 11:30 AM, Mirela Simonovic

Re: [Xen-devel] [PATCH 02/18] xen/arm: Implement PSCI system suspend call (virtual interface)

2018-11-12 Thread Julien Grall
On 11/12/18 4:35 PM, Mirela Simonovic wrote: Hi Julien, Thanks for your feedback, I'll need to answer in iterations. On Mon, Nov 12, 2018 at 4:27 PM Julien Grall wrote: Hi Mirela, On 11/12/18 11:30 AM, Mirela Simonovic wrote: The implementation consists of: -Adding PSCI system suspend

Re: [Xen-devel] [PATCH 02/18] xen/arm: Implement PSCI system suspend call (virtual interface)

2018-11-12 Thread Julien Grall
Hi Andrew, On 11/12/18 4:41 PM, Andrew Cooper wrote: On 12/11/18 16:35, Mirela Simonovic wrote: diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c index e594b48d81..7f8105465c 100644 --- a/xen/arch/arm/domain.c +++ b/xen/arch/arm/domain.c @@ -97,6 +97,11 @@ static void

Re: [Xen-devel] [PATCH 02/18] xen/arm: Implement PSCI system suspend call (virtual interface)

2018-11-12 Thread Andrew Cooper
On 12/11/18 16:35, Mirela Simonovic wrote: > Hi Julien, > > Thanks for your feedback, I'll need to answer in iterations. > > On Mon, Nov 12, 2018 at 4:27 PM Julien Grall wrote: >> Hi Mirela, >> >> On 11/12/18 11:30 AM, Mirela Simonovic wrote: >>> The implementation consists of: >>> -Adding PSCI

Re: [Xen-devel] [PATCH 02/18] xen/arm: Implement PSCI system suspend call (virtual interface)

2018-11-12 Thread Mirela Simonovic
Hi Julien, Thanks for your feedback, I'll need to answer in iterations. On Mon, Nov 12, 2018 at 4:27 PM Julien Grall wrote: > > Hi Mirela, > > On 11/12/18 11:30 AM, Mirela Simonovic wrote: > > The implementation consists of: > > -Adding PSCI system suspend call as new PSCI function > >

Re: [Xen-devel] [PATCH 02/18] xen/arm: Implement PSCI system suspend call (virtual interface)

2018-11-12 Thread Julien Grall
Hi Mirela, On 11/12/18 11:30 AM, Mirela Simonovic wrote: The implementation consists of: -Adding PSCI system suspend call as new PSCI function -Trapping PSCI system_suspend HVC -Implementing PSCI system suspend call (virtual interface that allows guests to suspend themselves) The PSCI system

Re: [Xen-devel] [PATCH 02/18] xen/arm: Implement PSCI system suspend call (virtual interface)

2018-11-12 Thread Jan Beulich
>>> On 12.11.18 at 12:50, wrote: > What? Please don't top post. > On Mon, Nov 12, 2018 at 12:42 PM Jan Beulich wrote: > >> >>> On 12.11.18 at 12:30, wrote: >> > --- a/xen/include/xen/sched.h >> > +++ b/xen/include/xen/sched.h >> > @@ -24,6 +24,7 @@ >> > #include >> > #include >> >

Re: [Xen-devel] [PATCH 02/18] xen/arm: Implement PSCI system suspend call (virtual interface)

2018-11-12 Thread Mirela Simonovic
What? On Mon, Nov 12, 2018 at 12:42 PM Jan Beulich wrote: > >>> On 12.11.18 at 12:30, wrote: > > --- a/xen/include/xen/sched.h > > +++ b/xen/include/xen/sched.h > > @@ -24,6 +24,7 @@ > > #include > > #include > > #include > > +#include > > #include > > #include > > #include > >

Re: [Xen-devel] [PATCH 02/18] xen/arm: Implement PSCI system suspend call (virtual interface)

2018-11-12 Thread Jan Beulich
>>> On 12.11.18 at 12:30, wrote: > --- a/xen/include/xen/sched.h > +++ b/xen/include/xen/sched.h > @@ -24,6 +24,7 @@ > #include > #include > #include > +#include > #include > #include > #include Why? Jan. ___ Xen-devel mailing list