Re: [Xen-devel] [PATCH 5/6] iommu: tidy up iommu_us_hap_pt() and need_iommu_pt_sync() macros

2019-08-27 Thread Jan Beulich
On 14.08.2019 12:13, Paul Durrant wrote: From: Jan Beulich Sent: 07 August 2019 11:41 On 30.07.2019 15:44, Paul Durrant wrote: Thes macros really ought to live in the common xen/iommu.h header rather then being distributed amongst architecture specific iommu headers and xen/sched.h. This

Re: [Xen-devel] [PATCH 5/6] iommu: tidy up iommu_us_hap_pt() and need_iommu_pt_sync() macros

2019-08-14 Thread Paul Durrant
> -Original Message- [snip] > >>> +/* Are we using the domain P2M table as its IOMMU pagetable? */ > >>> +#define iommu_use_hap_pt(d) \ > >>> +(hap_enabled(d) && is_iommu_enabled(d) && iommu_hap_pt_share) > >> > >> Does this build for Arm, seeing that there's no

Re: [Xen-devel] [PATCH 5/6] iommu: tidy up iommu_us_hap_pt() and need_iommu_pt_sync() macros

2019-08-14 Thread Julien Grall
Hi, On 14/08/2019 12:11, Paul Durrant wrote: -Original Message- From: Julien Grall Sent: 14 August 2019 11:45 To: Paul Durrant ; 'Jan Beulich' Cc: xen-devel@lists.xenproject.org; Andrew Cooper ; Roger Pau Monne ; Volodymyr Babchuk ; George Dunlap ; Ian Jackson ; Stefano Stabellini

Re: [Xen-devel] [PATCH 5/6] iommu: tidy up iommu_us_hap_pt() and need_iommu_pt_sync() macros

2019-08-14 Thread Paul Durrant
> -Original Message- > From: Julien Grall > Sent: 14 August 2019 11:45 > To: Paul Durrant ; 'Jan Beulich' > Cc: xen-devel@lists.xenproject.org; Andrew Cooper > ; Roger Pau Monne > ; Volodymyr Babchuk ; > George Dunlap > ; Ian Jackson ; Stefano > Stabellini > ; Konrad Rzeszutek Wilk ;

Re: [Xen-devel] [PATCH 5/6] iommu: tidy up iommu_us_hap_pt() and need_iommu_pt_sync() macros

2019-08-14 Thread Julien Grall
Hi, On 14/08/2019 11:27, Paul Durrant wrote: -Original Message- From: Julien Grall Sent: 14 August 2019 11:21 To: Paul Durrant ; 'Jan Beulich' Cc: xen-devel@lists.xenproject.org; Andrew Cooper ; Roger Pau Monne ; Volodymyr Babchuk ; George Dunlap ; Ian Jackson ; Stefano Stabellini

Re: [Xen-devel] [PATCH 5/6] iommu: tidy up iommu_us_hap_pt() and need_iommu_pt_sync() macros

2019-08-14 Thread Paul Durrant
> -Original Message- > From: Julien Grall > Sent: 14 August 2019 11:21 > To: Paul Durrant ; 'Jan Beulich' > Cc: xen-devel@lists.xenproject.org; Andrew Cooper > ; Roger Pau Monne > ; Volodymyr Babchuk ; > George Dunlap > ; Ian Jackson ; Stefano > Stabellini > ; Konrad Rzeszutek Wilk ;

Re: [Xen-devel] [PATCH 5/6] iommu: tidy up iommu_us_hap_pt() and need_iommu_pt_sync() macros

2019-08-14 Thread Julien Grall
Hi Paul, On 14/08/2019 11:13, Paul Durrant wrote: --- a/xen/include/xen/iommu.h +++ b/xen/include/xen/iommu.h @@ -268,6 +268,13 @@ struct domain_iommu { #define iommu_set_feature(d, f) set_bit(f, dom_iommu(d)->features) #define iommu_clear_feature(d, f) clear_bit(f,

Re: [Xen-devel] [PATCH 5/6] iommu: tidy up iommu_us_hap_pt() and need_iommu_pt_sync() macros

2019-08-14 Thread Paul Durrant
> -Original Message- > From: Jan Beulich > Sent: 07 August 2019 11:41 > To: Paul Durrant > Cc: xen-devel@lists.xenproject.org; Julien Grall ; > Andrew Cooper > ; Roger Pau Monne ; > Volodymyr Babchuk > ; George Dunlap ; Ian > Jackson > ; Stefano Stabellini ; Konrad > Rzeszutek Wilk >

Re: [Xen-devel] [PATCH 5/6] iommu: tidy up iommu_us_hap_pt() and need_iommu_pt_sync() macros

2019-08-07 Thread Jan Beulich
On 30.07.2019 15:44, Paul Durrant wrote: Thes macros really ought to live in the common xen/iommu.h header rather then being distributed amongst architecture specific iommu headers and xen/sched.h. This patch moves them there. NOTE: Disabling 'sharept' in the command line iommu options should