Re: [Xen-devel] [PATCH for-4.13] x86/vmx: always sync PIR to IRR before vmentry

2019-11-27 Thread Roger Pau Monné
On Wed, Nov 27, 2019 at 12:34:09PM +0100, Jan Beulich wrote: > On 27.11.2019 12:29, Roger Pau Monné wrote: > > On Wed, Nov 27, 2019 at 12:16:37PM +0100, Jan Beulich wrote: > >> On 27.11.2019 12:03, Roger Pau Monné wrote: > >>> On Wed, Nov 27, 2019 at 02:07:16AM +, Tian, Kevin wrote: >

Re: [Xen-devel] [PATCH for-4.13] x86/vmx: always sync PIR to IRR before vmentry

2019-11-27 Thread Jan Beulich
On 27.11.2019 12:29, Roger Pau Monné wrote: > On Wed, Nov 27, 2019 at 12:16:37PM +0100, Jan Beulich wrote: >> On 27.11.2019 12:03, Roger Pau Monné wrote: >>> On Wed, Nov 27, 2019 at 02:07:16AM +, Tian, Kevin wrote: Then what's the difference from original logic? >>> >>> The original

Re: [Xen-devel] [PATCH for-4.13] x86/vmx: always sync PIR to IRR before vmentry

2019-11-27 Thread Roger Pau Monné
On Wed, Nov 27, 2019 at 12:16:37PM +0100, Jan Beulich wrote: > On 27.11.2019 12:03, Roger Pau Monné wrote: > > On Wed, Nov 27, 2019 at 02:07:16AM +, Tian, Kevin wrote: > >> Then what's the difference from original logic? > > > > The original logic is: > > > > if ( running && (in_irq() || (v

Re: [Xen-devel] [PATCH for-4.13] x86/vmx: always sync PIR to IRR before vmentry

2019-11-27 Thread Jan Beulich
On 27.11.2019 12:03, Roger Pau Monné wrote: > On Wed, Nov 27, 2019 at 02:07:16AM +, Tian, Kevin wrote: >> Then what's the difference from original logic? > > The original logic is: > > if ( running && (in_irq() || (v != current)) ) > { > unsigned int cpu = v->processor; > >

Re: [Xen-devel] [PATCH for-4.13] x86/vmx: always sync PIR to IRR before vmentry

2019-11-27 Thread Roger Pau Monné
On Wed, Nov 27, 2019 at 02:07:16AM +, Tian, Kevin wrote: > > From: Roger Pau Monné > > Sent: Monday, November 18, 2019 10:56 PM > > > > On Mon, Nov 18, 2019 at 03:19:50PM +0100, Jan Beulich wrote: > > > On 18.11.2019 15:03, Roger Pau Monné wrote: > > > > On Mon, Nov 18, 2019 at 01:26:46PM

Re: [Xen-devel] [PATCH for-4.13] x86/vmx: always sync PIR to IRR before vmentry

2019-11-26 Thread Tian, Kevin
> From: Roger Pau Monné > Sent: Monday, November 18, 2019 10:56 PM > > On Mon, Nov 18, 2019 at 03:19:50PM +0100, Jan Beulich wrote: > > On 18.11.2019 15:03, Roger Pau Monné wrote: > > > On Mon, Nov 18, 2019 at 01:26:46PM +0100, Jan Beulich wrote: > > >> On 18.11.2019 11:16, Roger Pau Monne

Re: [Xen-devel] [PATCH for-4.13] x86/vmx: always sync PIR to IRR before vmentry

2019-11-26 Thread Tian, Kevin
> From: Roger Pau Monné > Sent: Thursday, November 21, 2019 5:26 PM > > On Mon, Nov 18, 2019 at 05:00:29PM +0100, Jan Beulich wrote: > > On 18.11.2019 15:20, Roger Pau Monné wrote: > > > On Mon, Nov 18, 2019 at 03:00:00PM +0100, Jan Beulich wrote: > > >> On 18.11.2019 14:46, Roger Pau Monné

Re: [Xen-devel] [PATCH for-4.13] x86/vmx: always sync PIR to IRR before vmentry

2019-11-24 Thread Tian, Kevin
> From: Roger Pau Monné [mailto:roger@citrix.com] > Sent: Thursday, November 21, 2019 5:26 PM > > On Mon, Nov 18, 2019 at 05:00:29PM +0100, Jan Beulich wrote: > > On 18.11.2019 15:20, Roger Pau Monné wrote: > > > On Mon, Nov 18, 2019 at 03:00:00PM +0100, Jan Beulich wrote: > > >> On

Re: [Xen-devel] [PATCH for-4.13] x86/vmx: always sync PIR to IRR before vmentry

2019-11-21 Thread Roger Pau Monné
On Mon, Nov 18, 2019 at 05:00:29PM +0100, Jan Beulich wrote: > On 18.11.2019 15:20, Roger Pau Monné wrote: > > On Mon, Nov 18, 2019 at 03:00:00PM +0100, Jan Beulich wrote: > >> On 18.11.2019 14:46, Roger Pau Monné wrote: > >>> On Mon, Nov 18, 2019 at 01:01:58PM +0100, Jan Beulich wrote: >

Re: [Xen-devel] [PATCH for-4.13] x86/vmx: always sync PIR to IRR before vmentry

2019-11-18 Thread Jan Beulich
On 18.11.2019 15:55, Roger Pau Monné wrote: > On Mon, Nov 18, 2019 at 03:19:50PM +0100, Jan Beulich wrote: >> On 18.11.2019 15:03, Roger Pau Monné wrote: >>> On Mon, Nov 18, 2019 at 01:26:46PM +0100, Jan Beulich wrote: On 18.11.2019 11:16, Roger Pau Monne wrote: > @@ -1954,48 +1952,28

Re: [Xen-devel] [PATCH for-4.13] x86/vmx: always sync PIR to IRR before vmentry

2019-11-18 Thread Jan Beulich
On 18.11.2019 15:20, Roger Pau Monné wrote: > On Mon, Nov 18, 2019 at 03:00:00PM +0100, Jan Beulich wrote: >> On 18.11.2019 14:46, Roger Pau Monné wrote: >>> On Mon, Nov 18, 2019 at 01:01:58PM +0100, Jan Beulich wrote: On 18.11.2019 11:16, Roger Pau Monne wrote: > When using posted

Re: [Xen-devel] [PATCH for-4.13] x86/vmx: always sync PIR to IRR before vmentry

2019-11-18 Thread Roger Pau Monné
On Mon, Nov 18, 2019 at 03:19:50PM +0100, Jan Beulich wrote: > On 18.11.2019 15:03, Roger Pau Monné wrote: > > On Mon, Nov 18, 2019 at 01:26:46PM +0100, Jan Beulich wrote: > >> On 18.11.2019 11:16, Roger Pau Monne wrote: > >>> @@ -1954,48 +1952,28 @@ static void

Re: [Xen-devel] [PATCH for-4.13] x86/vmx: always sync PIR to IRR before vmentry

2019-11-18 Thread Roger Pau Monné
On Mon, Nov 18, 2019 at 03:00:00PM +0100, Jan Beulich wrote: > On 18.11.2019 14:46, Roger Pau Monné wrote: > > On Mon, Nov 18, 2019 at 01:01:58PM +0100, Jan Beulich wrote: > >> On 18.11.2019 11:16, Roger Pau Monne wrote: > >>> When using posted interrupts on Intel hardware it's possible that the

Re: [Xen-devel] [PATCH for-4.13] x86/vmx: always sync PIR to IRR before vmentry

2019-11-18 Thread Jan Beulich
On 18.11.2019 15:03, Roger Pau Monné wrote: > On Mon, Nov 18, 2019 at 01:26:46PM +0100, Jan Beulich wrote: >> On 18.11.2019 11:16, Roger Pau Monne wrote: >>> @@ -1954,48 +1952,28 @@ static void __vmx_deliver_posted_interrupt(struct >>> vcpu *v) >>> * 2. The target vCPU is the current vCPU

Re: [Xen-devel] [PATCH for-4.13] x86/vmx: always sync PIR to IRR before vmentry

2019-11-18 Thread Roger Pau Monné
On Mon, Nov 18, 2019 at 01:26:46PM +0100, Jan Beulich wrote: > On 18.11.2019 11:16, Roger Pau Monne wrote: > > @@ -1954,48 +1952,28 @@ static void __vmx_deliver_posted_interrupt(struct > > vcpu *v) > > * 2. The target vCPU is the current vCPU and we're in non-interrupt > > * context.

Re: [Xen-devel] [PATCH for-4.13] x86/vmx: always sync PIR to IRR before vmentry

2019-11-18 Thread Jan Beulich
On 18.11.2019 14:46, Roger Pau Monné wrote: > On Mon, Nov 18, 2019 at 01:01:58PM +0100, Jan Beulich wrote: >> On 18.11.2019 11:16, Roger Pau Monne wrote: >>> When using posted interrupts on Intel hardware it's possible that the >>> vCPU resumes execution with a stale local APIC IRR register

Re: [Xen-devel] [PATCH for-4.13] x86/vmx: always sync PIR to IRR before vmentry

2019-11-18 Thread Roger Pau Monné
On Mon, Nov 18, 2019 at 01:01:58PM +0100, Jan Beulich wrote: > On 18.11.2019 11:16, Roger Pau Monne wrote: > > When using posted interrupts on Intel hardware it's possible that the > > vCPU resumes execution with a stale local APIC IRR register because > > depending on the interrupts to be

Re: [Xen-devel] [PATCH for-4.13] x86/vmx: always sync PIR to IRR before vmentry

2019-11-18 Thread Jan Beulich
On 18.11.2019 11:16, Roger Pau Monne wrote: > @@ -1954,48 +1952,28 @@ static void __vmx_deliver_posted_interrupt(struct > vcpu *v) > * 2. The target vCPU is the current vCPU and we're in non-interrupt > * context. > */ > -if ( running && (in_irq() || (v != current)) ) > -

Re: [Xen-devel] [PATCH for-4.13] x86/vmx: always sync PIR to IRR before vmentry

2019-11-18 Thread Jan Beulich
On 18.11.2019 11:16, Roger Pau Monne wrote: > When using posted interrupts on Intel hardware it's possible that the > vCPU resumes execution with a stale local APIC IRR register because > depending on the interrupts to be injected vlapic_has_pending_irq > might not be called, and thus PIR won't be