On Mon, Apr 29, 2019 at 10:29 AM George Dunlap wrote:
>
> On 4/29/19 5:26 PM, Tamas K Lengyel wrote:
> > On Mon, Apr 29, 2019 at 10:14 AM Jan Beulich wrote:
> >>
> > On 29.04.19 at 18:05, wrote:
> >>> On Mon, Apr 29, 2019 at 9:52 AM George Dunlap
> >>> wrote:
> I haven't re-grokked
On 4/29/19 5:26 PM, Tamas K Lengyel wrote:
> On Mon, Apr 29, 2019 at 10:14 AM Jan Beulich wrote:
>>
> On 29.04.19 at 18:05, wrote:
>>> On Mon, Apr 29, 2019 at 9:52 AM George Dunlap
>>> wrote:
I haven't re-grokked the code here, but assuming I was correct 2 weeks
ago, if you have
On Mon, Apr 29, 2019 at 10:14 AM Jan Beulich wrote:
>
> >>> On 29.04.19 at 18:05, wrote:
> > On Mon, Apr 29, 2019 at 9:52 AM George Dunlap
> > wrote:
> >> I haven't re-grokked the code here, but assuming I was correct 2 weeks
> >> ago, if you have the BUG_ON() there, you can get rid of the
On 4/29/19 5:14 PM, Jan Beulich wrote:
On 29.04.19 at 18:05, wrote:
>> On Mon, Apr 29, 2019 at 9:52 AM George Dunlap
>> wrote:
>>> I haven't re-grokked the code here, but assuming I was correct 2 weeks
>>> ago, if you have the BUG_ON() there, you can get rid of the extra
>>> references.
>>
>>> On 29.04.19 at 18:05, wrote:
> On Mon, Apr 29, 2019 at 9:52 AM George Dunlap
> wrote:
>> I haven't re-grokked the code here, but assuming I was correct 2 weeks
>> ago, if you have the BUG_ON() there, you can get rid of the extra
>> references.
>
> Sure, but again, the overhead of having
On Mon, Apr 29, 2019 at 9:52 AM George Dunlap wrote:
>
> On 4/29/19 4:41 PM, Tamas K Lengyel wrote:
> > On Mon, Apr 29, 2019 at 9:01 AM Jan Beulich wrote:
> >>
> > On 26.04.19 at 19:21, wrote:
> >>> @@ -999,6 +996,10 @@ static int share_pages(struct domain *sd, gfn_t
> >>> sgfn,
On Mon, Apr 29, 2019 at 9:44 AM George Dunlap wrote:
>
> On 4/26/19 6:21 PM, Tamas K Lengyel wrote:
> > Calling _put_page_type while also holding the page_lock
> > for that page can cause a deadlock.
>
> I can't immediately see what the mem_sharing_page_[un]lock() functions
> are meant to be
On 4/29/19 4:41 PM, Tamas K Lengyel wrote:
> On Mon, Apr 29, 2019 at 9:01 AM Jan Beulich wrote:
>>
> On 26.04.19 at 19:21, wrote:
>>> @@ -999,6 +996,10 @@ static int share_pages(struct domain *sd, gfn_t sgfn,
>>> shr_handle_t sh,
>>> mem_sharing_page_unlock(secondpg);
>>>
On 4/26/19 6:21 PM, Tamas K Lengyel wrote:
> Calling _put_page_type while also holding the page_lock
> for that page can cause a deadlock.
I can't immediately see what the mem_sharing_page_[un]lock() functions
are meant to be protecting against. Is there a comment anywhere
describing what
On Mon, Apr 29, 2019 at 9:01 AM Jan Beulich wrote:
>
> >>> On 26.04.19 at 19:21, wrote:
> > @@ -999,6 +996,10 @@ static int share_pages(struct domain *sd, gfn_t sgfn,
> > shr_handle_t sh,
> > mem_sharing_page_unlock(secondpg);
> > mem_sharing_page_unlock(firstpg);
> >
> > +
On Mon, Apr 29, 2019 at 8:54 AM George Dunlap wrote:
>
> On 4/29/19 3:49 PM, Andrew Cooper wrote:
> > On 29/04/2019 15:46, George Dunlap wrote:
> >> On 4/29/19 3:32 PM, George Dunlap wrote:
> >>> On 4/26/19 6:21 PM, Tamas K Lengyel wrote:
> Calling _put_page_type while also holding the
>>> On 26.04.19 at 19:21, wrote:
> @@ -999,6 +996,10 @@ static int share_pages(struct domain *sd, gfn_t sgfn,
> shr_handle_t sh,
> mem_sharing_page_unlock(secondpg);
> mem_sharing_page_unlock(firstpg);
>
> +BUG_ON(!put_count);
> +while ( put_count-- )
> +
On 29/04/2019 15:46, George Dunlap wrote:
> On 4/29/19 3:32 PM, George Dunlap wrote:
>> On 4/26/19 6:21 PM, Tamas K Lengyel wrote:
>>> Calling _put_page_type while also holding the page_lock
>>> for that page can cause a deadlock.
>>>
>>> Signed-off-by: Tamas K Lengyel
>>> Cc: Jan Beulich
>>>
On 4/29/19 3:49 PM, Andrew Cooper wrote:
> On 29/04/2019 15:46, George Dunlap wrote:
>> On 4/29/19 3:32 PM, George Dunlap wrote:
>>> On 4/26/19 6:21 PM, Tamas K Lengyel wrote:
Calling _put_page_type while also holding the page_lock
for that page can cause a deadlock.
On 4/29/19 3:32 PM, George Dunlap wrote:
> On 4/26/19 6:21 PM, Tamas K Lengyel wrote:
>> Calling _put_page_type while also holding the page_lock
>> for that page can cause a deadlock.
>>
>> Signed-off-by: Tamas K Lengyel
>> Cc: Jan Beulich
>> Cc: Andrew Cooper
>> Cc: George Dunlap
>> Cc: Wei
On 4/26/19 6:21 PM, Tamas K Lengyel wrote:
> Calling _put_page_type while also holding the page_lock
> for that page can cause a deadlock.
>
> Signed-off-by: Tamas K Lengyel
> Cc: Jan Beulich
> Cc: Andrew Cooper
> Cc: George Dunlap
> Cc: Wei Liu
> Cc: Roger Pau Monne
> ---
> v3: simplified
16 matches
Mail list logo
