Re: [Xen-devel] [PATCH v3 3/3] x86 / vmx: use a 'normal' domheap page for APIC_DEFAULT_PHYS_BASE

2020-01-24 Thread Durrant, Paul
> -Original Message- > From: George Dunlap [mailto:george.dun...@citrix.com] > Sent: 23 January 2020 14:46 > To: Durrant, Paul ; xen-devel@lists.xenproject.org > Cc: Jan Beulich ; Andrew Cooper > ; Wei Liu ; Roger Pau Monné > ; George Dunlap ; Ian > Jackson ; Julien Grall ; Konrad >

Re: [Xen-devel] [PATCH v3 3/3] x86 / vmx: use a 'normal' domheap page for APIC_DEFAULT_PHYS_BASE

2020-01-23 Thread Jan Beulich
On 23.01.2020 16:56, Durrant, Paul wrote: >> From: Jan Beulich >> Sent: 23 January 2020 15:32 >> >> On 23.01.2020 15:03, Paul Durrant wrote: >>> vmx_alloc_vlapic_mapping() currently contains some very odd looking code >>> that allocates a MEMF_no_owner domheap page and then shares with the >>

Re: [Xen-devel] [PATCH v3 3/3] x86 / vmx: use a 'normal' domheap page for APIC_DEFAULT_PHYS_BASE

2020-01-23 Thread Durrant, Paul
> -Original Message- > From: Jan Beulich > Sent: 23 January 2020 15:32 > To: Durrant, Paul > Cc: xen-devel@lists.xenproject.org; Andrew Cooper > ; Wei Liu ; Roger Pau Monné > ; George Dunlap ; Ian > Jackson ; Julien Grall ; Konrad > Rzeszutek Wilk ; Stefano Stabellini > ; Jun Nakajima ;

Re: [Xen-devel] [PATCH v3 3/3] x86 / vmx: use a 'normal' domheap page for APIC_DEFAULT_PHYS_BASE

2020-01-23 Thread George Dunlap
On 1/23/20 3:46 PM, Durrant, Paul wrote: >> -Original Message- >> From: Julien Grall >> Sent: 23 January 2020 15:26 >> To: Durrant, Paul ; xen-devel@lists.xenproject.org >> Cc: Jan Beulich ; Andrew Cooper >> ; Wei Liu ; Roger Pau Monné >> ; George Dunlap ; Ian >> Jackson ; Konrad

Re: [Xen-devel] [PATCH v3 3/3] x86 / vmx: use a 'normal' domheap page for APIC_DEFAULT_PHYS_BASE

2020-01-23 Thread Julien Grall
On 23/01/2020 15:46, Durrant, Paul wrote: -Original Message- From: Julien Grall Sent: 23 January 2020 15:26 To: Durrant, Paul ; xen-devel@lists.xenproject.org Cc: Jan Beulich ; Andrew Cooper ; Wei Liu ; Roger Pau Monné ; George Dunlap ; Ian Jackson ; Konrad Rzeszutek Wilk ; Stefano

Re: [Xen-devel] [PATCH v3 3/3] x86 / vmx: use a 'normal' domheap page for APIC_DEFAULT_PHYS_BASE

2020-01-23 Thread Durrant, Paul
> -Original Message- > From: Julien Grall > Sent: 23 January 2020 15:26 > To: Durrant, Paul ; xen-devel@lists.xenproject.org > Cc: Jan Beulich ; Andrew Cooper > ; Wei Liu ; Roger Pau Monné > ; George Dunlap ; Ian > Jackson ; Konrad Rzeszutek Wilk > ; Stefano Stabellini ; Jun > Nakajima ;

Re: [Xen-devel] [PATCH v3 3/3] x86 / vmx: use a 'normal' domheap page for APIC_DEFAULT_PHYS_BASE

2020-01-23 Thread George Dunlap
On 1/23/20 3:32 PM, Jan Beulich wrote: > On 23.01.2020 15:03, Paul Durrant wrote: >> vmx_alloc_vlapic_mapping() currently contains some very odd looking code >> that allocates a MEMF_no_owner domheap page and then shares with the guest >> as if it were a xenheap page. This then requires

Re: [Xen-devel] [PATCH v3 3/3] x86 / vmx: use a 'normal' domheap page for APIC_DEFAULT_PHYS_BASE

2020-01-23 Thread Jan Beulich
On 23.01.2020 15:03, Paul Durrant wrote: > vmx_alloc_vlapic_mapping() currently contains some very odd looking code > that allocates a MEMF_no_owner domheap page and then shares with the guest > as if it were a xenheap page. This then requires vmx_free_vlapic_mapping() > to call a special function

Re: [Xen-devel] [PATCH v3 3/3] x86 / vmx: use a 'normal' domheap page for APIC_DEFAULT_PHYS_BASE

2020-01-23 Thread Julien Grall
On 23/01/2020 14:03, Paul Durrant wrote: diff --git a/xen/common/domain.c b/xen/common/domain.c index ee3f9ffd3e..30c777acb8 100644 --- a/xen/common/domain.c +++ b/xen/common/domain.c @@ -339,6 +339,8 @@ static int sanitise_domain_config(struct xen_domctl_createdomain *config) return

Re: [Xen-devel] [PATCH v3 3/3] x86 / vmx: use a 'normal' domheap page for APIC_DEFAULT_PHYS_BASE

2020-01-23 Thread George Dunlap
On 1/23/20 2:03 PM, Paul Durrant wrote: > vmx_alloc_vlapic_mapping() currently contains some very odd looking code > that allocates a MEMF_no_owner domheap page and then shares with the guest > as if it were a xenheap page. This then requires vmx_free_vlapic_mapping() > to call a special function