Re: [Xen-devel] [PATCH v3 4/7] kconfig/gcov: rename to coverage

On Wed, Jan 24, 2018 at 11:35:51AM +, Ian Jackson wrote: > Wei Liu writes ("Re: [PATCH v3 4/7] kconfig/gcov: rename to coverage"): > > On Wed, Jan 24, 2018 at 11:27:22AM +, Ian Jackson wrote: > > > This hunk seems erroneous ? Surely the name should be updated, but > > > the #ifdef should

Re: [Xen-devel] [PATCH v3 4/7] kconfig/gcov: rename to coverage

Wei Liu writes ("Re: [PATCH v3 4/7] kconfig/gcov: rename to coverage"): > On Wed, Jan 24, 2018 at 11:27:22AM +, Ian Jackson wrote: > > This hunk seems erroneous ? Surely the name should be updated, but > > the #ifdef should remain. > > No the ifdef needs to go. > > There is a new stub

Re: [Xen-devel] [PATCH v3 4/7] kconfig/gcov: rename to coverage

On Wed, Jan 24, 2018 at 11:27:22AM +, Ian Jackson wrote: > Roger Pau Monne writes ("[PATCH v3 4/7] kconfig/gcov: rename to coverage"): > > So it can be used by both gcc and clang. Just add the Kconfig option > > and modify the makefiles so the llvm coverage specific code can be > > added in a

Re: [Xen-devel] [PATCH v3 4/7] kconfig/gcov: rename to coverage

Roger Pau Monne writes ("[PATCH v3 4/7] kconfig/gcov: rename to coverage"): > So it can be used by both gcc and clang. Just add the Kconfig option > and modify the makefiles so the llvm coverage specific code can be > added in a follow up patch. ... > diff --git a/xen/common/sysctl.c

Re: [Xen-devel] [PATCH v3 4/7] kconfig/gcov: rename to coverage

On Wed, Jan 24, 2018 at 10:01:22AM +, Roger Pau Monne wrote: > So it can be used by both gcc and clang. Just add the Kconfig option > and modify the makefiles so the llvm coverage specific code can be > added in a follow up patch. > > Signed-off-by: Roger Pau Monné >