Re: [Xen-devel] [PATCH v3 7/8] golang/xenlight: Notify xenlight of SIGCHLD

2020-01-17 Thread George Dunlap
On 1/17/20 6:13 PM, Nick Rosbrook wrote: >> // Context represents a libxl_ctx. >> type Context struct { >> - ctx*C.libxl_ctx >> - logger *C.xentoollog_logger_stdiostream >> + ctx *C.libxl_ctx >> + logger *C.xentoollog_logger_stdiostream >> + sigchld

Re: [Xen-devel] [PATCH v3 7/8] golang/xenlight: Notify xenlight of SIGCHLD

2020-01-17 Thread Nick Rosbrook
> // Context represents a libxl_ctx. > type Context struct { > - ctx*C.libxl_ctx > - logger *C.xentoollog_logger_stdiostream > + ctx *C.libxl_ctx > + logger *C.xentoollog_logger_stdiostream > + sigchld chan os.Signal > + sigchldDone chan

Re: [Xen-devel] [PATCH v3 7/8] golang/xenlight: Notify xenlight of SIGCHLD

2020-01-17 Thread George Dunlap
On 1/17/20 4:52 PM, Ian Jackson wrote: > George Dunlap writes ("[PATCH v3 7/8] golang/xenlight: Notify xenlight of > SIGCHLD"): >> libxl forks external processes and waits for them to complete; it >> therefore needs to be notified when children exit. >> >> In absence of instructions to the

Re: [Xen-devel] [PATCH v3 7/8] golang/xenlight: Notify xenlight of SIGCHLD

2020-01-17 Thread Ian Jackson
George Dunlap writes ("[PATCH v3 7/8] golang/xenlight: Notify xenlight of SIGCHLD"): > libxl forks external processes and waits for them to complete; it > therefore needs to be notified when children exit. > > In absence of instructions to the contrary, libxl sets up its own > SIGCHLD handlers.