Re: [Xen-devel] [PATCH v4 7/7] Added Resolving Disagreement

2020-01-06 Thread Jürgen Groß
On 06.01.20 13:54, Lars Kurth wrote: On 06/01/2020, 07:25, "Jürgen Groß" wrote: >+## Issue: Small functional issues >+ >+The most common area of disagreements which happen in code reviews, are >+differing opinions on whether small functional issues in a patch series

Re: [Xen-devel] [PATCH v4 7/7] Added Resolving Disagreement

2020-01-06 Thread Lars Kurth
On 06/01/2020, 07:25, "Jürgen Groß" wrote: >+## Issue: Small functional issues >+ >+The most common area of disagreements which happen in code reviews, are >+differing opinions on whether small functional issues in a patch series have to >+be resolved or not before the

Re: [Xen-devel] [PATCH v4 7/7] Added Resolving Disagreement

2020-01-05 Thread Jürgen Groß
On 30.12.19 20:32, Lars Kurth wrote: From: Lars Kurth This guide provides Best Practice on identifying and resolving common classes of disagreement Changes since v3 * Fixed broken http link (typo) Changes since v2 (added in v2) * Fix typos * Add section: "Issue: Multiple ways to solve a