Re: [Xen-devel] [PATCH v5 14/18] x86/mem_sharing: use default_access in add_to_physmap

2020-01-23 Thread Tamas K Lengyel
On Thu, Jan 23, 2020 at 9:44 AM George Dunlap wrote: > > On 1/22/20 5:08 PM, Tamas K Lengyel wrote: > > On Wed, Jan 22, 2020 at 8:35 AM Jan Beulich wrote: > >> > >> On 21.01.2020 18:49, Tamas K Lengyel wrote: > >>> When plugging a hole in the target physmap don't use the access permission > >>>

Re: [Xen-devel] [PATCH v5 14/18] x86/mem_sharing: use default_access in add_to_physmap

2020-01-23 Thread George Dunlap
On 1/22/20 5:08 PM, Tamas K Lengyel wrote: > On Wed, Jan 22, 2020 at 8:35 AM Jan Beulich wrote: >> >> On 21.01.2020 18:49, Tamas K Lengyel wrote: >>> When plugging a hole in the target physmap don't use the access permission >>> returned by __get_gfn_type_access as it can be non-sensical, >> >>

Re: [Xen-devel] [PATCH v5 14/18] x86/mem_sharing: use default_access in add_to_physmap

2020-01-22 Thread Tamas K Lengyel
On Wed, Jan 22, 2020 at 8:35 AM Jan Beulich wrote: > > On 21.01.2020 18:49, Tamas K Lengyel wrote: > > When plugging a hole in the target physmap don't use the access permission > > returned by __get_gfn_type_access as it can be non-sensical, > > "can be" is too vague for my taste - it suggests

Re: [Xen-devel] [PATCH v5 14/18] x86/mem_sharing: use default_access in add_to_physmap

2020-01-22 Thread Jan Beulich
On 21.01.2020 18:49, Tamas K Lengyel wrote: > When plugging a hole in the target physmap don't use the access permission > returned by __get_gfn_type_access as it can be non-sensical, "can be" is too vague for my taste - it suggests there may also be cases where a sensible value is returned, and